[HTTPCLIENT-1284] Cookie matching issue with virtual hosts

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.2.2, 4.2.3
• Fix Version/s: 4.2.3
• Component/s: HttpClient (classic)
• Assignee: Unassigned
• Reporter: Nicolas Richeton
• Created: 19/Dec/12 19:30
• Updated: 05/Oct/13 19:41
• Resolved: 20/Dec/12 12:58

Description

Following HTTPCLIENT-1282, there is an issue with cookie matching : only target host is used for cookie origin, but with virtual host, this value is not the real host from the client point of view.

As a result, cookies get discarded by httpclient even if they match the virtual host and would have been accepted by a browser.

See the code of the following methods :

RequestAddCookies#process()

HttpHost targetHost = (HttpHost) context.getAttribute( ExecutionContext.HTTP_TARGET_HOST);
...
String hostName = targetHost.getHostName();
...
CookieOrigin cookieOrigin = new CookieOrigin( hostName, port, requestURI.getPath(), conn.isSecure());

And

ResponseProcessCookies#process()

CookieOrigin cookieOrigin = (CookieOrigin) context.getAttribute(ClientContext.COOKIE_ORIGIN);
...
processCookies(it, cookieSpec, cookieOrigin, cookieStore);