[HTTPCLIENT-1281] GzipDecompressingEntity does not release InputStream when an IOException occurs while reading the Gzip header

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 4.2.2, 4.2.3
• Fix Version/s: 4.2.3
• Component/s: HttpClient (classic)
• Assignee: Unassigned
• Reporter: Francois-Xavier Bonnet
• Created: 17/Dec/12 14:37
• Updated: 05/Oct/13 19:42
• Resolved: 17/Dec/12 16:18

Description

When calling method org.apache.http.client.entity.DecompressingEntity.getContent() for a GzipDecompressingEntity, the method tries to build a GZIPInputStream, then the GzipInputStream tries to read the Gzip header and fails throwing an IOException.
At the end you get an Exception but the backend InputStream is never closed resulting in a connection leak.

Here is a test to reproduce:
@Test
public void testGzipDecompressingEntityDoesNotCrashInConstructorAndLeaveInputStreamOpen()
throws Exception {
final AtomicBoolean inputStreamIsClosed = new AtomicBoolean(false);
HttpEntity in = new InputStreamEntity(new InputStream() {
@Override
public int read() throws IOException

{ throw new IOException("An exception occurred"); }

@Override
public void close() throws IOException

{ inputStreamIsClosed.set(true); }

}, 123);
GzipDecompressingEntity gunzipe = new GzipDecompressingEntity(in);
try

{ InputStream is = gunzipe.getContent(); }

catch (IOException e)

{ // As I cannot get the content, GzipDecompressingEntity is supposed // to have released everything Assert.assertTrue(inputStreamIsClosed.get()); }

}