[HTTPCLIENT-1248] LaxRedirectStrategy converts POST to GET and throws away body

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.2.1
• Fix Version/s: 4.2.2
• Assignee: Unassigned
• Reporter: Justus Pendleton
• Created: 10/Oct/12 00:00
• Updated: 05/Oct/13 19:41
• Resolved: 10/Oct/12 20:53

Description

The LaxRedirectStrategy extends the DefaultRedirectStrategy. The DefaultAsyncRequestDirector calls redirectStrategy.isRedirected() and LaxRedirectStrategy will return true on a POST. Then the director calls redirectStrategy.getRedirect(). The LaxRedirectStrategy doesn't implement this method so the one in the DefaultRedirectStrategy is called:

        if (method.equalsIgnoreCase(HttpHead.METHOD_NAME)) {
            return new HttpHead(uri);
        } else {
            return new HttpGet(uri);
        }

This turns the POST into a GET on redirect. IMHO the LaxRedirectStrategy should be

    public HttpUriRequest getRedirect(
            final HttpRequest request,
            final HttpResponse response,
            final HttpContext context) throws ProtocolException {
        URI uri = getLocationURI(request, response, context);
        String method = request.getRequestLine().getMethod();
        if (method.equalsIgnoreCase(HttpHead.METHOD_NAME)) {
            return new HttpHead(uri);
        else if (method.equalsIgnoreCase(HttpPost.METHOD_NAME)) {
            return new HttpPost(uri);
        } else if (method.equalsIgnoreCase(HttpGet.METHOD_NAME)) {
            return new HttpGet(uri);
        } else {
            throw new IllegalStateException("Redirect called on un-redirectable http method: " + method);
    }