[HTTPCLIENT-1230] BasicClientConnectionManager is not thread safe, remove @ThreadSafe annotation

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 4.2 Final
• Fix Version/s: 4.3 Alpha1
• Component/s: Documentation
• Assignee: Unassigned
• Reporter: Chris Lott
• Created: 02/Sep/12 19:42
• Updated: 05/Oct/13 19:42
• Resolved: 09/Sep/12 11:09

Description

I would like to suggest removing the @ThreadSafe annotation on BasicClientConnectionManager. The javadoc clearly notes "it ought to be used by one execution thread only". Seems like a basic contradiction.

Perhaps I am fundamentally not understanding the @ThreadSafe annotation. I thought that meant the class either has no static fields and/or creates all new objects and/or handles all necessary synchronization so that any number of threads may share an instance. What does it mean here, on a class that wraps a single connection for which access must be synchronized?

Yes, after this problem bit us we switched to using PoolingClientConnectionManager.

Thanks for considering this issue.