[HTTPCLIENT-1164] Compressed entities are not being cached properly

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 4.2 Final
• Component/s: HttpClient (classic)
• Assignee: Jonathan Moore
• Reporter: Manish Tripathi
• Created: 14/Feb/12 09:19
• Updated: 05/Oct/13 19:42
• Resolved: 16/Mar/12 15:02

Description

org.apache.http.impl.client.cache.CacheValidityPolicy.contentLengthHeaderMatchesActualLength() returns false for entities decompressed by ContentEncodingHttpClient, because the length of decompressed entity stored in cache will be different from the length specified in the response header.
Consequently, gzipped/deflated entities will never be satisfied from the cache.

Proposed fix: introduce new field in HttpCacheEntry() - actualContentLength, and populate it with the actual content length rigth before the cache entry is stored in the cache. Change the org.apache.http.impl.client.cache.CacheValidityPolicy.contentLengthHeaderMatchesActualLength() method to compare
entry.getResource().length() with entry.getActualContentLength()