[HTTPCLIENT-1120] DefaultHttpRequestRetryHandler#retryRequest should not retry aborted requests

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.1.2
• Fix Version/s: 4.1.3, 4.2 Alpha1
• Component/s: HttpClient (classic)
• Assignee: Unassigned
• Reporter: Sebb
• Created: 31/Aug/11 10:10
• Updated: 05/Oct/13 19:41
• Resolved: 06/Oct/11 12:42

Description

DefaultHttpRequestRetryHandler#retryRequest incorrectly retries aborted requests; I have seen the following log messages in JMeter:

org.apache.http.impl.client.DefaultHttpClient: I/O exception (java.net.SocketException) caught when processing request: socket closed
org.apache.http.impl.client.DefaultHttpClient: Retrying request

and

org.apache.http.impl.client.DefaultHttpClient: I/O exception (java.net.BindException) caught when connecting to the target host: Address already in use: connect
org.apache.http.impl.client.DefaultHttpClient: Retrying connect

The abort() method sets the isAborted() flag, but the retry handler does not check it.