Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.1.1
    • Fix Version/s: 4.2 Alpha1
    • Component/s: HttpCache
    • Labels:

      Description

      ResponseCachingPolicy currently uses integers for interpreting the size of Content-Length, as well internally.

      This causes issues in attempting to use the module for caching entities that are over 2GB in size, the module does not fail gracefully, but throws a NumberFormatException

      I have a patch that fixes this, by promoting the int -> long, which should allow for larger entities to be cached, it also updates the public facing API where possible, I don't think that the promotion should break compatibility massively

      The changes can also be seen here:
      https://github.com/GregBowyer/httpclient/commit/1197d3f94bd2eedcec32646cd6146748ca2e6fa1

        Activity

        Greg Bowyer created issue -
        Greg Bowyer made changes -
        Field Original Value New Value
        Description ResponseCachingPolicy currently uses integers for interpreting the size of Content-Length, as well internally.

        This causes issues in attempting to use the module for caching entities that are over 2GB in size, the module does not fail gracefully, but throws a NumberFormatException

        I have a patch that fixes this, by promoting the int -> long, which should allow for larger entities to be cached, it also updates the public facing API where possible, I don't think that the promotion should break compatibility massively
        ResponseCachingPolicy currently uses integers for interpreting the size of Content-Length, as well internally.

        This causes issues in attempting to use the module for caching entities that are over 2GB in size, the module does not fail gracefully, but throws a NumberFormatException

        I have a patch that fixes this, by promoting the int -> long, which should allow for larger entities to be cached, it also updates the public facing API where possible, I don't think that the promotion should break compatibility massively

        The changes can also be seen here:
        https://github.com/GregBowyer/httpclient/commit/1197d3f94bd2eedcec32646cd6146748ca2e6fa1
        Greg Bowyer made changes -
        Oleg Kalnichevski made changes -
        Fix Version/s 4.2 Alpha1 [ 12316315 ]
        Affects Version/s 4.2 Alpha1 [ 12316315 ]
        Oleg Kalnichevski made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Oleg Kalnichevski made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Greg Bowyer
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development