[HTRACE-393] Binary annotations are being shown as base64 in the zipkin frontend

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.3
• Fix Version/s: 4.3
• Component/s: zipkin
• Assignee: Raam
• Reporter: Raam
• Created: 03/Jan/17 16:29
• Updated: 03/Jan/17 21:08
• Resolved: 03/Jan/17 21:01

Description

As discussed in the mailing list:
Seems like HTraceToZipkinConverter.java tags all binary annotations as the BYTES thrift data type although a string is being sent https://github.com/apache/incubator-htrace/blob/master/htrace-zipkin/src/main/java/org/apache/htrace/zipkin/HTraceToZipkinConverter.java#L156.

A string is always sent since this is the signature of TraceScope.addKVAnnotation: public void addKVAnnotation(String key, String value)