[HTRACE-32] Change span timeline annotations map to be a map<string, string>

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.2.0
• Assignee: Colin McCabe
• Reporter: Colin McCabe
• Created: 30/Dec/14 20:30
• Updated: 17/Feb/15 22:05
• Resolved: 07/Jan/15 00:31

Description

We should consider changing the timeline annotations in Span.java to be a map<string, string> rather than a map<byte[], byte[]>. It's very inconvenient to deal with byte arrays here, and every use-case we have currently puts string data into these fields. One example is that you cannot look up fields in the map, since the map<byte[], byte[]> compares by byte array object equality (useless unless you have the original key array object you inserted). It's also questionable if we could put non-string data in this map at all, since we are serializing them to JSON strings, which can't handle arbitrary byte strings.

Issue Links

• is depended upon by: HBASE-13060 Don't use deprecated HTrace API addKVAnnotation(byte[], byte[])