Uploaded image for project: 'HTrace'
  1. HTrace
  2. HTRACE-300

Reaper should be initialized before shards are activated

Details

    • Bug
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 4.1
    • 4.1
    • htraced
    • None
    • 4.1

    Description

      I saw intermittent test failures due to nil pointer dereference in pruneExpired.

      Attachments

        1. HTRACE-300.001.patch
          0.8 kB
          Masatake Iwasaki

        Activity

               [exec] goroutine 220 [running]:
               [exec] org/apache/htrace/htraced.(*shard).pruneExpired(0xc82013a4b0)
               [exec]     /home/iwasakims/srcs/htrace/htrace-htraced/go/src/org/apache/htrace/htraced/datastore.go:154 +0x53
               [exec] org/apache/htrace/htraced.(*shard).processIncoming(0xc82013a4b0)
               [exec]     /home/iwasakims/srcs/htrace/htrace-htraced/go/src/org/apache/htrace/htraced/datastore.go:148 +0x833
               [exec] created by org/apache/htrace/htraced.CreateDataStore
               [exec]     /home/iwasakims/srcs/htrace/htrace-htraced/go/src/org/apache/htrace/htraced/datastore.go:518 +0x8b5
          
          iwasakims Masatake Iwasaki added a comment - [exec] goroutine 220 [running]: [exec] org/apache/htrace/htraced.(*shard).pruneExpired(0xc82013a4b0) [exec] /home/iwasakims/srcs/htrace/htrace-htraced/go/src/org/apache/htrace/htraced/datastore.go:154 +0x53 [exec] org/apache/htrace/htraced.(*shard).processIncoming(0xc82013a4b0) [exec] /home/iwasakims/srcs/htrace/htrace-htraced/go/src/org/apache/htrace/htraced/datastore.go:148 +0x833 [exec] created by org/apache/htrace/htraced.CreateDataStore [exec] /home/iwasakims/srcs/htrace/htrace-htraced/go/src/org/apache/htrace/htraced/datastore.go:518 +0x8b5
          cmccabe Colin McCabe added a comment -

          +1. Thanks, iwasakims.

          cmccabe Colin McCabe added a comment - +1. Thanks, iwasakims .
          hudson Hudson added a comment -

          SUCCESS: Integrated in HTrace-Master #207 (See https://builds.apache.org/job/HTrace-Master/207/)
          HTRACE-300. Reaper should be initialized before shards are activated (cmccabe: rev 3845a187e2b46b9643c780aef9ab032bd77a0246)

          • htrace-htraced/go/src/org/apache/htrace/htraced/datastore.go
          hudson Hudson added a comment - SUCCESS: Integrated in HTrace-Master #207 (See https://builds.apache.org/job/HTrace-Master/207/ ) HTRACE-300 . Reaper should be initialized before shards are activated (cmccabe: rev 3845a187e2b46b9643c780aef9ab032bd77a0246) htrace-htraced/go/src/org/apache/htrace/htraced/datastore.go

          People

            iwasakims Masatake Iwasaki
            iwasakims Masatake Iwasaki
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: