Uploaded image for project: 'HTrace'
  1. HTrace
  2. HTRACE-276

Shade classes into org.apache.htrace.shaded rather than org.apache.htrace

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 4.0
    • 4.1
    • build
    • None
    • 4.1

    Description

      We should shade classes into org.apache.htrace.shaded rather than org.apache.htrace. This will prevent two classes with the same name from being on the CLASSPATH if both HTrace 3.x and 4.x jars are both there. This will make it possible for us to change the version of dependencies without issues in the future.

      Attachments

        1. HTRACE-276.001.patch
          6 kB
          Colin McCabe

        Activity

          stack Michael Stack added a comment -

          Seems fine. This a 4.1 change? Needs fat release note I'd say.

          stack Michael Stack added a comment - Seems fine. This a 4.1 change? Needs fat release note I'd say.
          cmccabe Colin McCabe added a comment -

          Hmm. Where should we add a release note? These classes are used only internally.

          cmccabe Colin McCabe added a comment - Hmm. Where should we add a release note? These classes are used only internally.
          stack Michael Stack added a comment -

          Ok. Now I follow what is going on. +1

          stack Michael Stack added a comment - Ok. Now I follow what is going on. +1
          cmccabe Colin McCabe added a comment -

          Thanks, stack

          cmccabe Colin McCabe added a comment - Thanks, stack
          hudson Hudson added a comment -

          SUCCESS: Integrated in HTrace-Master #127 (See https://builds.apache.org/job/HTrace-Master/127/)
          HTRACE-276. Shade classes into org.apache.htrace.shaded rather than (cmccabe: rev 43ce2136a3c4bd8f2eeb296d2b1d4d0d516c3088)

          • htrace-hbase/pom.xml
          • htrace-zipkin/pom.xml
          • htrace-htraced/pom.xml
          • htrace-core4/pom.xml
          hudson Hudson added a comment - SUCCESS: Integrated in HTrace-Master #127 (See https://builds.apache.org/job/HTrace-Master/127/ ) HTRACE-276 . Shade classes into org.apache.htrace.shaded rather than (cmccabe: rev 43ce2136a3c4bd8f2eeb296d2b1d4d0d516c3088) htrace-hbase/pom.xml htrace-zipkin/pom.xml htrace-htraced/pom.xml htrace-core4/pom.xml

          People

            cmccabe Colin McCabe
            cmccabe Colin McCabe
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: