[HTRACE-233] htrace-zipkin should explicitly include slf4j-api to avoid ClassNotFoundException

• Type: Bug
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 4.0
• Fix Version/s: 4.0
• Component/s: build
• Target Version/s: 4.0
• Assignee: Cosmin Lehene
• Reporter: Cosmin Lehene
• Created: 02/Sep/15 01:57
• Updated: 14/Oct/15 00:55
• Resolved: 02/Sep/15 18:39

Description

  at com.intellij.rt.execution.application.AppMain.main(AppMain.java:140)
Caused by: java.lang.NoClassDefFoundError: org/apache/htrace/slf4j/LoggerFactory
  at org.apache.htrace.thrift.transport.TIOStreamTransport.<clinit>(TIOStreamTransport.java:38)
  at org.apache.htrace.impl.ZipkinSpanReceiver$WriteSpanRunnable.<init>(ZipkinSpanReceiver.java:214)
  at org.apache.htrace.impl.ZipkinSpanReceiver.configure(ZipkinSpanReceiver.java:178)
  at org.apache.htrace.impl.ZipkinSpanReceiver.<init>(ZipkinSpanReceiver.java:155)
  ... 36 more
Caused by: java.lang.ClassNotFoundException: org.apache.htrace.slf4j.LoggerFactory
  at java.net.URLClassLoader$1.run(URLClassLoader.java:372)
  at java.net.URLClassLoader$1.run(URLClassLoader.java:361)

Looking in the jar I can only see the following classes

org/apache/htrace/slf4j/impl/NOPLoggerFactory.class
org/apache/htrace/slf4j/impl/StaticLoggerBinder.class
org/apache/htrace/slf4j/impl/StaticMarkerBinder.class
org/apache/htrace/slf4j/impl/StaticMDCBinder.class

LoggerFactory is in slf4j-api which is not included explicitly and not picked up during relocation.

I'll send a patch

Issue Links

• breaks: HTRACE-240 Remove duplicate slf4j-api dependency in htrace-zipkin/pom.xml