[HOP-3878] hop-gui.bat doesn't start correctly if any of the hop_xxx enviro variables are ugly

• Type: Improvement
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Fix Version/s: Migrated to GHI
• Component/s: Hop Config, Hop GUI
• Labels: environment hop-encrypt hop-gui options
• Assignee: Unassigned
• Reporter: Paul Drangeid
• Created: 27/Mar/22 17:23
• Updated: 17/Mar/23 13:32
• Resolved: 17/Mar/23 13:32

Description

I tried setting my HOP_CONFIG_FOLDER to use my onedrive:
SETX HOP_CONFIG_FOLDER "%ONEDRIVE%\hop-config"

GUI would not launch the JAVA VM.
My onedrive folder path is ugly with both spaces and a dash in the path.

I manually fixed it in the hop-gui by quoting the add:
if not "%HOP_CONFIG_FOLDER%"=="" (
  set HOP_OPTIONS=%HOP_OPTIONS% -DHOP_CONFIG_FOLDER="%HOP_CONFIG_FOLDER%"
)

Don't think there would be any harm in quoting ALL these options in the batch/script files, then it would elegantly handle UGLY paths automatically.
This change should also be applied to utilities like hop-encrypt (really any batch/sh script that launches the hop tools)

Issue Links

• relates to: HOP-3879 Have MS Windows bat files fully quote paths to deal with spaces in directory structures.