[HOP-2243] GuiResource is buggy with same image in two different sizes

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 0.50
• Component/s: GUI
• Assignee: Nicolas Adment
• Reporter: Nicolas Adment
• Created: 29/Nov/20 17:19
• Updated: 30/Nov/20 14:50
• Resolved: 30/Nov/20 14:50

Description

I think GuiResource is buggy when we want to get the same image in two different sizes.

 

I propose to correct as follows:

public Image getImage( String location, ClassLoader classLoader, int width, int height ) {
// Build image key for a specific size
++ StringBuilder builder = new StringBuilder(location);
++ builder.append('|');
++ builder.append(width);
++ builder.append('|');
++ builder.append(height);
++ String key = builder.toString();
– Image image = imageMap.get( location );
++ Image image = imageMap.get( key );
if ( image == null )

{ SwtUniversalImage svg = SwtSvgImageUtil.getUniversalImage( display, classLoader, location ); image = new Image( display, getZoomedImaged( svg, display, width, height ), SWT.IMAGE_COPY ); svg.dispose(); ++ imageMap.put( key, image ); -- imageMap.put( location, image ); }

return image;
}