Uploaded image for project: 'Apache Hop (Retired)'
  1. Apache Hop (Retired)
  2. HOP-2182

Remove dependencies on conflicting licenses

Details

    • Task
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 0.70
    • Build

    Description

      Our dependencies still contain some references to third GPL and LGPL libraries.

      We see this when we run mvn license:aggregate-add-third-party

      **In a lot of cases we can simply remove these.  In other cases we need to find replacements for the used libraries.  Sometimes it might make more sense to move the offending code somewhere else (in case of plugins).

      Attachments

        Issue Links

          Activity

            Dependencies to remove:

            • iijdbc
            • jfreechart
            • MySQL Connector/J
            • jxl
            • jTDS
            • mariadb-java-client
            • syslog4j

             

            Unknown License (To Check):

            • redshift-jdbc42
            • greenplum-jdbc
            • javax.wsdl
            • ldapsdk
            • log4j
            • oro

             

            hansva Hans Van Akelyen added a comment - Dependencies to remove: iijdbc jfreechart MySQL Connector/J jxl jTDS mariadb-java-client syslog4j   Unknown License (To Check): redshift-jdbc42 greenplum-jdbc javax.wsdl ldapsdk log4j oro  
            mcasters Matt Casters added a comment -

            At the very least let's get rid of JFreeChart:  https://github.com/apache/incubator-hop/pull/382

             

            mcasters Matt Casters added a comment - At the very least let's get rid of JFreeChart:  https://github.com/apache/incubator-hop/pull/382  
            mcasters Matt Casters added a comment - - edited

            On the Amazon Redshift JDBC driver:  https://repository.mulesoft.org/nexus/content/repositories/public/com/amazon/redshift/redshift-jdbc42/1.2.43.1067/   it contains a license file indicating it's Apache licensed in META-INF/LICENSE.txt

             

            mcasters Matt Casters added a comment - - edited On the Amazon Redshift JDBC driver:  https://repository.mulesoft.org/nexus/content/repositories/public/com/amazon/redshift/redshift-jdbc42/1.2.43.1067/    it contains a license file indicating it's Apache licensed in META-INF/LICENSE.txt  
            mcasters Matt Casters added a comment - - edited

            Move to external plugin:

            • wsdl4j dependency : from hop-transform-webservices
            • syslog4j :  from hop-action-syslog
            • iijdbc : from hop-databases-ingres
            • mariadb-java-client : from hop-databases-mariadb
            • mysql-connector-java : from hop-database-mysql  
            • greenplum-jdbc : from hop-databases-greenplumb
            • jtds : from hop-databases-sybase and hop-databases-mssql (http://jtds.sourceforge.net/)

             

            mcasters Matt Casters added a comment - - edited Move to external plugin: wsdl4j dependency : from hop-transform-webservices syslog4j :  from hop-action-syslog iijdbc : from hop-databases-ingres mariadb-java-client : from hop-databases-mariadb mysql-connector-java : from hop-database-mysql   greenplum-jdbc : from hop-databases-greenplumb jtds : from hop-databases-sybase and hop-databases-mssql ( http://jtds.sourceforge.net/)  
            mcasters Matt Casters added a comment - - edited

            ldapsdk: used by plugins-transform-ldifinput

            Perhaps change/upgrade to https://mvnrepository.com/artifact/com.unboundid/unboundid-ldapsdk/5.1.1 which also carries an Apache License.

            mcasters Matt Casters added a comment - - edited ldapsdk: used by plugins-transform-ldifinput Perhaps change/upgrade to https://mvnrepository.com/artifact/com.unboundid/unboundid-ldapsdk/5.1.1  which also carries an Apache License.
            mcasters Matt Casters added a comment -

            com.wcohen.secondstring : used by hop-transform-calculator to calculate a "Needleman Wunsch" score between 2 strings.
            It's mainly used in bio informatics on DNA sequences.

            I suggest to either re-implement the algorithm and to donate it to Apache Commons if the need should ever arise.  In the meantime I think we can delete this function in the Calculator transform.

            mcasters Matt Casters added a comment - com.wcohen.secondstring : used by hop-transform-calculator to calculate a "Needleman Wunsch" score between 2 strings. It's mainly used in bio informatics on DNA sequences. I suggest to either re-implement the algorithm and to donate it to Apache Commons if the need should ever arise.  In the meantime I think we can delete this function in the Calculator transform.
            mcasters Matt Casters added a comment -

            oro is org.apache.oro : https://mvnrepository.com/artifact/oro/oro/2.0.8

            Not directly used but dragged in by another depdendency.

            Brought in by 

            org.apache.hop:hop-plugins-engines-beam:jar:0.50-SNAPSHOT
             - org.apache.spark:spark-core_2.11:jar:2.4.6:compile
               - oro:oro:jar:2.0.8:compile

            mcasters Matt Casters added a comment - oro is org.apache.oro : https://mvnrepository.com/artifact/oro/oro/2.0.8 Not directly used but dragged in by another depdendency. Brought in by  org.apache.hop:hop-plugins-engines-beam:jar:0.50-SNAPSHOT  - org.apache.spark:spark-core_2.11:jar:2.4.6:compile    - oro:oro:jar:2.0.8:compile
            mcasters Matt Casters added a comment -

            jxl :

            1) remove jxl dependency from hop-transform-excelinput (jxl package)

            2) replace jxl dependency in hop-transform-exceloutput with Apache POI

             

            mcasters Matt Casters added a comment - jxl : 1) remove jxl dependency from hop-transform-excelinput (jxl package) 2) replace jxl dependency in hop-transform-exceloutput with Apache POI  
            mcasters Matt Casters added a comment -

            org.safehaus.jug:jug

            Mainly used to generate UUIDs.   Removed in https://github.com/apache/incubator-hop/pull/383

            mcasters Matt Casters added a comment - org.safehaus.jug:jug Mainly used to generate UUIDs.   Removed in  https://github.com/apache/incubator-hop/pull/383
            mcasters Matt Casters added a comment -

            All these dependencies are gone now.  We're still having the database plugins but we're not shipping the conflicting libraries.

            mcasters Matt Casters added a comment - All these dependencies are gone now.  We're still having the database plugins but we're not shipping the conflicting libraries.

            People

              Unassigned Unassigned
              mcasters Matt Casters
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 1h
                  1h