[HIVE-9981] Avoid throwing many exceptions when attempting to create new hdfs encryption shim

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.2.0
• Component/s: Encryption
• Assignee: Sergio Peña
• Reporter: Sergio Peña
• Created: 16/Mar/15 17:33
• Updated: 18/May/15 19:55
• Resolved: 19/Mar/15 04:36

Description

Hadoop23Shims.createHdfsEncryptionShim() is throwing an exception for verions lower than 2.6.0 everytime a query is executed.

Exceptions are expensive, so rather than throwing them every time, we can use this design pattern followed for some other functions in Hadoop23Shims -

  protected static final Method accessMethod;
  protected static final Method getPasswordMethod;

  static {
    Method m = null;
    try {
      m = FileSystem.class.getMethod("access", Path.class, FsAction.class);
    } catch (NoSuchMethodException err) {
      // This version of Hadoop does not support FileSystem.access().
    }
    accessMethod = m;

    try {
      m = Configuration.class.getMethod("getPassword", String.class);
    } catch (NoSuchMethodException err) {
      // This version of Hadoop does not support getPassword(), just retrieve password from conf.
      m = null;
    }
    getPasswordMethod = m;
  }

Issue Links

• is related to: HIVE-9957 Hive 1.1.0 not compatible with Hadoop 2.4.0