Details

    • Sub-task
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 1.2.0
    • None
    • None

    Description

      The DATE type was implemented in HIVE-8119. And new parquet Types API builder was used in HIVE-9657 for all data types. But DATE is missed.

      We should also use new Types API for DATE type.

      Attachments

        1. HIVE-9894.patch
          1 kB
          Dong Chen

        Issue Links

          Activity

            dongc Dong Chen added a comment -

            A small change for DATE using new Parquet Types API builder.

            spena, Ferd, could you help to review this?

            dongc Dong Chen added a comment - A small change for DATE using new Parquet Types API builder. spena , Ferd , could you help to review this?
            Ferd Ferdinand Xu added a comment -

            LGTM, +1

            Ferd Ferdinand Xu added a comment - LGTM, +1
            spena Sergio Peña added a comment -

            +1

            spena Sergio Peña added a comment - +1
            hiveqa Hive QA added a comment -

            Overall: +1 all checks pass

            Here are the results of testing the latest attachment:
            https://issues.apache.org/jira/secure/attachment/12703358/HIVE-9894.patch

            SUCCESS: +1 7612 tests passed

            Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/2977/testReport
            Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/2977/console
            Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-2977/

            Messages:

            Executing org.apache.hive.ptest.execution.PrepPhase
            Executing org.apache.hive.ptest.execution.ExecutionPhase
            Executing org.apache.hive.ptest.execution.ReportingPhase
            

            This message is automatically generated.

            ATTACHMENT ID: 12703358 - PreCommit-HIVE-TRUNK-Build

            hiveqa Hive QA added a comment - Overall : +1 all checks pass Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12703358/HIVE-9894.patch SUCCESS: +1 7612 tests passed Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/2977/testReport Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/2977/console Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-2977/ Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase This message is automatically generated. ATTACHMENT ID: 12703358 - PreCommit-HIVE-TRUNK-Build
            dongc Dong Chen added a comment -

            Hi brocknoland, would you like to take a look at this? Thanks!

            dongc Dong Chen added a comment - Hi brocknoland , would you like to take a look at this? Thanks!
            brocknoland Brock Noland added a comment -

            +1

            brocknoland Brock Noland added a comment - +1
            dongc Dong Chen added a comment -

            Thanks for your review!! Ferd, spena, brocknoland

            dongc Dong Chen added a comment - Thanks for your review!! Ferd , spena , brocknoland
            csun Chao Sun added a comment -

            Committed to trunk. Thanks Dong!

            csun Chao Sun added a comment - Committed to trunk. Thanks Dong!

            This issue has been fixed and released as part of the 1.2.0 release. If you find an issue which seems to be related to this one, please create a new jira and link this one with new jira.

            sushanth Sushanth Sowmyan added a comment - This issue has been fixed and released as part of the 1.2.0 release. If you find an issue which seems to be related to this one, please create a new jira and link this one with new jira.

            People

              dongc Dong Chen
              dongc Dong Chen
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: