[HIVE-9749] ObjectStore schema verification logic is incorrect

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.13.1, 0.14.0, 1.0.0, 1.1.0
• Fix Version/s: 1.2.0
• Component/s: Metastore
• Labels: TODOC1.2
• Assignee: Brock Noland
• Reporter: Brock Noland
• Created: 22/Feb/15 22:41
• Updated: 18/May/15 19:51
• Resolved: 24/Feb/15 17:24

Description

Specifically when the versions are the same, we still try and record a new version:

      // metastore schema version is different than Hive distribution needs
      if (strictValidation) {
        if (!schemaVer.equalsIgnoreCase(MetaStoreSchemaInfo.getHiveSchemaVersion())) {
          throw new MetaException("Hive Schema version "
              + MetaStoreSchemaInfo.getHiveSchemaVersion() +
              " does not match metastore's schema version " + schemaVer +
              " Metastore is not upgraded or corrupt");
        } else {
          LOG.warn("Metastore version was " + schemaVer + " " +
              HiveConf.ConfVars.METASTORE_SCHEMA_VERIFICATION.toString() +
              " is not enabled so recording the new schema version " +
              MetaStoreSchemaInfo.getHiveSchemaVersion());
          setMetaStoreSchemaVersion(MetaStoreSchemaInfo.getHiveSchemaVersion(),
              "Set by MetaStore");
        }

additionally an ObjectStore object is created for all clients. As such we'll also make the verification complete flag static.