[HIVE-9183] Compilation against HBase 1.0.0 fails due to missing dependency on high_scale_lib.Counter

• Type: Task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.1.0
• Assignee: Ted Yu
• Reporter: Ted Yu
• Created: 20/Dec/14 21:54
• Updated: 12/Feb/15 23:40
• Resolved: 06/Jan/15 23:30

Description

In the HBase 1.0.0 release, org.cliffc.high_scale_lib is no longer used.
HBaseStorageHandler.java has compile time dependency on high_scale_lib.Counter
Compilation against HBase 1.0.0 release would fail due to the missing dependency.
The following change would allow compilation to pass:

diff --git a/hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseStorageHandler.java b/hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseStorageHandler.java
index 3218639..6f626f0 100644
--- a/hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseStorageHandler.java
+++ b/hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseStorageHandler.java
@@ -499,8 +499,8 @@ public void configureJobConf(TableDesc tableDesc, JobConf jobConf) {
        * only need TableMapReduceUtil.addDependencyJars(jobConf) here.
        */
       TableMapReduceUtil.addDependencyJars(
-          jobConf, HBaseStorageHandler.class, TableInputFormatBase.class,
-          org.cliffc.high_scale_lib.Counter.class); // this will be removed for HBase 1.0
+          jobConf, HBaseStorageHandler.class, TableInputFormatBase.class);
+          // org.cliffc.high_scale_lib.Counter.class); this will be removed for HBase 1.0
       Set<String> merged = new LinkedHashSet<String>(jobConf.getStringCollection("tmpjars"));

       Job copy = new Job(jobConf);

However, loading of high_scale_lib.Counter should be done at runtime so that 0.98 and 1.0 releases are both supported.