Uploaded image for project: 'Hive'
  1. Hive
  2. HIVE-9155

HIVE_LOCKS uses int instead of bigint hive-txn-schema-0.14.0.mssql.sql

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.14.0
    • Fix Version/s: 1.0.0
    • Component/s: Metastore
    • Labels:
      None

      Description

      HL_LAST_HEARTBEAT and HL_ACQUIRED_AT should use bigint which is 8 bytes and big enough for timestamp.hive-schema-0.15.0.mssql.sql is already correct.

      1. HIVE-9155.patch
        5 kB
        Eugene Koifman
      2. HIVE-9155.2.patch
        5 kB
        Eugene Koifman
      3. HIVE-9155.3.patch
        6 kB
        Eugene Koifman

        Activity

        Hide
        ekoifman Eugene Koifman added a comment -
        Show
        ekoifman Eugene Koifman added a comment - Alan Gates
        Hide
        ekoifman Eugene Koifman added a comment -

        actually TXNS.TXN_STARTED and TXNS.TXN_LAST_HEARTBEAT have the same issue
        also fixed "^M" line endings

        Show
        ekoifman Eugene Koifman added a comment - actually TXNS.TXN_STARTED and TXNS.TXN_LAST_HEARTBEAT have the same issue also fixed "^M" line endings
        Hide
        hiveqa Hive QA added a comment -

        Overall: -1 at least one tests failed

        Here are the results of testing the latest attachment:
        https://issues.apache.org/jira/secure/attachment/12687904/HIVE-9155.2.patch

        ERROR: -1 due to 2 failed/errored test(s), 6713 tests executed
        Failed tests:

        org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver_optimize_nullscan
        org.apache.hive.hcatalog.streaming.TestStreaming.testEndpointConnection
        

        Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/2120/testReport
        Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/2120/console
        Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-2120/

        Messages:

        Executing org.apache.hive.ptest.execution.PrepPhase
        Executing org.apache.hive.ptest.execution.ExecutionPhase
        Executing org.apache.hive.ptest.execution.ReportingPhase
        Tests exited with: TestsFailedException: 2 tests failed
        

        This message is automatically generated.

        ATTACHMENT ID: 12687904 - PreCommit-HIVE-TRUNK-Build

        Show
        hiveqa Hive QA added a comment - Overall : -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12687904/HIVE-9155.2.patch ERROR: -1 due to 2 failed/errored test(s), 6713 tests executed Failed tests: org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver_optimize_nullscan org.apache.hive.hcatalog.streaming.TestStreaming.testEndpointConnection Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/2120/testReport Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/2120/console Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-2120/ Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 2 tests failed This message is automatically generated. ATTACHMENT ID: 12687904 - PreCommit-HIVE-TRUNK-Build
        Hide
        alangates Alan Gates added a comment -

        We should make sure hive-txn-schema-0.14 is in sync with hive-schema-0.14. There are a number of fields in the latter that have moved to bigint.

        Show
        alangates Alan Gates added a comment - We should make sure hive-txn-schema-0.14 is in sync with hive-schema-0.14. There are a number of fields in the latter that have moved to bigint.
        Hide
        ekoifman Eugene Koifman added a comment -

        patch 3 has all the changes to bring the 2 files in sync

        Show
        ekoifman Eugene Koifman added a comment - patch 3 has all the changes to bring the 2 files in sync
        Hide
        alangates Alan Gates added a comment -

        +1

        Show
        alangates Alan Gates added a comment - +1
        Hide
        hiveqa Hive QA added a comment -

        Overall: +1 all checks pass

        Here are the results of testing the latest attachment:
        https://issues.apache.org/jira/secure/attachment/12688215/HIVE-9155.3.patch

        SUCCESS: +1 6718 tests passed

        Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/2140/testReport
        Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/2140/console
        Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-2140/

        Messages:

        Executing org.apache.hive.ptest.execution.PrepPhase
        Executing org.apache.hive.ptest.execution.ExecutionPhase
        Executing org.apache.hive.ptest.execution.ReportingPhase
        

        This message is automatically generated.

        ATTACHMENT ID: 12688215 - PreCommit-HIVE-TRUNK-Build

        Show
        hiveqa Hive QA added a comment - Overall : +1 all checks pass Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12688215/HIVE-9155.3.patch SUCCESS: +1 6718 tests passed Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/2140/testReport Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/2140/console Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-2140/ Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase This message is automatically generated. ATTACHMENT ID: 12688215 - PreCommit-HIVE-TRUNK-Build
        Hide
        ekoifman Eugene Koifman added a comment -

        Committed to trunk. Thanks Alan Gates for the review.

        Show
        ekoifman Eugene Koifman added a comment - Committed to trunk. Thanks Alan Gates for the review.
        Hide
        ekoifman Eugene Koifman added a comment -

        Gunther Hagleitner, this seems serious. Could we get this into 0.14.1?

        Show
        ekoifman Eugene Koifman added a comment - Gunther Hagleitner , this seems serious. Could we get this into 0.14.1?
        Hide
        hagleitn Gunther Hagleitner added a comment -

        +1 for 0.14.1

        Show
        hagleitn Gunther Hagleitner added a comment - +1 for 0.14.1
        Hide
        ekoifman Eugene Koifman added a comment -

        committed to 0.14.1 as well

        Show
        ekoifman Eugene Koifman added a comment - committed to 0.14.1 as well
        Hide
        thejas Thejas M Nair added a comment -

        Updating release version for jiras resolved in 1.0.0 .

        Show
        thejas Thejas M Nair added a comment - Updating release version for jiras resolved in 1.0.0 .
        Hide
        thejas Thejas M Nair added a comment -

        This issue has been fixed in Apache Hive 1.0.0. If there is any issue with the fix, please open a new jira to address it.

        Show
        thejas Thejas M Nair added a comment - This issue has been fixed in Apache Hive 1.0.0. If there is any issue with the fix, please open a new jira to address it.

          People

          • Assignee:
            ekoifman Eugene Koifman
            Reporter:
            ekoifman Eugene Koifman
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development