Hive
  1. Hive
  2. HIVE-769

PartitionPruner checking is broken

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.4.0, 0.5.0
    • Component/s: Query Processor
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      We need a new way of checking whether each of the partitioned table has a Partition Pruner condition.

      1. HIVE-769.3-1.trunk.branch-0.4.patch
        2 kB
        Zheng Shao
      2. HIVE-769.3.trunk.patch
        12 kB
        Zheng Shao
      3. HIVE-769.3.branch-0.4.patch
        14 kB
        Zheng Shao
      4. HIVE-769.2.patch
        11 kB
        Zheng Shao
      5. HIVE-769.2.branch-0.4.patch
        13 kB
        Zheng Shao
      6. HIVE-769.1.patch
        9 kB
        Zheng Shao

        Activity

        Zheng Shao created issue -
        Hide
        Zheng Shao added a comment -

        @HIVE-769.1.patch: This should fix the problem.
        Tests are not updated yet.

        Show
        Zheng Shao added a comment - @ HIVE-769 .1.patch: This should fix the problem. Tests are not updated yet.
        Zheng Shao made changes -
        Field Original Value New Value
        Attachment HIVE-769.1.patch [ 12416958 ]
        Zheng Shao made changes -
        Attachment HIVE-769.1.patch [ 12416958 ]
        Zheng Shao made changes -
        Attachment HIVE-769.1.patch [ 12416959 ]
        Hide
        Zheng Shao added a comment -

        For the change in SemanticAnalyzer.initialize, I should have done it in the way as in HIVE-769.1.patch.

        However, HIVE-769.1.patch makes the "SELECT *" query a map-reduce job, so I have to do it as in the HIVE-769.2.patch.

        Show
        Zheng Shao added a comment - For the change in SemanticAnalyzer.initialize, I should have done it in the way as in HIVE-769 .1.patch. However, HIVE-769 .1.patch makes the "SELECT *" query a map-reduce job, so I have to do it as in the HIVE-769 .2.patch.
        Zheng Shao made changes -
        Attachment HIVE-769.2.patch [ 12416960 ]
        Hide
        Zheng Shao added a comment -

        The same patch for branch-0.4.

        Two minor differences: 1. exprNodeDesc.getChildren() return type change (it's already in trunk); 2. "import ...HiveConf;" conflict in ASTPartitionPruner.java.

        Show
        Zheng Shao added a comment - The same patch for branch-0.4. Two minor differences: 1. exprNodeDesc.getChildren() return type change (it's already in trunk); 2. "import ...HiveConf;" conflict in ASTPartitionPruner.java.
        Zheng Shao made changes -
        Attachment HIVE-769.2.branch-0.4.patch [ 12416962 ]
        Zheng Shao made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Zheng Shao added a comment -

        HIVE-769.3.trunk.patch: Included test case changes. Also changed a few places to make sure the error message looks nice.

        Show
        Zheng Shao added a comment - HIVE-769 .3.trunk.patch: Included test case changes. Also changed a few places to make sure the error message looks nice.
        Zheng Shao made changes -
        Attachment HIVE-769.3.trunk.patch [ 12416969 ]
        Hide
        Zheng Shao added a comment -

        HIVE-769.3.branch-0.4.patch: fix for branch-0.4.

        Show
        Zheng Shao added a comment - HIVE-769 .3.branch-0.4.patch: fix for branch-0.4.
        Zheng Shao made changes -
        Attachment HIVE-769.3.branch-0.4.patch [ 12416970 ]
        Zheng Shao made changes -
        Assignee Zheng Shao [ zshao ]
        Fix Version/s 0.4.0 [ 12313714 ]
        Hide
        Namit Jain added a comment -

        committed in trunk

        running tests for 0.4

        Show
        Namit Jain added a comment - committed in trunk running tests for 0.4
        Hide
        Namit Jain added a comment -

        Committed. Thanks Zheng

        Show
        Namit Jain added a comment - Committed. Thanks Zheng
        Namit Jain made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags [Reviewed]
        Resolution Fixed [ 1 ]
        Hide
        Zheng Shao added a comment -

        HIVE-769.3-1.trunk.branch-0.4.patch: Please commit to both branch-0.4 and trunk.

        Show
        Zheng Shao added a comment - HIVE-769 .3-1.trunk.branch-0.4.patch: Please commit to both branch-0.4 and trunk.
        Zheng Shao made changes -
        Attachment HIVE-769.3-1.trunk.branch-0.4.patch [ 12417057 ]
        Hide
        Zheng Shao added a comment -

        NullPointerException in some cases.

        Show
        Zheng Shao added a comment - NullPointerException in some cases.
        Zheng Shao made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Hide
        Namit Jain added a comment -

        Committed the new patch. Thanks Zheng

        Show
        Namit Jain added a comment - Committed the new patch. Thanks Zheng
        Namit Jain made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Carl Steinbach made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        3h 26m 1 Zheng Shao 19/Aug/09 05:03
        Patch Available Patch Available Resolved Resolved
        10h 23m 1 Namit Jain 19/Aug/09 15:27
        Resolved Resolved Reopened Reopened
        7h 9m 1 Zheng Shao 19/Aug/09 22:36
        Reopened Reopened Resolved Resolved
        4h 8m 1 Namit Jain 20/Aug/09 02:44
        Resolved Resolved Closed Closed
        848d 22h 21m 1 Carl Steinbach 17/Dec/11 00:06

          People

          • Assignee:
            Zheng Shao
            Reporter:
            Zheng Shao
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development