Hive
  1. Hive
  2. HIVE-7451

pass function name in create/drop function to authorization api

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.14.0
    • Component/s: Authorization
    • Labels:
      None

      Description

      If function names are passed to the authorization api for create/drop function calls, then authorization decisions can be made based on the function names as well.

      1. HIVE-7451.4.patch
        119 kB
        Thejas M Nair
      2. HIVE-7451.3.patch
        120 kB
        Thejas M Nair
      3. HIVE-7451.2.patch
        112 kB
        Thejas M Nair
      4. HIVE-7451.1.patch
        109 kB
        Thejas M Nair

        Issue Links

          Activity

          Hide
          Thejas M Nair added a comment -

          This has been fixed in 0.14 release. Please open new jira if you see any issues.

          Show
          Thejas M Nair added a comment - This has been fixed in 0.14 release. Please open new jira if you see any issues.
          Hide
          Thejas M Nair added a comment -

          Patch committed to trunk. Thanks for the review Jason!

          Show
          Thejas M Nair added a comment - Patch committed to trunk. Thanks for the review Jason!
          Hide
          Hive QA added a comment -

          Overall: -1 at least one tests failed

          Here are the results of testing the latest attachment:
          https://issues.apache.org/jira/secure/attachment/12657390/HIVE-7451.4.patch

          ERROR: -1 due to 2 failed/errored test(s), 5751 tests executed
          Failed tests:

          org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_ql_rewrite_gbtoidx
          org.apache.hadoop.hive.cli.TestNegativeMinimrCliDriver.testNegativeCliDriver_cluster_tasklog_retrieval
          

          Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/27/testReport
          Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/27/console
          Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-27/

          Messages:

          Executing org.apache.hive.ptest.execution.PrepPhase
          Executing org.apache.hive.ptest.execution.ExecutionPhase
          Executing org.apache.hive.ptest.execution.ReportingPhase
          Tests exited with: TestsFailedException: 2 tests failed
          

          This message is automatically generated.

          ATTACHMENT ID: 12657390

          Show
          Hive QA added a comment - Overall : -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12657390/HIVE-7451.4.patch ERROR: -1 due to 2 failed/errored test(s), 5751 tests executed Failed tests: org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_ql_rewrite_gbtoidx org.apache.hadoop.hive.cli.TestNegativeMinimrCliDriver.testNegativeCliDriver_cluster_tasklog_retrieval Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/27/testReport Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/27/console Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-27/ Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 2 tests failed This message is automatically generated. ATTACHMENT ID: 12657390
          Hide
          Jason Dere added a comment -

          +1 if tests pass

          Show
          Jason Dere added a comment - +1 if tests pass
          Hide
          Thejas M Nair added a comment -

          HIVE-7451.4.patch - updates test benchmarks

          Show
          Thejas M Nair added a comment - HIVE-7451 .4.patch - updates test benchmarks
          Hide
          Hive QA added a comment -

          Overall: -1 at least one tests failed

          Here are the results of testing the latest attachment:
          https://issues.apache.org/jira/secure/attachment/12657194/HIVE-7451.3.patch

          ERROR: -1 due to 46 failed/errored test(s), 5751 tests executed
          Failed tests:

          org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_authorization_admin_almighty2
          org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_authorization_create_func1
          org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_autogen_colalias
          org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_compile_processor
          org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_create_genericudaf
          org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_create_genericudf
          org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_create_udaf
          org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_create_view
          org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_drop_udf
          org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_ptf_register_tblfn
          org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_ptf_streaming
          org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_udaf_sum_list
          org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_udf_compare_java_string
          org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_udf_context_aware
          org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_udf_logic_java_boolean
          org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_udf_testlength
          org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_udf_testlength2
          org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_windowing_udaf2
          org.apache.hadoop.hive.cli.TestContribCliDriver.testCliDriver_dboutput
          org.apache.hadoop.hive.cli.TestContribCliDriver.testCliDriver_lateral_view_explode2
          org.apache.hadoop.hive.cli.TestContribCliDriver.testCliDriver_udaf_example_avg
          org.apache.hadoop.hive.cli.TestContribCliDriver.testCliDriver_udaf_example_group_concat
          org.apache.hadoop.hive.cli.TestContribCliDriver.testCliDriver_udaf_example_max
          org.apache.hadoop.hive.cli.TestContribCliDriver.testCliDriver_udaf_example_max_n
          org.apache.hadoop.hive.cli.TestContribCliDriver.testCliDriver_udaf_example_min
          org.apache.hadoop.hive.cli.TestContribCliDriver.testCliDriver_udaf_example_min_n
          org.apache.hadoop.hive.cli.TestContribCliDriver.testCliDriver_udf_example_add
          org.apache.hadoop.hive.cli.TestContribCliDriver.testCliDriver_udf_example_arraymapstruct
          org.apache.hadoop.hive.cli.TestContribCliDriver.testCliDriver_udf_example_format
          org.apache.hadoop.hive.cli.TestContribCliDriver.testCliDriver_udf_row_sequence
          org.apache.hadoop.hive.cli.TestContribCliDriver.testCliDriver_udtf_explode2
          org.apache.hadoop.hive.cli.TestContribCliDriver.testCliDriver_udtf_output_on_close
          org.apache.hadoop.hive.cli.TestContribNegativeCliDriver.testNegativeCliDriver_case_with_row_sequence
          org.apache.hadoop.hive.cli.TestContribNegativeCliDriver.testNegativeCliDriver_invalid_row_sequence
          org.apache.hadoop.hive.cli.TestContribNegativeCliDriver.testNegativeCliDriver_udtf_explode2
          org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_ql_rewrite_gbtoidx
          org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_create_udaf_failure
          org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_create_unknown_genericudf
          org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_create_unknown_udf_udaf
          org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_drop_native_udf
          org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_udf_function_does_not_implement_udf
          org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_udf_test_error
          org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_udf_test_error_reduce
          org.apache.hadoop.hive.cli.TestNegativeMinimrCliDriver.testNegativeCliDriver_cluster_tasklog_retrieval
          org.apache.hive.jdbc.TestJdbcDriver2.testParentReferences
          org.apache.hive.jdbc.miniHS2.TestHiveServer2.testConnection
          

          Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/10/testReport
          Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/10/console
          Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-10/

          Messages:

          Executing org.apache.hive.ptest.execution.PrepPhase
          Executing org.apache.hive.ptest.execution.ExecutionPhase
          Executing org.apache.hive.ptest.execution.ReportingPhase
          Tests exited with: TestsFailedException: 46 tests failed
          

          This message is automatically generated.

          ATTACHMENT ID: 12657194

          Show
          Hive QA added a comment - Overall : -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12657194/HIVE-7451.3.patch ERROR: -1 due to 46 failed/errored test(s), 5751 tests executed Failed tests: org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_authorization_admin_almighty2 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_authorization_create_func1 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_autogen_colalias org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_compile_processor org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_create_genericudaf org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_create_genericudf org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_create_udaf org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_create_view org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_drop_udf org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_ptf_register_tblfn org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_ptf_streaming org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_udaf_sum_list org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_udf_compare_java_string org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_udf_context_aware org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_udf_logic_java_boolean org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_udf_testlength org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_udf_testlength2 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_windowing_udaf2 org.apache.hadoop.hive.cli.TestContribCliDriver.testCliDriver_dboutput org.apache.hadoop.hive.cli.TestContribCliDriver.testCliDriver_lateral_view_explode2 org.apache.hadoop.hive.cli.TestContribCliDriver.testCliDriver_udaf_example_avg org.apache.hadoop.hive.cli.TestContribCliDriver.testCliDriver_udaf_example_group_concat org.apache.hadoop.hive.cli.TestContribCliDriver.testCliDriver_udaf_example_max org.apache.hadoop.hive.cli.TestContribCliDriver.testCliDriver_udaf_example_max_n org.apache.hadoop.hive.cli.TestContribCliDriver.testCliDriver_udaf_example_min org.apache.hadoop.hive.cli.TestContribCliDriver.testCliDriver_udaf_example_min_n org.apache.hadoop.hive.cli.TestContribCliDriver.testCliDriver_udf_example_add org.apache.hadoop.hive.cli.TestContribCliDriver.testCliDriver_udf_example_arraymapstruct org.apache.hadoop.hive.cli.TestContribCliDriver.testCliDriver_udf_example_format org.apache.hadoop.hive.cli.TestContribCliDriver.testCliDriver_udf_row_sequence org.apache.hadoop.hive.cli.TestContribCliDriver.testCliDriver_udtf_explode2 org.apache.hadoop.hive.cli.TestContribCliDriver.testCliDriver_udtf_output_on_close org.apache.hadoop.hive.cli.TestContribNegativeCliDriver.testNegativeCliDriver_case_with_row_sequence org.apache.hadoop.hive.cli.TestContribNegativeCliDriver.testNegativeCliDriver_invalid_row_sequence org.apache.hadoop.hive.cli.TestContribNegativeCliDriver.testNegativeCliDriver_udtf_explode2 org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_ql_rewrite_gbtoidx org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_create_udaf_failure org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_create_unknown_genericudf org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_create_unknown_udf_udaf org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_drop_native_udf org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_udf_function_does_not_implement_udf org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_udf_test_error org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_udf_test_error_reduce org.apache.hadoop.hive.cli.TestNegativeMinimrCliDriver.testNegativeCliDriver_cluster_tasklog_retrieval org.apache.hive.jdbc.TestJdbcDriver2.testParentReferences org.apache.hive.jdbc.miniHS2.TestHiveServer2.testConnection Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/10/testReport Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/10/console Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-10/ Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 46 tests failed This message is automatically generated. ATTACHMENT ID: 12657194
          Hide
          Thejas M Nair added a comment -

          HIVE-7451.3.patch - rebased on trunk and addressing review comments

          Show
          Thejas M Nair added a comment - HIVE-7451 .3.patch - rebased on trunk and addressing review comments
          Hide
          Hive QA added a comment -

          Overall: -1 at least one tests failed

          Here are the results of testing the latest attachment:
          https://issues.apache.org/jira/secure/attachment/12656898/HIVE-7451.2.patch

          ERROR: -1 due to 4 failed/errored test(s), 5749 tests executed
          Failed tests:

          org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver_tez_join_hash
          org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_ql_rewrite_gbtoidx
          org.apache.hadoop.hive.cli.TestNegativeMinimrCliDriver.testNegativeCliDriver_cluster_tasklog_retrieval
          org.apache.hive.jdbc.miniHS2.TestHiveServer2.testConnection
          

          Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-Build/879/testReport
          Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-Build/879/console
          Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-Build-879/

          Messages:

          Executing org.apache.hive.ptest.execution.PrepPhase
          Executing org.apache.hive.ptest.execution.ExecutionPhase
          Executing org.apache.hive.ptest.execution.ReportingPhase
          Tests exited with: TestsFailedException: 4 tests failed
          

          This message is automatically generated.

          ATTACHMENT ID: 12656898

          Show
          Hive QA added a comment - Overall : -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12656898/HIVE-7451.2.patch ERROR: -1 due to 4 failed/errored test(s), 5749 tests executed Failed tests: org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver_tez_join_hash org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_ql_rewrite_gbtoidx org.apache.hadoop.hive.cli.TestNegativeMinimrCliDriver.testNegativeCliDriver_cluster_tasklog_retrieval org.apache.hive.jdbc.miniHS2.TestHiveServer2.testConnection Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-Build/879/testReport Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-Build/879/console Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-Build-879/ Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 4 tests failed This message is automatically generated. ATTACHMENT ID: 12656898
          Hide
          Thejas M Nair added a comment -

          reviewboard link created with HIVE-7451.2.patch

          Show
          Thejas M Nair added a comment - reviewboard link created with HIVE-7451 .2.patch
          Hide
          Thejas M Nair added a comment -

          This patch also includes changes to print authorization errors on all objects, instead of printing the authorization error on one of the objects.

          Show
          Thejas M Nair added a comment - This patch also includes changes to print authorization errors on all objects, instead of printing the authorization error on one of the objects.
          Hide
          Thejas M Nair added a comment -

          HIVE-7451.2.patch - fixing test failures

          Show
          Thejas M Nair added a comment - HIVE-7451 .2.patch - fixing test failures
          Hide
          Hive QA added a comment -

          Overall: -1 at least one tests failed

          Here are the results of testing the latest attachment:
          https://issues.apache.org/jira/secure/attachment/12656674/HIVE-7451.1.patch

          ERROR: -1 due to 5 failed/errored test(s), 5731 tests executed
          Failed tests:

          org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_ql_rewrite_gbtoidx
          org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_udf_using
          org.apache.hadoop.hive.cli.TestNegativeMinimrCliDriver.testNegativeCliDriver_cluster_tasklog_retrieval
          org.apache.hadoop.hive.cli.TestNegativeMinimrCliDriver.testNegativeCliDriver_udf_local_resource
          org.apache.hive.jdbc.authorization.TestJdbcWithSQLAuthorization.testAllowedCommands
          

          Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-Build/859/testReport
          Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-Build/859/console
          Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-Build-859/

          Messages:

          Executing org.apache.hive.ptest.execution.PrepPhase
          Executing org.apache.hive.ptest.execution.ExecutionPhase
          Executing org.apache.hive.ptest.execution.ReportingPhase
          Tests exited with: TestsFailedException: 5 tests failed
          

          This message is automatically generated.

          ATTACHMENT ID: 12656674

          Show
          Hive QA added a comment - Overall : -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12656674/HIVE-7451.1.patch ERROR: -1 due to 5 failed/errored test(s), 5731 tests executed Failed tests: org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_ql_rewrite_gbtoidx org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_udf_using org.apache.hadoop.hive.cli.TestNegativeMinimrCliDriver.testNegativeCliDriver_cluster_tasklog_retrieval org.apache.hadoop.hive.cli.TestNegativeMinimrCliDriver.testNegativeCliDriver_udf_local_resource org.apache.hive.jdbc.authorization.TestJdbcWithSQLAuthorization.testAllowedCommands Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-Build/859/testReport Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-Build/859/console Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-Build-859/ Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 5 tests failed This message is automatically generated. ATTACHMENT ID: 12656674

            People

            • Assignee:
              Thejas M Nair
              Reporter:
              Thejas M Nair
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development