Uploaded image for project: 'Hive'
  1. Hive
  2. HIVE-697

GroupByOperator's initialization calls GenericUDAF.newAggregation before GenericUDAF.init

        Details

        • Type: Bug
        • Status: Closed
        • Priority: Minor
        • Resolution: Fixed
        • Affects Version/s: None
        • Fix Version/s: 0.4.0
        • Component/s: Query Processor
        • Labels:
          None
        • Hadoop Flags:
          Reviewed

          Description

          It should call GenericUDAF.init first, so GenericUDAF knows what to store in the AggregationBuffer.

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            zshao Zheng Shao added a comment -

            This patch moves the block of code up. It does not contain any additional tests but I think it's OK since it's such a simple change.

            Show
            zshao Zheng Shao added a comment - This patch moves the block of code up. It does not contain any additional tests but I think it's OK since it's such a simple change.
            Hide
            Permalink
            namit Namit Jain added a comment -

            +1

            looks good - will commit if the tests pass

            Show
            namit Namit Jain added a comment - +1 looks good - will commit if the tests pass
            Hide
            Permalink
            namit Namit Jain added a comment -

            Committed. Thanks Zheng

            Show
            namit Namit Jain added a comment - Committed. Thanks Zheng

              People

              • Assignee:
                zshao Zheng Shao
                Reporter:
                zshao Zheng Shao
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development