Hive
  1. Hive
  2. HIVE-697

GroupByOperator's initialization calls GenericUDAF.newAggregation before GenericUDAF.init

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.4.0
    • Component/s: Query Processor
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      It should call GenericUDAF.init first, so GenericUDAF knows what to store in the AggregationBuffer.

        Activity

        Hide
        Namit Jain added a comment -

        Committed. Thanks Zheng

        Show
        Namit Jain added a comment - Committed. Thanks Zheng
        Hide
        Namit Jain added a comment -

        +1

        looks good - will commit if the tests pass

        Show
        Namit Jain added a comment - +1 looks good - will commit if the tests pass
        Hide
        Zheng Shao added a comment -

        This patch moves the block of code up. It does not contain any additional tests but I think it's OK since it's such a simple change.

        Show
        Zheng Shao added a comment - This patch moves the block of code up. It does not contain any additional tests but I think it's OK since it's such a simple change.

          People

          • Assignee:
            Zheng Shao
            Reporter:
            Zheng Shao
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development