It should call GenericUDAF.init first, so GenericUDAF knows what to store in the AggregationBuffer.
Committed. Thanks Zheng
looks good - will commit if the tests pass
This patch moves the block of code up. It does not contain any additional tests but I think it's OK since it's such a simple change.