Hive
  1. Hive
  2. HIVE-6695

bin/hcat should include hbase jar and dependencies in the classpath [followup/clone of HCATALOG-621]

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.14.0
    • Component/s: None
    • Labels:
      None

      Description

      This is to address the addendum of HCATALOG-621, now that the HCatalog jira seems to be in read-only mode. To quote Nick from the original bug:

      I'm not sure how this fixes anything for the error listed above. The find command in the script we merged is broken, at least on linux. Maybe it worked with BSD find and we both tested on Macs?

      From the patch we committed:

      if [ -d ${HBASE_HOME} ] ; then
         for jar in $(find $HBASE_HOME -name *.jar -not -name thrift\*.jar); do
            HBASE_CLASSPATH=$HBASE_CLASSPATH:${jar}
         done
         export HADOOP_CLASSPATH="${HADOOP_CLASSPATH}:${HBASE_CLASSPATH}"
      fi
      

      The find command syntax is wrong – it returns no jars ever.

      $ find /usr/lib/hbase -name *.jar
      $ find /usr/lib/hbase -name *.jar -not -name thrift\*.jar
      $
      

      What we need is more like:

      $ find /usr/lib/hbase -name '*.jar'
      ... // prints lots of jars
      $ find /usr/lib/hbase -name '*.jar' | grep thrift
      /usr/lib/hbase/lib/libthrift-0.9.0.jar
      $ find /usr/lib/hbase -name '*.jar' -not -name '*thrift*' | grep thrift
      $
      
      1. HIVE-6695.patch
        1.0 kB
        Sushanth Sowmyan

        Issue Links

          Activity

          Hide
          Thejas M Nair added a comment -

          This has been fixed in 0.14 release. Please open new jira if you see any issues.

          Show
          Thejas M Nair added a comment - This has been fixed in 0.14 release. Please open new jira if you see any issues.
          Hide
          Nick Dimiduk added a comment -
          Show
          Nick Dimiduk added a comment - Thanks Sushanth Sowmyan !
          Hide
          Sushanth Sowmyan added a comment -

          Committed. Thanks, Nick!

          Show
          Sushanth Sowmyan added a comment - Committed. Thanks, Nick!
          Hide
          Sushanth Sowmyan added a comment -

          Nick Dimiduk, I created this hive jira since I was not able to respond on HCATALOG-621, since that seems like it's been locked down.

          +1 to the change, I'll go ahead and commit it.

          I've experimented with both versions of the find command, and both work for me (with and without quotes, and in fact, I'm more used to the backslash notation). I'm using findutils-4.4.2-6.el6.x86_64. The main difference though, was that our offending jar is libthrift*jar, not thrift*jar.

          Show
          Sushanth Sowmyan added a comment - Nick Dimiduk , I created this hive jira since I was not able to respond on HCATALOG-621 , since that seems like it's been locked down. +1 to the change, I'll go ahead and commit it. I've experimented with both versions of the find command, and both work for me (with and without quotes, and in fact, I'm more used to the backslash notation). I'm using findutils-4.4.2-6.el6.x86_64. The main difference though, was that our offending jar is libthrift*jar, not thrift*jar.
          Hide
          Sushanth Sowmyan added a comment -

          (Attaching addendum patch that was uploaded to HCATALOG-621)

          Show
          Sushanth Sowmyan added a comment - (Attaching addendum patch that was uploaded to HCATALOG-621 )

            People

            • Assignee:
              Nick Dimiduk
              Reporter:
              Sushanth Sowmyan
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development