Uploaded image for project: 'Hive'
  1. Hive
  2. HIVE-666

We should not ignore exceptions in FetchTask

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.4.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Propagate errors in FetchTask to client.

      Description

      FetchTask is ignoring some of the exceptions which makes it hard to debug the input file format code.
      We should propagate the exception back instead of ignoring it.

      1. HIVE-666.1.patch
        7 kB
        Zheng Shao
      2. HIVE-666.2.patch
        9 kB
        Zheng Shao
      3. HIVE-666.3.patch
        10 kB
        Zheng Shao

        Activity

        Hide
        zshao Zheng Shao added a comment -

        This patch propagates the exception.

        Show
        zshao Zheng Shao added a comment - This patch propagates the exception.
        Hide
        rsm Raghotham Murthy added a comment -

        Can you add a test case where the IOException is thrown only with this patch?

        Show
        rsm Raghotham Murthy added a comment - Can you add a test case where the IOException is thrown only with this patch?
        Hide
        zshao Zheng Shao added a comment -

        This one adds a test case (and also changed the code a bit to return the correct error code).

        Show
        zshao Zheng Shao added a comment - This one adds a test case (and also changed the code a bit to return the correct error code).
        Hide
        zshao Zheng Shao added a comment -

        Note: It's possible that our testing infrastructure is not supporting this new test case - we are leaving a temp table in the metastore which may cause "show tables '*';" to have different results.
        In that case, we can first commit all the changes except the new test case. We can add the test case back when the new test infrastructure is out.

        Show
        zshao Zheng Shao added a comment - Note: It's possible that our testing infrastructure is not supporting this new test case - we are leaving a temp table in the metastore which may cause "show tables '*';" to have different results. In that case, we can first commit all the changes except the new test case. We can add the test case back when the new test infrastructure is out.
        Hide
        zshao Zheng Shao added a comment -

        Modified QTestUtils.java to remove the temp table.
        Remove the line from the new .q file that drops the table. (It never gets executed because of the failure before it)

        Show
        zshao Zheng Shao added a comment - Modified QTestUtils.java to remove the temp table. Remove the line from the new .q file that drops the table. (It never gets executed because of the failure before it)
        Hide
        rsm Raghotham Murthy added a comment -

        looks good. will commit if tests pass.

        Show
        rsm Raghotham Murthy added a comment - looks good. will commit if tests pass.
        Hide
        rsm Raghotham Murthy added a comment -

        The patch was missing the input seq file. I pulled it from your source directory and checked it in.

        Show
        rsm Raghotham Murthy added a comment - The patch was missing the input seq file. I pulled it from your source directory and checked it in.
        Hide
        zshao Zheng Shao added a comment -

        Thanks Raghu!

        Show
        zshao Zheng Shao added a comment - Thanks Raghu!

          People

          • Assignee:
            zshao Zheng Shao
            Reporter:
            zshao Zheng Shao
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development