Uploaded image for project: 'Hive'
  1. Hive
  2. HIVE-4160 Vectorized Query Execution in Hive
  3. HIVE-6452

fix bug in UnsignedInt128.multiplyArrays4And4To8 and revert temporary fix in Decimal128.multiplyDestructive

        Details

        • Type: Sub-task
        • Status: Open
        • Priority: Major
        • Resolution: Unresolved
        • Affects Version/s: 0.13.0
        • Fix Version/s: None
        • Component/s: None
        • Labels:
          None

          Description

          UnsignedInt128.multiplyArrays4And4To8 has a bug that causes rare multiply failures, one of which appears in TestDecimal128.testKnownPriorErrors.

          Fix the bug by finishing the TODO section in UnsignedInt128.multiplyArrays4And4To8 in the provided multiplyArrays4And4To8-start.patch. Make it fast and make it work with no per-operation storage allocations.

          Retain the rest of the work (the new tests) in multiplyArrays4And4To8-start.patch as much as possible.

          Revert the changes to Decimal128.multiplyDestructive so it doesn't use the short-term, slow fix based on HiveDecimal. I.e. use the implementation in multiplyDestructiveNativeDecimal128.

            Activity

            There are no comments yet on this issue.

              People

              • Assignee:
                jnp Jitendra Nath Pandey
                Reporter:
                ehans Eric Hanson
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:

                  Development