Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.13.0
    • Component/s: Authorization
    • Labels:
      None

      Description

      SQL standard does not support view keyword in grant statement. HIVE-6181 which was added as part of sql standard changes, needs to be reverted.

      1. HIVE-6422.1.patch
        13 kB
        Thejas M Nair
      2. HIVE-6422.2.patch
        20 kB
        Thejas M Nair

        Activity

        Hide
        Ashutosh Chauhan added a comment -

        It will be good to retain the test case here.

        Show
        Ashutosh Chauhan added a comment - It will be good to retain the test case here.
        Hide
        Thejas M Nair added a comment -

        Good point about test coverage. I have enhanced the authorization_view_sqlstd.q test to add more coverage and also remove the view keyword used there. It now also tests the grant/revoke statements on views with and without the table keyword.

        Show
        Thejas M Nair added a comment - Good point about test coverage. I have enhanced the authorization_view_sqlstd.q test to add more coverage and also remove the view keyword used there. It now also tests the grant/revoke statements on views with and without the table keyword.
        Hide
        Ashutosh Chauhan added a comment -

        +1

        Show
        Ashutosh Chauhan added a comment - +1
        Hide
        Hive QA added a comment -

        Overall: -1 at least one tests failed

        Here are the results of testing the latest attachment:
        https://issues.apache.org/jira/secure/attachment/12629892/HIVE-6422.2.patch

        ERROR: -1 due to 2 failed/errored test(s), 5167 tests executed
        Failed tests:

        org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_bucket_num_reducers
        org.apache.hadoop.hive.cli.TestNegativeMinimrCliDriver.testNegativeCliDriver_mapreduce_stack_trace_hadoop20
        

        Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1424/testReport
        Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1424/console

        Messages:

        Executing org.apache.hive.ptest.execution.PrepPhase
        Executing org.apache.hive.ptest.execution.ExecutionPhase
        Executing org.apache.hive.ptest.execution.ReportingPhase
        Tests exited with: TestsFailedException: 2 tests failed
        

        This message is automatically generated.

        ATTACHMENT ID: 12629892

        Show
        Hive QA added a comment - Overall : -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12629892/HIVE-6422.2.patch ERROR: -1 due to 2 failed/errored test(s), 5167 tests executed Failed tests: org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_bucket_num_reducers org.apache.hadoop.hive.cli.TestNegativeMinimrCliDriver.testNegativeCliDriver_mapreduce_stack_trace_hadoop20 Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1424/testReport Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1424/console Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 2 tests failed This message is automatically generated. ATTACHMENT ID: 12629892
        Hide
        Thejas M Nair added a comment -

        Patch committed to trunk.
        Thanks for the review Ashutosh!

        Show
        Thejas M Nair added a comment - Patch committed to trunk. Thanks for the review Ashutosh!

          People

          • Assignee:
            Thejas M Nair
            Reporter:
            Thejas M Nair
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development