Hive
  1. Hive
  2. HIVE-6312

doAs with plain sasl auth should be session aware

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.13.0
    • Component/s: HiveServer2
    • Labels:
      None

      Description

      TUGIContainingProcessor creates new Subject for each invocation which induces FileSystem leakage when cache is enable(true by default).

      1. HIVE-6312.1.patch.txt
        10 kB
        Navis
      2. HIVE-6312.2.patch.txt
        18 kB
        Navis
      3. HIVE-6312.3.patch.txt
        17 kB
        Thejas M Nair
      4. HIVE-6312.4.patch.txt
        20 kB
        Thejas M Nair

        Issue Links

          Activity

          Hide
          Navis added a comment -

          Running preliminary test

          Show
          Navis added a comment - Running preliminary test
          Hide
          Hive QA added a comment -

          Overall: -1 at least one tests failed

          Here are the results of testing the latest attachment:
          https://issues.apache.org/jira/secure/attachment/12625302/HIVE-6312.1.patch.txt

          ERROR: -1 due to 12 failed/errored test(s), 4914 tests executed
          Failed tests:

          org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_import_exported_table
          org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_load_hdfs_file_with_space_in_the_name
          org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_parallel_orderby
          org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_root_dir_external_table
          org.apache.hadoop.hive.cli.TestNegativeMinimrCliDriver.testNegativeCliDriver_file_with_header_footer_negative
          org.apache.hive.beeline.TestBeeLineWithArgs.testEmbeddedBeelineConnection
          org.apache.hive.jdbc.TestJdbcDriver2.org.apache.hive.jdbc.TestJdbcDriver2
          org.apache.hive.service.auth.TestPlainSaslHelper.testDoAsSetting
          org.apache.hive.service.cli.thrift.TestThriftHttpCLIService.testExecuteStatement
          org.apache.hive.service.cli.thrift.TestThriftHttpCLIService.testExecuteStatementAsync
          org.apache.hive.service.cli.thrift.TestThriftHttpCLIService.testGetFunctions
          org.apache.hive.service.cli.thrift.TestThriftHttpCLIService.testOpenSession
          

          Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1037/testReport
          Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1037/console

          Messages:

          Executing org.apache.hive.ptest.execution.PrepPhase
          Executing org.apache.hive.ptest.execution.ExecutionPhase
          Executing org.apache.hive.ptest.execution.ReportingPhase
          Tests exited with: TestsFailedException: 12 tests failed
          

          This message is automatically generated.

          ATTACHMENT ID: 12625302

          Show
          Hive QA added a comment - Overall : -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12625302/HIVE-6312.1.patch.txt ERROR: -1 due to 12 failed/errored test(s), 4914 tests executed Failed tests: org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_import_exported_table org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_load_hdfs_file_with_space_in_the_name org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_parallel_orderby org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_root_dir_external_table org.apache.hadoop.hive.cli.TestNegativeMinimrCliDriver.testNegativeCliDriver_file_with_header_footer_negative org.apache.hive.beeline.TestBeeLineWithArgs.testEmbeddedBeelineConnection org.apache.hive.jdbc.TestJdbcDriver2.org.apache.hive.jdbc.TestJdbcDriver2 org.apache.hive.service.auth.TestPlainSaslHelper.testDoAsSetting org.apache.hive.service.cli.thrift.TestThriftHttpCLIService.testExecuteStatement org.apache.hive.service.cli.thrift.TestThriftHttpCLIService.testExecuteStatementAsync org.apache.hive.service.cli.thrift.TestThriftHttpCLIService.testGetFunctions org.apache.hive.service.cli.thrift.TestThriftHttpCLIService.testOpenSession Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1037/testReport Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1037/console Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 12 tests failed This message is automatically generated. ATTACHMENT ID: 12625302
          Hide
          Vaibhav Gumashta added a comment -

          Hi Navis. Thanks a lot for the patch! Can you also upload it to rb since it's easier to read there?

          Show
          Vaibhav Gumashta added a comment - Hi Navis . Thanks a lot for the patch! Can you also upload it to rb since it's easier to read there?
          Hide
          Navis added a comment -

          Vaibhav Gumashta Intended to make review board entry when all tests passed. Made one with on-going patch and thanks for your interest.

          Show
          Navis added a comment - Vaibhav Gumashta Intended to make review board entry when all tests passed. Made one with on-going patch and thanks for your interest.
          Hide
          Hive QA added a comment -

          Overall: +1 all checks pass

          Here are the results of testing the latest attachment:
          https://issues.apache.org/jira/secure/attachment/12625494/HIVE-6312.2.patch.txt

          SUCCESS: +1 4960 tests passed

          Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1068/testReport
          Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1068/console

          Messages:

          Executing org.apache.hive.ptest.execution.PrepPhase
          Executing org.apache.hive.ptest.execution.ExecutionPhase
          Executing org.apache.hive.ptest.execution.ReportingPhase
          

          This message is automatically generated.

          ATTACHMENT ID: 12625494

          Show
          Hive QA added a comment - Overall : +1 all checks pass Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12625494/HIVE-6312.2.patch.txt SUCCESS: +1 4960 tests passed Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1068/testReport Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1068/console Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase This message is automatically generated. ATTACHMENT ID: 12625494
          Hide
          Vaibhav Gumashta added a comment -

          Navis Left some minor comments on rb. How about we get rid of TUGIContainingProcessor class too since it won't be used anymore?

          Show
          Vaibhav Gumashta added a comment - Navis Left some minor comments on rb. How about we get rid of TUGIContainingProcessor class too since it won't be used anymore?
          Hide
          Thejas M Nair added a comment -

          The patch does not apply cleanly on trunk anymore. It would be great to have this in hive 0.13, since we are running out of time, I will go ahead and rebase it.

          Show
          Thejas M Nair added a comment - The patch does not apply cleanly on trunk anymore. It would be great to have this in hive 0.13, since we are running out of time, I will go ahead and rebase it.
          Hide
          Thejas M Nair added a comment -

          HIVE-6312.3.patch.txt - rebased patch, address my own minor comments .
          The changes in the original patch look good. Navis can you please review my rebase changes ?

          Show
          Thejas M Nair added a comment - HIVE-6312 .3.patch.txt - rebased patch, address my own minor comments . The changes in the original patch look good. Navis can you please review my rebase changes ?
          Hide
          Thejas M Nair added a comment -

          +1 to original changes. Will consider it a complete +1 once I get a review from Navis or another committer.
          I am unable to upload to the existing reviewboard .

          Show
          Thejas M Nair added a comment - +1 to original changes. Will consider it a complete +1 once I get a review from Navis or another committer. I am unable to upload to the existing reviewboard .
          Hide
          Thejas M Nair added a comment -

          I have kicked off a pre-commit test build.

          Show
          Thejas M Nair added a comment - I have kicked off a pre-commit test build.
          Hide
          Navis added a comment -

          Thejas M Nair Sorry for the delay. Look good to me. +1

          Show
          Navis added a comment - Thejas M Nair Sorry for the delay. Look good to me. +1
          Hide
          Vaibhav Gumashta added a comment -

          Thejas M Nair Should we also get rid of TUGIContainingProcessor?

          Show
          Vaibhav Gumashta added a comment - Thejas M Nair Should we also get rid of TUGIContainingProcessor?
          Hide
          Prasad Mujumdar added a comment -

          Thejas M Nair The TUGIContainingProcessor related changes are in fact already in trunk via HIVE-5155. You might want to rebase the patch to see if there are conflicts.

          Show
          Prasad Mujumdar added a comment - Thejas M Nair The TUGIContainingProcessor related changes are in fact already in trunk via HIVE-5155 . You might want to rebase the patch to see if there are conflicts.
          Hide
          Thejas M Nair added a comment -

          Prasad Mujumdar Yes, the patch from Navis didn't apply on post HIVE-5155 trunk, that is why I had to rebase it. HIVE-6312.3.patch.txt is the rebased patch I uploaded. It is not in the reviewboard link that Navis created, because I can't upload it there.

          Show
          Thejas M Nair added a comment - Prasad Mujumdar Yes, the patch from Navis didn't apply on post HIVE-5155 trunk, that is why I had to rebase it. HIVE-6312 .3.patch.txt is the rebased patch I uploaded. It is not in the reviewboard link that Navis created, because I can't upload it there.
          Hide
          Prasad Mujumdar added a comment -

          ah ok. I only looked at the review board and not the latest patch. sorry about that.
          Updated changes look fine to me.

          +1

          Show
          Prasad Mujumdar added a comment - ah ok. I only looked at the review board and not the latest patch. sorry about that. Updated changes look fine to me. +1
          Hide
          Thejas M Nair added a comment -

          Vaibhav Gumashta Yes, I think it makes sense to remove TUGIContainingProcessor. I will create a followup patch for it.

          Show
          Thejas M Nair added a comment - Vaibhav Gumashta Yes, I think it makes sense to remove TUGIContainingProcessor. I will create a followup patch for it.
          Hide
          Thejas M Nair added a comment -

          Thanks for pointing that out Vaibhav. Created HIVE-6663

          Show
          Thejas M Nair added a comment - Thanks for pointing that out Vaibhav. Created HIVE-6663
          Hide
          Navis added a comment -

          Thejas M Nair How about just removing it in here?

          Show
          Navis added a comment - Thejas M Nair How about just removing it in here?
          Hide
          Thejas M Nair added a comment -

          HIVE-6312.4.patch.txt - removes TUGIContainingProcessor

          Show
          Thejas M Nair added a comment - HIVE-6312 .4.patch.txt - removes TUGIContainingProcessor
          Hide
          Thejas M Nair added a comment -

          Navis, I included it in a different jira because I wasn't sure if I would get a +1 in time. Somehow thought that its late in night there (Seoul?) and you might not be around !

          Show
          Thejas M Nair added a comment - Navis, I included it in a different jira because I wasn't sure if I would get a +1 in time. Somehow thought that its late in night there (Seoul?) and you might not be around !
          Hide
          Navis added a comment -

          It's about the time to go home
          I've checked TUGIContainingProcessor is not included in any other class or document. Thanks again for a review.

          Show
          Navis added a comment - It's about the time to go home I've checked TUGIContainingProcessor is not included in any other class or document. Thanks again for a review.
          Hide
          Hive QA added a comment -

          Overall: +1 all checks pass

          Here are the results of testing the latest attachment:
          https://issues.apache.org/jira/secure/attachment/12634672/HIVE-6312.4.patch.txt

          SUCCESS: +1 5394 tests passed

          Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1773/testReport
          Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1773/console

          Messages:

          Executing org.apache.hive.ptest.execution.PrepPhase
          Executing org.apache.hive.ptest.execution.ExecutionPhase
          Executing org.apache.hive.ptest.execution.ReportingPhase
          

          This message is automatically generated.

          ATTACHMENT ID: 12634672

          Show
          Hive QA added a comment - Overall : +1 all checks pass Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12634672/HIVE-6312.4.patch.txt SUCCESS: +1 5394 tests passed Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1773/testReport Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1773/console Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase This message is automatically generated. ATTACHMENT ID: 12634672
          Hide
          Thejas M Nair added a comment -

          Patch committed to trunk and 0.13 branch (this is in the 0.13 jira list).
          Thanks Navis!

          Show
          Thejas M Nair added a comment - Patch committed to trunk and 0.13 branch (this is in the 0.13 jira list). Thanks Navis!

            People

            • Assignee:
              Navis
              Reporter:
              Navis
            • Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development