Hive
  1. Hive
  2. HIVE-4160 Vectorized Query Execution in Hive
  3. HIVE-6186

error in vectorized Column-Column comparison filter for repeating case

    Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.13.0
    • Fix Version/s: 0.13.0
    • Component/s: Query Processor
    • Labels:
      None

      Description

      FilterColumnCompareColumn.txt contains this code:

      } else if (inputColVector1.isRepeating && inputColVector2.isRepeating) {
      if (nullPos1[0] || nullPos2[0])

      { batch.size = 0; }

      This code examines nullPos1[0] and nullPos2[0] without checking that noNulls==false for the appropriate vector. This could lead to incorrect results.

      We should review the case analysis for this template more generally to make sure that all combinations are covered:

      left.noNulls right.noNulls
      T T
      F T
      T F
      F F

        Activity

        Eric Hanson made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Fix Version/s 0.13.0 [ 12324986 ]
        Resolution Fixed [ 1 ]
        Hide
        Eric Hanson added a comment -

        Committed to trunk

        Show
        Eric Hanson added a comment - Committed to trunk
        Hide
        Jitendra Nath Pandey added a comment -

        +1

        Show
        Jitendra Nath Pandey added a comment - +1
        Hide
        Hive QA added a comment -

        Overall: +1 all checks pass

        Here are the results of testing the latest attachment:
        https://issues.apache.org/jira/secure/attachment/12622482/HIVE-6186.01.patch

        SUCCESS: +1 4917 tests passed

        Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/861/testReport
        Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/861/console

        Messages:

        Executing org.apache.hive.ptest.execution.PrepPhase
        Executing org.apache.hive.ptest.execution.ExecutionPhase
        Executing org.apache.hive.ptest.execution.ReportingPhase
        

        This message is automatically generated.

        ATTACHMENT ID: 12622482

        Show
        Hive QA added a comment - Overall : +1 all checks pass Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12622482/HIVE-6186.01.patch SUCCESS: +1 4917 tests passed Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/861/testReport Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/861/console Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase This message is automatically generated. ATTACHMENT ID: 12622482
        Hide
        Eric Hanson added a comment -
        Show
        Eric Hanson added a comment - Code review at https://reviews.apache.org/r/16802/
        Eric Hanson made changes -
        Status In Progress [ 3 ] Patch Available [ 10002 ]
        Eric Hanson made changes -
        Attachment HIVE-6186.01.patch [ 12622482 ]
        Hide
        Eric Hanson added a comment -

        Updated by simplifying logic – null entries are filtered out immediately so the main logic knows there are no nulls.

        Show
        Eric Hanson added a comment - Updated by simplifying logic – null entries are filtered out immediately so the main logic knows there are no nulls.
        Eric Hanson made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Eric Hanson made changes -
        Field Original Value New Value
        Assignee Eric Hanson [ ehans ]
        Eric Hanson created issue -

          People

          • Assignee:
            Eric Hanson
            Reporter:
            Eric Hanson
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development