[HIVE-6186] error in vectorized Column-Column comparison filter for repeating case

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.13.0
• Fix Version/s: 0.13.0
• Component/s: Query Processor
• Assignee: Eric N. Hanson
• Reporter: Eric N. Hanson
• Created: 10/Jan/14 21:57
• Updated: 18/Jan/14 01:33
• Resolved: 18/Jan/14 01:33

Description

FilterColumnCompareColumn.txt contains this code:

} else if (inputColVector1.isRepeating && inputColVector2.isRepeating) {
if (nullPos1[0] || nullPos2[0])

{ batch.size = 0; }

This code examines nullPos1[0] and nullPos2[0] without checking that noNulls==false for the appropriate vector. This could lead to incorrect results.

We should review the case analysis for this template more generally to make sure that all combinations are covered:

left.noNulls right.noNulls
T T
F T
T F
F F