Hive
  1. Hive
  2. HIVE-4160 Vectorized Query Execution in Hive
  3. HIVE-6178

Implement vectorized reader for DECIMAL datatype for ORC format.

    Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.13.0
    • Component/s: None
    • Labels:
      None

      Description

      Implement vectorized reader for DECIMAL datatype for ORC format.

      1. HIVE-6178.1.patch
        12 kB
        Jitendra Nath Pandey
      2. HIVE-6178.2.patch
        13 kB
        Jitendra Nath Pandey
      3. HIVE-6178.3.patch
        14 kB
        Jitendra Nath Pandey
      4. HIVE-6178.4.patch
        14 kB
        Jitendra Nath Pandey
      5. HIVE-6178.5.patch
        14 kB
        Jitendra Nath Pandey

        Issue Links

          Activity

          Jitendra Nath Pandey created issue -
          Jitendra Nath Pandey made changes -
          Field Original Value New Value
          Attachment HIVE-6178.1.patch [ 12623551 ]
          Hide
          Jitendra Nath Pandey added a comment -
          Show
          Jitendra Nath Pandey added a comment - Review board entry: https://reviews.apache.org/r/17005/
          Jitendra Nath Pandey made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Eric Hanson added a comment -

          Please see my comments on Review Board

          Show
          Eric Hanson added a comment - Please see my comments on Review Board
          Hide
          Jitendra Nath Pandey added a comment -

          Uploaded a new patch addressing a few comments. I have also posted an explanation for handling variable scales.

          Show
          Jitendra Nath Pandey added a comment - Uploaded a new patch addressing a few comments. I have also posted an explanation for handling variable scales.
          Jitendra Nath Pandey made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Jitendra Nath Pandey made changes -
          Attachment HIVE-6178.2.patch [ 12625130 ]
          Jitendra Nath Pandey made changes -
          Attachment HIVE-6178.3.patch [ 12625473 ]
          Hide
          Jitendra Nath Pandey added a comment -

          Updated patch to fix the scale if the data has a different scale than the one in schema.

          Show
          Jitendra Nath Pandey added a comment - Updated patch to fix the scale if the data has a different scale than the one in schema.
          Jitendra Nath Pandey made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Hive QA added a comment -

          Overall: -1 at least one tests failed

          Here are the results of testing the latest attachment:
          https://issues.apache.org/jira/secure/attachment/12625473/HIVE-6178.3.patch

          ERROR: -1 due to 1 failed/errored test(s), 4961 tests executed
          Failed tests:

          org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_bucketizedhiveinputformat
          

          Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1061/testReport
          Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1061/console

          Messages:

          Executing org.apache.hive.ptest.execution.PrepPhase
          Executing org.apache.hive.ptest.execution.ExecutionPhase
          Executing org.apache.hive.ptest.execution.ReportingPhase
          Tests exited with: TestsFailedException: 1 tests failed
          

          This message is automatically generated.

          ATTACHMENT ID: 12625473

          Show
          Hive QA added a comment - Overall : -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12625473/HIVE-6178.3.patch ERROR: -1 due to 1 failed/errored test(s), 4961 tests executed Failed tests: org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_bucketizedhiveinputformat Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1061/testReport Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1061/console Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 1 tests failed This message is automatically generated. ATTACHMENT ID: 12625473
          Hide
          Eric Hanson added a comment -

          +1

          Show
          Eric Hanson added a comment - +1
          Hide
          Eric Hanson added a comment -

          Please see review board entry for stylistic comments.

          Show
          Eric Hanson added a comment - Please see review board entry for stylistic comments.
          Jitendra Nath Pandey made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Jitendra Nath Pandey made changes -
          Attachment HIVE-6178.4.patch [ 12625665 ]
          Hide
          Jitendra Nath Pandey added a comment -

          Uploaded another patch fixing the style issues. Updated review board as well.
          The failed test is not related to the patch and passes in my environment.

          Show
          Jitendra Nath Pandey added a comment - Uploaded another patch fixing the style issues. Updated review board as well. The failed test is not related to the patch and passes in my environment.
          Jitendra Nath Pandey made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Jitendra Nath Pandey made changes -
          Link This issue blocks HIVE-6303 [ HIVE-6303 ]
          Jitendra Nath Pandey made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Hide
          Jitendra Nath Pandey added a comment -

          Uploading/Submitting same patch again to trigger jenkins.

          Show
          Jitendra Nath Pandey added a comment - Uploading/Submitting same patch again to trigger jenkins.
          Jitendra Nath Pandey made changes -
          Attachment HIVE-6178.5.patch [ 12626182 ]
          Jitendra Nath Pandey made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Hive QA added a comment -

          Overall: +1 all checks pass

          Here are the results of testing the latest attachment:
          https://issues.apache.org/jira/secure/attachment/12626182/HIVE-6178.5.patch

          SUCCESS: +1 4981 tests passed

          Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1128/testReport
          Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1128/console

          Messages:

          Executing org.apache.hive.ptest.execution.PrepPhase
          Executing org.apache.hive.ptest.execution.ExecutionPhase
          Executing org.apache.hive.ptest.execution.ReportingPhase
          

          This message is automatically generated.

          ATTACHMENT ID: 12626182

          Show
          Hive QA added a comment - Overall : +1 all checks pass Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12626182/HIVE-6178.5.patch SUCCESS: +1 4981 tests passed Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1128/testReport Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1128/console Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase This message is automatically generated. ATTACHMENT ID: 12626182
          Hide
          Jitendra Nath Pandey added a comment -

          Committed to trunk.

          Show
          Jitendra Nath Pandey added a comment - Committed to trunk.
          Jitendra Nath Pandey made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Fix Version/s 0.13.0 [ 12324986 ]
          Resolution Fixed [ 1 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Patch Available Patch Available Open Open
          10d 18h 53m 3 Jitendra Nath Pandey 30/Jan/14 21:28
          Open Open Patch Available Patch Available
          10d 5h 32m 4 Jitendra Nath Pandey 30/Jan/14 21:29
          Patch Available Patch Available Resolved Resolved
          22h 4m 1 Jitendra Nath Pandey 31/Jan/14 19:34

            People

            • Assignee:
              Jitendra Nath Pandey
              Reporter:
              Jitendra Nath Pandey
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development