Hive
  1. Hive
  2. HIVE-4160 Vectorized Query Execution in Hive
  3. HIVE-6178

Implement vectorized reader for DECIMAL datatype for ORC format.

    Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.13.0
    • Component/s: None
    • Labels:
      None

      Description

      Implement vectorized reader for DECIMAL datatype for ORC format.

      1. HIVE-6178.5.patch
        14 kB
        Jitendra Nath Pandey
      2. HIVE-6178.4.patch
        14 kB
        Jitendra Nath Pandey
      3. HIVE-6178.3.patch
        14 kB
        Jitendra Nath Pandey
      4. HIVE-6178.2.patch
        13 kB
        Jitendra Nath Pandey
      5. HIVE-6178.1.patch
        12 kB
        Jitendra Nath Pandey

        Issue Links

          Activity

          Hide
          Jitendra Nath Pandey added a comment -

          Committed to trunk.

          Show
          Jitendra Nath Pandey added a comment - Committed to trunk.
          Hide
          Hive QA added a comment -

          Overall: +1 all checks pass

          Here are the results of testing the latest attachment:
          https://issues.apache.org/jira/secure/attachment/12626182/HIVE-6178.5.patch

          SUCCESS: +1 4981 tests passed

          Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1128/testReport
          Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1128/console

          Messages:

          Executing org.apache.hive.ptest.execution.PrepPhase
          Executing org.apache.hive.ptest.execution.ExecutionPhase
          Executing org.apache.hive.ptest.execution.ReportingPhase
          

          This message is automatically generated.

          ATTACHMENT ID: 12626182

          Show
          Hive QA added a comment - Overall : +1 all checks pass Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12626182/HIVE-6178.5.patch SUCCESS: +1 4981 tests passed Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1128/testReport Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1128/console Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase This message is automatically generated. ATTACHMENT ID: 12626182
          Hide
          Jitendra Nath Pandey added a comment -

          Uploading/Submitting same patch again to trigger jenkins.

          Show
          Jitendra Nath Pandey added a comment - Uploading/Submitting same patch again to trigger jenkins.
          Hide
          Jitendra Nath Pandey added a comment -

          Uploaded another patch fixing the style issues. Updated review board as well.
          The failed test is not related to the patch and passes in my environment.

          Show
          Jitendra Nath Pandey added a comment - Uploaded another patch fixing the style issues. Updated review board as well. The failed test is not related to the patch and passes in my environment.
          Hide
          Eric Hanson added a comment -

          Please see review board entry for stylistic comments.

          Show
          Eric Hanson added a comment - Please see review board entry for stylistic comments.
          Hide
          Eric Hanson added a comment -

          +1

          Show
          Eric Hanson added a comment - +1
          Hide
          Hive QA added a comment -

          Overall: -1 at least one tests failed

          Here are the results of testing the latest attachment:
          https://issues.apache.org/jira/secure/attachment/12625473/HIVE-6178.3.patch

          ERROR: -1 due to 1 failed/errored test(s), 4961 tests executed
          Failed tests:

          org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_bucketizedhiveinputformat
          

          Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1061/testReport
          Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1061/console

          Messages:

          Executing org.apache.hive.ptest.execution.PrepPhase
          Executing org.apache.hive.ptest.execution.ExecutionPhase
          Executing org.apache.hive.ptest.execution.ReportingPhase
          Tests exited with: TestsFailedException: 1 tests failed
          

          This message is automatically generated.

          ATTACHMENT ID: 12625473

          Show
          Hive QA added a comment - Overall : -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12625473/HIVE-6178.3.patch ERROR: -1 due to 1 failed/errored test(s), 4961 tests executed Failed tests: org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_bucketizedhiveinputformat Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1061/testReport Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1061/console Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 1 tests failed This message is automatically generated. ATTACHMENT ID: 12625473
          Hide
          Jitendra Nath Pandey added a comment -

          Updated patch to fix the scale if the data has a different scale than the one in schema.

          Show
          Jitendra Nath Pandey added a comment - Updated patch to fix the scale if the data has a different scale than the one in schema.
          Hide
          Jitendra Nath Pandey added a comment -

          Uploaded a new patch addressing a few comments. I have also posted an explanation for handling variable scales.

          Show
          Jitendra Nath Pandey added a comment - Uploaded a new patch addressing a few comments. I have also posted an explanation for handling variable scales.
          Hide
          Eric Hanson added a comment -

          Please see my comments on Review Board

          Show
          Eric Hanson added a comment - Please see my comments on Review Board
          Hide
          Jitendra Nath Pandey added a comment -
          Show
          Jitendra Nath Pandey added a comment - Review board entry: https://reviews.apache.org/r/17005/

            People

            • Assignee:
              Jitendra Nath Pandey
              Reporter:
              Jitendra Nath Pandey
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development