Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.13.0
    • Component/s: Authorization
    • Labels:
      None

      Description

      Includes INSERT, DELETE privileges.

      1. HIVE-6112.1.patch
        51 kB
        Thejas M Nair
      2. HIVE-6112.2.patch
        51 kB
        Thejas M Nair
      3. HIVE-6112.3.patch
        51 kB
        Thejas M Nair
      4. HIVE-6112.4.patch
        51 kB
        Thejas M Nair
      5. HIVE-6112.5.patch
        51 kB
        Thejas M Nair
      6. new-privs.patch
        2 kB
        Thejas M Nair

        Issue Links

          Activity

          Thejas M Nair created issue -
          Thejas M Nair made changes -
          Field Original Value New Value
          Component/s Authorization [ 12317300 ]
          Thejas M Nair made changes -
          Link This issue is blocked by HIVE-5928 [ HIVE-5928 ]
          Thejas M Nair made changes -
          Attachment new-privs.patch [ 12620568 ]
          Thejas M Nair made changes -
          Original Estimate 12h [ 43200 ]
          Remaining Estimate 12h [ 43200 ]
          Hide
          Brock Noland added a comment -

          Looks like this patch misses the getPrivTypeByName() and the toString() method on Privilege. FIWW this class looks like a perfect candidate for a unit test and I think we could get ride of all those if/else and case statements by storing this stuff in a map.

          Show
          Brock Noland added a comment - Looks like this patch misses the getPrivTypeByName() and the toString() method on Privilege. FIWW this class looks like a perfect candidate for a unit test and I think we could get ride of all those if/else and case statements by storing this stuff in a map.
          Thejas M Nair logged work - 28/Jan/14 02:15
          • Time Spent:
            1h
             
            <No comment>
          Thejas M Nair made changes -
          Assignee Thejas M Nair [ thejas ]
          Thejas M Nair made changes -
          Remaining Estimate 12h [ 43200 ] 8h [ 28800 ]
          Time Spent 1h [ 3600 ]
          Worklog Id 15741 [ 15741 ]
          Thejas M Nair made changes -
          Attachment HIVE-6112.1.patch [ 12625682 ]
          Thejas M Nair made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Thejas M Nair added a comment -

          HIVE-6112.2.patch - minor cleanup on HIVE-6112.1.patch.

          The patches also includes use of maps instead of if-else statement in privilege as suggested by Brock. The enum constructor sets the name and token type which gets added to map.

          Show
          Thejas M Nair added a comment - HIVE-6112 .2.patch - minor cleanup on HIVE-6112 .1.patch. The patches also includes use of maps instead of if-else statement in privilege as suggested by Brock. The enum constructor sets the name and token type which gets added to map.
          Thejas M Nair made changes -
          Attachment HIVE-6112.2.patch [ 12625689 ]
          Thejas M Nair made changes -
          Remote Link This issue links to "review board (Web Link)" [ 13902 ]
          Hide
          Ashutosh Chauhan added a comment -

          +1

          Show
          Ashutosh Chauhan added a comment - +1
          Hide
          Thejas M Nair added a comment -

          HIVE-6112.3.patch - updated .q.out file after rebasing with trunk

          Show
          Thejas M Nair added a comment - HIVE-6112 .3.patch - updated .q.out file after rebasing with trunk
          Thejas M Nair made changes -
          Attachment HIVE-6112.3.patch [ 12626081 ]
          Hide
          Hive QA added a comment -

          Overall: -1 at least one tests failed

          Here are the results of testing the latest attachment:
          https://issues.apache.org/jira/secure/attachment/12626081/HIVE-6112.3.patch

          ERROR: -1 due to 1 failed/errored test(s), 4985 tests executed
          Failed tests:

          org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_authorization_1_sql_std
          

          Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1120/testReport
          Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1120/console

          Messages:

          Executing org.apache.hive.ptest.execution.PrepPhase
          Executing org.apache.hive.ptest.execution.ExecutionPhase
          Executing org.apache.hive.ptest.execution.ReportingPhase
          Tests exited with: TestsFailedException: 1 tests failed
          

          This message is automatically generated.

          ATTACHMENT ID: 12626081

          Show
          Hive QA added a comment - Overall : -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12626081/HIVE-6112.3.patch ERROR: -1 due to 1 failed/errored test(s), 4985 tests executed Failed tests: org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_authorization_1_sql_std Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1120/testReport Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1120/console Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 1 tests failed This message is automatically generated. ATTACHMENT ID: 12626081
          Hide
          Thejas M Nair added a comment -

          HIVE-6112.4.patch - fixing the test failure

          Show
          Thejas M Nair added a comment - HIVE-6112 .4.patch - fixing the test failure
          Thejas M Nair made changes -
          Attachment HIVE-6112.4.patch [ 12626246 ]
          Thejas M Nair made changes -
          Attachment HIVE-6112.5.patch [ 12626256 ]
          Hide
          Ashutosh Chauhan added a comment -

          +1

          Show
          Ashutosh Chauhan added a comment - +1
          Hide
          Hive QA added a comment -

          Overall: +1 all checks pass

          Here are the results of testing the latest attachment:
          https://issues.apache.org/jira/secure/attachment/12626256/HIVE-6112.5.patch

          SUCCESS: +1 4986 tests passed

          Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1134/testReport
          Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1134/console

          Messages:

          Executing org.apache.hive.ptest.execution.PrepPhase
          Executing org.apache.hive.ptest.execution.ExecutionPhase
          Executing org.apache.hive.ptest.execution.ReportingPhase
          

          This message is automatically generated.

          ATTACHMENT ID: 12626256

          Show
          Hive QA added a comment - Overall : +1 all checks pass Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12626256/HIVE-6112.5.patch SUCCESS: +1 4986 tests passed Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1134/testReport Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1134/console Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase This message is automatically generated. ATTACHMENT ID: 12626256
          Hide
          Thejas M Nair added a comment -

          Patch committed to trunk.

          Show
          Thejas M Nair added a comment - Patch committed to trunk.
          Thejas M Nair made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Fix Version/s 0.13.0 [ 12324986 ]
          Resolution Fixed [ 1 ]
          Thejas M Nair logged work - 01/Feb/14 21:27
          • Time Spent:
            8h
             
            <No comment>
          Thejas M Nair made changes -
          Remaining Estimate 8h [ 28800 ] 0h [ 0 ]
          Time Spent 1h [ 3600 ] 9h [ 32400 ]
          Worklog Id 15836 [ 15836 ]

            People

            • Assignee:
              Thejas M Nair
              Reporter:
              Thejas M Nair
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 12h
                12h
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 9h Time Not Required
                9h

                  Development