Hive
  1. Hive
  2. HIVE-6082

Certain KeeperException should be ignored in ZooKeeperHiveLockManage.unlockPrimitive

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.12.0
    • Fix Version/s: 0.13.0
    • Component/s: None
    • Labels:
      None

      Description

      KeeperException.NoNodeException and NotEmptyException should be ignored when deleting a zLock or its parent in ZooKeeperHiveLockManager unlockPrimitive. The exceptions can happen:
      1) ZooKeeperHiveLockManager retries deleting a zLock after a failure but it has been deleted.
      2) a race condition where another process adds a zLock just before it is about to be deleted.
      Otherwise, unlock may unnecessarily be retried for numRetriesForUnLock times.

      1. Hive-6082.patch
        3 kB
        Chaoyu Tang
      2. HIVE-6082.patch
        3 kB
        Brock Noland

        Activity

        Hide
        Chaoyu Tang added a comment -

        Please review the attached fix.

        Show
        Chaoyu Tang added a comment - Please review the attached fix.
        Hide
        Brock Noland added a comment -

        Looks great! I am uploading the exact patch with an upper case name for testing.

        Show
        Brock Noland added a comment - Looks great! I am uploading the exact patch with an upper case name for testing.
        Hide
        Hive QA added a comment -

        Overall: +1 all checks pass

        Here are the results of testing the latest attachment:
        https://issues.apache.org/jira/secure/attachment/12619828/HIVE-6082.patch

        SUCCESS: +1 4799 tests passed

        Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/721/testReport
        Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/721/console

        Messages:

        Executing org.apache.hive.ptest.execution.PrepPhase
        Executing org.apache.hive.ptest.execution.ExecutionPhase
        Executing org.apache.hive.ptest.execution.ReportingPhase
        

        This message is automatically generated.

        ATTACHMENT ID: 12619828

        Show
        Hive QA added a comment - Overall : +1 all checks pass Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12619828/HIVE-6082.patch SUCCESS: +1 4799 tests passed Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/721/testReport Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/721/console Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase This message is automatically generated. ATTACHMENT ID: 12619828
        Hide
        Chaoyu Tang added a comment -

        Could some one commits this patch if it is a proper fix? Thanks.

        Show
        Chaoyu Tang added a comment - Could some one commits this patch if it is a proper fix? Thanks.
        Hide
        Brock Noland added a comment -

        +1

        Show
        Brock Noland added a comment - +1
        Hide
        Brock Noland added a comment -

        Committed to trunk! Thank you for your contribution!!

        Show
        Brock Noland added a comment - Committed to trunk! Thank you for your contribution!!

          People

          • Assignee:
            Chaoyu Tang
            Reporter:
            Chaoyu Tang
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development