Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.13.0
    • Component/s: Authorization
    • Labels:
      None
    • Hadoop Flags:
      Incompatible change
    • Release Note:
      Hide
      Granting privileges on a table now requires the grantor to have the same privileges 'with grant option'.

      Also, note that this patch adds a new method setSessionState to the authentication interface. Any users of the interface would need to add that method.
      Show
      Granting privileges on a table now requires the grantor to have the same privileges 'with grant option'. Also, note that this patch adds a new method setSessionState to the authentication interface. Any users of the interface would need to add that method.

      Description

      User (or a role user belongs to ) should have grant privileges to be able to grant/revoke privileges for a user/role.

      1. HIVE-5953.6.patch
        174 kB
        Thejas M Nair
      2. HIVE-5953.5.patch
        168 kB
        Thejas M Nair
      3. HIVE-5953.4.patch
        157 kB
        Thejas M Nair
      4. HIVE-5953.3.patch
        155 kB
        Thejas M Nair
      5. HIVE-5953.2.patch
        154 kB
        Thejas M Nair
      6. HIVE-5953.1.patch
        150 kB
        Thejas M Nair

        Issue Links

          Activity

          Thejas M Nair created issue -
          Thejas M Nair made changes -
          Field Original Value New Value
          Original Estimate 48h [ 172800 ]
          Remaining Estimate 48h [ 172800 ]
          Thejas M Nair made changes -
          Original Estimate 48h [ 172800 ] 120h [ 432000 ]
          Remaining Estimate 48h [ 172800 ] 120h [ 432000 ]
          Thejas M Nair made changes -
          Assignee Thejas M Nair [ thejas ]
          Thejas M Nair made changes -
          Attachment HIVE-5953.1.patch [ 12627550 ]
          Thejas M Nair made changes -
          Remote Link This issue links to "review board link (Web Link)" [ 14104 ]
          Hide
          Thejas M Nair added a comment -
          Show
          Thejas M Nair added a comment - review board link https://reviews.apache.org/r/17835/
          Thejas M Nair made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Thejas M Nair made changes -
          Summary SQL std auth - authorize grant/revoke on table/views SQL std auth - authorize grant/revoke on table
          Hide
          Thejas M Nair added a comment -

          Earlier patch was missing 2 files.

          Show
          Thejas M Nair added a comment - Earlier patch was missing 2 files.
          Thejas M Nair made changes -
          Attachment HIVE-5953.2.patch [ 12627577 ]
          Hide
          Thejas M Nair added a comment -

          HIVE-5953.3.patch - adds a package level documentation for the authorization interface (package-info.java ). Also minor change to Driver.java to remove a hack about URI handling.

          Show
          Thejas M Nair added a comment - HIVE-5953 .3.patch - adds a package level documentation for the authorization interface (package-info.java ). Also minor change to Driver.java to remove a hack about URI handling.
          Thejas M Nair made changes -
          Attachment HIVE-5953.3.patch [ 12627688 ]
          Hide
          Hive QA added a comment -

          Overall: -1 at least one tests failed

          Here are the results of testing the latest attachment:
          https://issues.apache.org/jira/secure/attachment/12627577/HIVE-5953.2.patch

          ERROR: -1 due to 5 failed/errored test(s), 5049 tests executed
          Failed tests:

          org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_authorization_grant_table_allpriv
          org.apache.hadoop.hive.ql.metadata.TestHive.testTable
          org.apache.hadoop.hive.ql.metadata.TestHive.testThriftTable
          org.apache.hadoop.hive.ql.metadata.TestHiveRemote.testTable
          org.apache.hadoop.hive.ql.metadata.TestHiveRemote.testThriftTable
          

          Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1239/testReport
          Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1239/console

          Messages:

          Executing org.apache.hive.ptest.execution.PrepPhase
          Executing org.apache.hive.ptest.execution.ExecutionPhase
          Executing org.apache.hive.ptest.execution.ReportingPhase
          Tests exited with: TestsFailedException: 5 tests failed
          

          This message is automatically generated.

          ATTACHMENT ID: 12627577

          Show
          Hive QA added a comment - Overall : -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12627577/HIVE-5953.2.patch ERROR: -1 due to 5 failed/errored test(s), 5049 tests executed Failed tests: org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_authorization_grant_table_allpriv org.apache.hadoop.hive.ql.metadata.TestHive.testTable org.apache.hadoop.hive.ql.metadata.TestHive.testThriftTable org.apache.hadoop.hive.ql.metadata.TestHiveRemote.testTable org.apache.hadoop.hive.ql.metadata.TestHiveRemote.testThriftTable Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1239/testReport Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1239/console Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 5 tests failed This message is automatically generated. ATTACHMENT ID: 12627577
          Hide
          Hive QA added a comment -

          Overall: -1 at least one tests failed

          Here are the results of testing the latest attachment:
          https://issues.apache.org/jira/secure/attachment/12627688/HIVE-5953.3.patch

          ERROR: -1 due to 6 failed/errored test(s), 5049 tests executed
          Failed tests:

          org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_authorization_revoke_table_priv
          org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_authorization_grant_table_allpriv
          org.apache.hadoop.hive.ql.metadata.TestHive.testTable
          org.apache.hadoop.hive.ql.metadata.TestHive.testThriftTable
          org.apache.hadoop.hive.ql.metadata.TestHiveRemote.testTable
          org.apache.hadoop.hive.ql.metadata.TestHiveRemote.testThriftTable
          

          Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1240/testReport
          Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1240/console

          Messages:

          Executing org.apache.hive.ptest.execution.PrepPhase
          Executing org.apache.hive.ptest.execution.ExecutionPhase
          Executing org.apache.hive.ptest.execution.ReportingPhase
          Tests exited with: TestsFailedException: 6 tests failed
          

          This message is automatically generated.

          ATTACHMENT ID: 12627688

          Show
          Hive QA added a comment - Overall : -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12627688/HIVE-5953.3.patch ERROR: -1 due to 6 failed/errored test(s), 5049 tests executed Failed tests: org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_authorization_revoke_table_priv org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_authorization_grant_table_allpriv org.apache.hadoop.hive.ql.metadata.TestHive.testTable org.apache.hadoop.hive.ql.metadata.TestHive.testThriftTable org.apache.hadoop.hive.ql.metadata.TestHiveRemote.testTable org.apache.hadoop.hive.ql.metadata.TestHiveRemote.testThriftTable Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1240/testReport Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1240/console Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 6 tests failed This message is automatically generated. ATTACHMENT ID: 12627688
          Hide
          Thejas M Nair added a comment -

          HIVE-5953.4.patch - addressing review comments from Brock, fixing unit tests.

          Show
          Thejas M Nair added a comment - HIVE-5953 .4.patch - addressing review comments from Brock, fixing unit tests.
          Thejas M Nair made changes -
          Attachment HIVE-5953.4.patch [ 12627752 ]
          Thejas M Nair made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Thejas M Nair made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Lefty Leverenz added a comment -

          Typos in patch 3, mostly trivial:

          • lines 769 & 824: "a authorization" should be "an authorization"
          • line 959: "the hive privilege" should be "Hive"
          • package-info.java (lines 1037-1067):
            • "hive" should be "Hive" on lines 1038, 1040, 1041, 1049, 1059
            • "and" could be added before last class name on line 1042
            • unnecessary comma on line 1045 (but it does no harm)
            • "The methods in the interface throws two ..." should be "throw"
            • "one is the actions performed by the access control statements, which updates ... (and stores ...), and also retrieves ..." on lines 1053-1055: if updates, stores, & retrieves go with "one" then this is okay, but if they go with "actions" or "statements" then drop the final "s" on the verbs
            • "the privileges ... (and stores in some where like metastore database)" on lines 1054-1055: "somewhere" & "stores them"?
            • "and juse a no-op" on line 1056: "use"
            • micronit: "eg," technically should be "e.g.," but nobody really cares
            • unnecessary initial spaces on lines 1058 & 1062
            • "HiveAuthorizationValidator has interface" on line 1062: "has the interface"
            • "HiveAuthorizerImpl is a convenience class that you can use by just passing the implementations of these two interfaces (HiveAuthorizerImpl, HiveAuthorizationValidator) in the constructor" on lines 1064-1065: should the 2nd HiveAuthorizerImpl be HiveAccessController?

          That's it for now; I'll go through the rest of the javadoc comments later. Sorry for not doing this in the review board. (Can't register – should I open an INFRA ticket or just ask for help on dev@hive?)

          Show
          Lefty Leverenz added a comment - Typos in patch 3, mostly trivial: lines 769 & 824: "a authorization" should be "an authorization" line 959: "the hive privilege" should be "Hive" package-info.java (lines 1037-1067): "hive" should be "Hive" on lines 1038, 1040, 1041, 1049, 1059 "and" could be added before last class name on line 1042 unnecessary comma on line 1045 (but it does no harm) "The methods in the interface throws two ..." should be "throw" "one is the actions performed by the access control statements, which updates ... (and stores ...), and also retrieves ..." on lines 1053-1055: if updates, stores, & retrieves go with "one" then this is okay, but if they go with "actions" or "statements" then drop the final "s" on the verbs "the privileges ... (and stores in some where like metastore database)" on lines 1054-1055: "somewhere" & "stores them"? "and juse a no-op" on line 1056: "use" micronit: "eg," technically should be "e.g.," but nobody really cares unnecessary initial spaces on lines 1058 & 1062 "HiveAuthorizationValidator has interface" on line 1062: "has the interface" "HiveAuthorizerImpl is a convenience class that you can use by just passing the implementations of these two interfaces (HiveAuthorizerImpl, HiveAuthorizationValidator) in the constructor" on lines 1064-1065: should the 2nd HiveAuthorizerImpl be HiveAccessController? That's it for now; I'll go through the rest of the javadoc comments later. Sorry for not doing this in the review board. (Can't register – should I open an INFRA ticket or just ask for help on dev@hive?)
          Hide
          Thejas M Nair added a comment -

          Lefty, you should be able to create the account on review board through https://reviews.apache.org/account/register/

          Show
          Thejas M Nair added a comment - Lefty, you should be able to create the account on review board through https://reviews.apache.org/account/register/
          Hide
          Thejas M Nair added a comment -

          HIVE-5953.5.patch- Addressing comments from Ashutosh, Lefty.

          Show
          Thejas M Nair added a comment - HIVE-5953 .5.patch- Addressing comments from Ashutosh, Lefty.
          Thejas M Nair made changes -
          Attachment HIVE-5953.5.patch [ 12627777 ]
          Hide
          Lefty Leverenz added a comment -

          Thanks Thejas M Nair, that's where I kept trying without success but I tried again, got a different error message, and ... (skipping the details) now I'm all set up. So I'll resume my typo hunt in patch 5 on the review board.

          Show
          Lefty Leverenz added a comment - Thanks Thejas M Nair , that's where I kept trying without success but I tried again, got a different error message, and ... (skipping the details) now I'm all set up. So I'll resume my typo hunt in patch 5 on the review board.
          Hide
          Hive QA added a comment -

          Overall: -1 no tests executed

          Here are the results of testing the latest attachment:
          https://issues.apache.org/jira/secure/attachment/12627777/HIVE-5953.5.patch

          Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1246/testReport
          Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1246/console

          Messages:

          **** This message was trimmed, see log for full details ****
          [INFO] Hive Integration - Testing Utilities
          [INFO] Hive Integration - Unit Tests
          [INFO] Hive Integration - Test Serde
          [INFO] Hive Integration - QFile Tests
          [INFO]                                                                         
          [INFO] ------------------------------------------------------------------------
          [INFO] Building Hive Integration - Parent 0.13.0-SNAPSHOT
          [INFO] ------------------------------------------------------------------------
          [INFO] 
          [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ hive-it ---
          [INFO] Deleting /data/hive-ptest/working/apache-svn-trunk-source/itests (includes = [datanucleus.log, derby.log], excludes = [])
          [INFO] 
          [INFO] --- maven-antrun-plugin:1.7:run (define-classpath) @ hive-it ---
          [INFO] Executing tasks
          
          main:
          [INFO] Executed tasks
          [INFO] 
          [INFO] --- maven-antrun-plugin:1.7:run (setup-test-dirs) @ hive-it ---
          [INFO] Executing tasks
          
          main:
              [mkdir] Created dir: /data/hive-ptest/working/apache-svn-trunk-source/itests/target/tmp
              [mkdir] Created dir: /data/hive-ptest/working/apache-svn-trunk-source/itests/target/warehouse
              [mkdir] Created dir: /data/hive-ptest/working/apache-svn-trunk-source/itests/target/tmp/conf
               [copy] Copying 5 files to /data/hive-ptest/working/apache-svn-trunk-source/itests/target/tmp/conf
          [INFO] Executed tasks
          [INFO] 
          [INFO] --- maven-install-plugin:2.4:install (default-install) @ hive-it ---
          [INFO] Installing /data/hive-ptest/working/apache-svn-trunk-source/itests/pom.xml to /data/hive-ptest/working/maven/org/apache/hive/hive-it/0.13.0-SNAPSHOT/hive-it-0.13.0-SNAPSHOT.pom
          [INFO]                                                                         
          [INFO] ------------------------------------------------------------------------
          [INFO] Building Hive Integration - Custom Serde 0.13.0-SNAPSHOT
          [INFO] ------------------------------------------------------------------------
          [INFO] 
          [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ hive-it-custom-serde ---
          [INFO] Deleting /data/hive-ptest/working/apache-svn-trunk-source/itests/custom-serde (includes = [datanucleus.log, derby.log], excludes = [])
          [INFO] 
          [INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ hive-it-custom-serde ---
          [debug] execute contextualize
          [INFO] Using 'UTF-8' encoding to copy filtered resources.
          [INFO] skip non existing resourceDirectory /data/hive-ptest/working/apache-svn-trunk-source/itests/custom-serde/src/main/resources
          [INFO] 
          [INFO] --- maven-antrun-plugin:1.7:run (define-classpath) @ hive-it-custom-serde ---
          [INFO] Executing tasks
          
          main:
          [INFO] Executed tasks
          [INFO] 
          [INFO] --- maven-compiler-plugin:3.1:compile (default-compile) @ hive-it-custom-serde ---
          [INFO] Compiling 8 source files to /data/hive-ptest/working/apache-svn-trunk-source/itests/custom-serde/target/classes
          [INFO] 
          [INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ hive-it-custom-serde ---
          [debug] execute contextualize
          [INFO] Using 'UTF-8' encoding to copy filtered resources.
          [INFO] skip non existing resourceDirectory /data/hive-ptest/working/apache-svn-trunk-source/itests/custom-serde/src/test/resources
          [INFO] 
          [INFO] --- maven-antrun-plugin:1.7:run (setup-test-dirs) @ hive-it-custom-serde ---
          [INFO] Executing tasks
          
          main:
              [mkdir] Created dir: /data/hive-ptest/working/apache-svn-trunk-source/itests/custom-serde/target/tmp
              [mkdir] Created dir: /data/hive-ptest/working/apache-svn-trunk-source/itests/custom-serde/target/warehouse
              [mkdir] Created dir: /data/hive-ptest/working/apache-svn-trunk-source/itests/custom-serde/target/tmp/conf
               [copy] Copying 5 files to /data/hive-ptest/working/apache-svn-trunk-source/itests/custom-serde/target/tmp/conf
          [INFO] Executed tasks
          [INFO] 
          [INFO] --- maven-compiler-plugin:3.1:testCompile (default-testCompile) @ hive-it-custom-serde ---
          [INFO] No sources to compile
          [INFO] 
          [INFO] --- maven-surefire-plugin:2.16:test (default-test) @ hive-it-custom-serde ---
          [INFO] Tests are skipped.
          [INFO] 
          [INFO] --- maven-jar-plugin:2.2:jar (default-jar) @ hive-it-custom-serde ---
          [INFO] Building jar: /data/hive-ptest/working/apache-svn-trunk-source/itests/custom-serde/target/hive-it-custom-serde-0.13.0-SNAPSHOT.jar
          [INFO] 
          [INFO] --- maven-install-plugin:2.4:install (default-install) @ hive-it-custom-serde ---
          [INFO] Installing /data/hive-ptest/working/apache-svn-trunk-source/itests/custom-serde/target/hive-it-custom-serde-0.13.0-SNAPSHOT.jar to /data/hive-ptest/working/maven/org/apache/hive/hive-it-custom-serde/0.13.0-SNAPSHOT/hive-it-custom-serde-0.13.0-SNAPSHOT.jar
          [INFO] Installing /data/hive-ptest/working/apache-svn-trunk-source/itests/custom-serde/pom.xml to /data/hive-ptest/working/maven/org/apache/hive/hive-it-custom-serde/0.13.0-SNAPSHOT/hive-it-custom-serde-0.13.0-SNAPSHOT.pom
          [INFO]                                                                         
          [INFO] ------------------------------------------------------------------------
          [INFO] Building Hive Integration - HCatalog Unit Tests 0.13.0-SNAPSHOT
          [INFO] ------------------------------------------------------------------------
          [INFO] 
          [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ hive-hcatalog-it-unit ---
          [INFO] Deleting /data/hive-ptest/working/apache-svn-trunk-source/itests/hcatalog-unit (includes = [datanucleus.log, derby.log], excludes = [])
          [INFO] 
          [INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ hive-hcatalog-it-unit ---
          [debug] execute contextualize
          [INFO] Using 'UTF-8' encoding to copy filtered resources.
          [INFO] skip non existing resourceDirectory /data/hive-ptest/working/apache-svn-trunk-source/itests/hcatalog-unit/src/main/resources
          [INFO] 
          [INFO] --- maven-antrun-plugin:1.7:run (define-classpath) @ hive-hcatalog-it-unit ---
          [INFO] Executing tasks
          
          main:
          [INFO] Executed tasks
          [INFO] 
          [INFO] --- maven-compiler-plugin:3.1:compile (default-compile) @ hive-hcatalog-it-unit ---
          [INFO] No sources to compile
          [INFO] 
          [INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ hive-hcatalog-it-unit ---
          [debug] execute contextualize
          [INFO] Using 'UTF-8' encoding to copy filtered resources.
          [INFO] skip non existing resourceDirectory /data/hive-ptest/working/apache-svn-trunk-source/itests/hcatalog-unit/src/test/resources
          [INFO] 
          [INFO] --- maven-antrun-plugin:1.7:run (setup-test-dirs) @ hive-hcatalog-it-unit ---
          [INFO] Executing tasks
          
          main:
              [mkdir] Created dir: /data/hive-ptest/working/apache-svn-trunk-source/itests/hcatalog-unit/target/tmp
              [mkdir] Created dir: /data/hive-ptest/working/apache-svn-trunk-source/itests/hcatalog-unit/target/warehouse
              [mkdir] Created dir: /data/hive-ptest/working/apache-svn-trunk-source/itests/hcatalog-unit/target/tmp/conf
               [copy] Copying 5 files to /data/hive-ptest/working/apache-svn-trunk-source/itests/hcatalog-unit/target/tmp/conf
          [INFO] Executed tasks
          [INFO] 
          [INFO] --- maven-compiler-plugin:3.1:testCompile (default-testCompile) @ hive-hcatalog-it-unit ---
          [INFO] Compiling 7 source files to /data/hive-ptest/working/apache-svn-trunk-source/itests/hcatalog-unit/target/test-classes
          [WARNING] Note: Some input files use or override a deprecated API.
          [WARNING] Note: Recompile with -Xlint:deprecation for details.
          [INFO] 
          [INFO] --- maven-surefire-plugin:2.16:test (default-test) @ hive-hcatalog-it-unit ---
          [INFO] Tests are skipped.
          [INFO] 
          [INFO] --- maven-jar-plugin:2.2:jar (default-jar) @ hive-hcatalog-it-unit ---
          [WARNING] JAR will be empty - no content was marked for inclusion!
          [INFO] Building jar: /data/hive-ptest/working/apache-svn-trunk-source/itests/hcatalog-unit/target/hive-hcatalog-it-unit-0.13.0-SNAPSHOT.jar
          [INFO] 
          [INFO] --- maven-jar-plugin:2.2:test-jar (default) @ hive-hcatalog-it-unit ---
          [INFO] Building jar: /data/hive-ptest/working/apache-svn-trunk-source/itests/hcatalog-unit/target/hive-hcatalog-it-unit-0.13.0-SNAPSHOT-tests.jar
          [INFO] 
          [INFO] --- maven-install-plugin:2.4:install (default-install) @ hive-hcatalog-it-unit ---
          [INFO] Installing /data/hive-ptest/working/apache-svn-trunk-source/itests/hcatalog-unit/target/hive-hcatalog-it-unit-0.13.0-SNAPSHOT.jar to /data/hive-ptest/working/maven/org/apache/hive/hive-hcatalog-it-unit/0.13.0-SNAPSHOT/hive-hcatalog-it-unit-0.13.0-SNAPSHOT.jar
          [INFO] Installing /data/hive-ptest/working/apache-svn-trunk-source/itests/hcatalog-unit/pom.xml to /data/hive-ptest/working/maven/org/apache/hive/hive-hcatalog-it-unit/0.13.0-SNAPSHOT/hive-hcatalog-it-unit-0.13.0-SNAPSHOT.pom
          [INFO] Installing /data/hive-ptest/working/apache-svn-trunk-source/itests/hcatalog-unit/target/hive-hcatalog-it-unit-0.13.0-SNAPSHOT-tests.jar to /data/hive-ptest/working/maven/org/apache/hive/hive-hcatalog-it-unit/0.13.0-SNAPSHOT/hive-hcatalog-it-unit-0.13.0-SNAPSHOT-tests.jar
          [INFO]                                                                         
          [INFO] ------------------------------------------------------------------------
          [INFO] Building Hive Integration - Testing Utilities 0.13.0-SNAPSHOT
          [INFO] ------------------------------------------------------------------------
          [INFO] 
          [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ hive-it-util ---
          [INFO] Deleting /data/hive-ptest/working/apache-svn-trunk-source/itests/util (includes = [datanucleus.log, derby.log], excludes = [])
          [INFO] 
          [INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ hive-it-util ---
          [debug] execute contextualize
          [INFO] Using 'UTF-8' encoding to copy filtered resources.
          [INFO] skip non existing resourceDirectory /data/hive-ptest/working/apache-svn-trunk-source/itests/util/src/main/resources
          [INFO] 
          [INFO] --- maven-antrun-plugin:1.7:run (define-classpath) @ hive-it-util ---
          [INFO] Executing tasks
          
          main:
          [INFO] Executed tasks
          [INFO] 
          [INFO] --- maven-compiler-plugin:3.1:compile (default-compile) @ hive-it-util ---
          [INFO] Compiling 41 source files to /data/hive-ptest/working/apache-svn-trunk-source/itests/util/target/classes
          [INFO] -------------------------------------------------------------
          [WARNING] COMPILATION WARNING : 
          [INFO] -------------------------------------------------------------
          [WARNING] Note: Some input files use or override a deprecated API.
          [WARNING] Note: Recompile with -Xlint:deprecation for details.
          [INFO] 2 warnings 
          [INFO] -------------------------------------------------------------
          [INFO] -------------------------------------------------------------
          [ERROR] COMPILATION ERROR : 
          [INFO] -------------------------------------------------------------
          [ERROR] /data/hive-ptest/working/apache-svn-trunk-source/itests/util/src/main/java/org/apache/hadoop/hive/ql/security/InjectableDummyAuthenticator.java:[32,8] org.apache.hadoop.hive.ql.security.InjectableDummyAuthenticator is not abstract and does not override abstract method setSessionState(org.apache.hadoop.hive.ql.session.SessionState) in org.apache.hadoop.hive.ql.security.HiveAuthenticationProvider
          [INFO] 1 error
          [INFO] -------------------------------------------------------------
          [INFO] ------------------------------------------------------------------------
          [INFO] Reactor Summary:
          [INFO] 
          [INFO] Hive Integration - Parent ......................... SUCCESS [3.731s]
          [INFO] Hive Integration - Custom Serde ................... SUCCESS [8.884s]
          [INFO] Hive Integration - HCatalog Unit Tests ............ SUCCESS [5.140s]
          [INFO] Hive Integration - Testing Utilities .............. FAILURE [4.155s]
          [INFO] Hive Integration - Unit Tests ..................... SKIPPED
          [INFO] Hive Integration - Test Serde ..................... SKIPPED
          [INFO] Hive Integration - QFile Tests .................... SKIPPED
          [INFO] ------------------------------------------------------------------------
          [INFO] BUILD FAILURE
          [INFO] ------------------------------------------------------------------------
          [INFO] Total time: 23.520s
          [INFO] Finished at: Sat Feb 08 06:34:58 EST 2014
          [INFO] Final Memory: 29M/85M
          [INFO] ------------------------------------------------------------------------
          [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project hive-it-util: Compilation failure
          [ERROR] /data/hive-ptest/working/apache-svn-trunk-source/itests/util/src/main/java/org/apache/hadoop/hive/ql/security/InjectableDummyAuthenticator.java:[32,8] org.apache.hadoop.hive.ql.security.InjectableDummyAuthenticator is not abstract and does not override abstract method setSessionState(org.apache.hadoop.hive.ql.session.SessionState) in org.apache.hadoop.hive.ql.security.HiveAuthenticationProvider
          [ERROR] -> [Help 1]
          [ERROR] 
          [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
          [ERROR] Re-run Maven using the -X switch to enable full debug logging.
          [ERROR] 
          [ERROR] For more information about the errors and possible solutions, please read the following articles:
          [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
          [ERROR] 
          [ERROR] After correcting the problems, you can resume the build with the command
          [ERROR]   mvn <goals> -rf :hive-it-util
          + exit 1
          '
          

          This message is automatically generated.

          ATTACHMENT ID: 12627777

          Show
          Hive QA added a comment - Overall : -1 no tests executed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12627777/HIVE-5953.5.patch Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1246/testReport Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1246/console Messages: **** This message was trimmed, see log for full details **** [INFO] Hive Integration - Testing Utilities [INFO] Hive Integration - Unit Tests [INFO] Hive Integration - Test Serde [INFO] Hive Integration - QFile Tests [INFO] [INFO] ------------------------------------------------------------------------ [INFO] Building Hive Integration - Parent 0.13.0-SNAPSHOT [INFO] ------------------------------------------------------------------------ [INFO] [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ hive-it --- [INFO] Deleting /data/hive-ptest/working/apache-svn-trunk-source/itests (includes = [datanucleus.log, derby.log], excludes = []) [INFO] [INFO] --- maven-antrun-plugin:1.7:run (define-classpath) @ hive-it --- [INFO] Executing tasks main: [INFO] Executed tasks [INFO] [INFO] --- maven-antrun-plugin:1.7:run (setup-test-dirs) @ hive-it --- [INFO] Executing tasks main: [mkdir] Created dir: /data/hive-ptest/working/apache-svn-trunk-source/itests/target/tmp [mkdir] Created dir: /data/hive-ptest/working/apache-svn-trunk-source/itests/target/warehouse [mkdir] Created dir: /data/hive-ptest/working/apache-svn-trunk-source/itests/target/tmp/conf [copy] Copying 5 files to /data/hive-ptest/working/apache-svn-trunk-source/itests/target/tmp/conf [INFO] Executed tasks [INFO] [INFO] --- maven-install-plugin:2.4:install (default-install) @ hive-it --- [INFO] Installing /data/hive-ptest/working/apache-svn-trunk-source/itests/pom.xml to /data/hive-ptest/working/maven/org/apache/hive/hive-it/0.13.0-SNAPSHOT/hive-it-0.13.0-SNAPSHOT.pom [INFO] [INFO] ------------------------------------------------------------------------ [INFO] Building Hive Integration - Custom Serde 0.13.0-SNAPSHOT [INFO] ------------------------------------------------------------------------ [INFO] [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ hive-it-custom-serde --- [INFO] Deleting /data/hive-ptest/working/apache-svn-trunk-source/itests/custom-serde (includes = [datanucleus.log, derby.log], excludes = []) [INFO] [INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ hive-it-custom-serde --- [debug] execute contextualize [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] skip non existing resourceDirectory /data/hive-ptest/working/apache-svn-trunk-source/itests/custom-serde/src/main/resources [INFO] [INFO] --- maven-antrun-plugin:1.7:run (define-classpath) @ hive-it-custom-serde --- [INFO] Executing tasks main: [INFO] Executed tasks [INFO] [INFO] --- maven-compiler-plugin:3.1:compile (default-compile) @ hive-it-custom-serde --- [INFO] Compiling 8 source files to /data/hive-ptest/working/apache-svn-trunk-source/itests/custom-serde/target/classes [INFO] [INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ hive-it-custom-serde --- [debug] execute contextualize [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] skip non existing resourceDirectory /data/hive-ptest/working/apache-svn-trunk-source/itests/custom-serde/src/test/resources [INFO] [INFO] --- maven-antrun-plugin:1.7:run (setup-test-dirs) @ hive-it-custom-serde --- [INFO] Executing tasks main: [mkdir] Created dir: /data/hive-ptest/working/apache-svn-trunk-source/itests/custom-serde/target/tmp [mkdir] Created dir: /data/hive-ptest/working/apache-svn-trunk-source/itests/custom-serde/target/warehouse [mkdir] Created dir: /data/hive-ptest/working/apache-svn-trunk-source/itests/custom-serde/target/tmp/conf [copy] Copying 5 files to /data/hive-ptest/working/apache-svn-trunk-source/itests/custom-serde/target/tmp/conf [INFO] Executed tasks [INFO] [INFO] --- maven-compiler-plugin:3.1:testCompile (default-testCompile) @ hive-it-custom-serde --- [INFO] No sources to compile [INFO] [INFO] --- maven-surefire-plugin:2.16:test (default-test) @ hive-it-custom-serde --- [INFO] Tests are skipped. [INFO] [INFO] --- maven-jar-plugin:2.2:jar (default-jar) @ hive-it-custom-serde --- [INFO] Building jar: /data/hive-ptest/working/apache-svn-trunk-source/itests/custom-serde/target/hive-it-custom-serde-0.13.0-SNAPSHOT.jar [INFO] [INFO] --- maven-install-plugin:2.4:install (default-install) @ hive-it-custom-serde --- [INFO] Installing /data/hive-ptest/working/apache-svn-trunk-source/itests/custom-serde/target/hive-it-custom-serde-0.13.0-SNAPSHOT.jar to /data/hive-ptest/working/maven/org/apache/hive/hive-it-custom-serde/0.13.0-SNAPSHOT/hive-it-custom-serde-0.13.0-SNAPSHOT.jar [INFO] Installing /data/hive-ptest/working/apache-svn-trunk-source/itests/custom-serde/pom.xml to /data/hive-ptest/working/maven/org/apache/hive/hive-it-custom-serde/0.13.0-SNAPSHOT/hive-it-custom-serde-0.13.0-SNAPSHOT.pom [INFO] [INFO] ------------------------------------------------------------------------ [INFO] Building Hive Integration - HCatalog Unit Tests 0.13.0-SNAPSHOT [INFO] ------------------------------------------------------------------------ [INFO] [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ hive-hcatalog-it-unit --- [INFO] Deleting /data/hive-ptest/working/apache-svn-trunk-source/itests/hcatalog-unit (includes = [datanucleus.log, derby.log], excludes = []) [INFO] [INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ hive-hcatalog-it-unit --- [debug] execute contextualize [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] skip non existing resourceDirectory /data/hive-ptest/working/apache-svn-trunk-source/itests/hcatalog-unit/src/main/resources [INFO] [INFO] --- maven-antrun-plugin:1.7:run (define-classpath) @ hive-hcatalog-it-unit --- [INFO] Executing tasks main: [INFO] Executed tasks [INFO] [INFO] --- maven-compiler-plugin:3.1:compile (default-compile) @ hive-hcatalog-it-unit --- [INFO] No sources to compile [INFO] [INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ hive-hcatalog-it-unit --- [debug] execute contextualize [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] skip non existing resourceDirectory /data/hive-ptest/working/apache-svn-trunk-source/itests/hcatalog-unit/src/test/resources [INFO] [INFO] --- maven-antrun-plugin:1.7:run (setup-test-dirs) @ hive-hcatalog-it-unit --- [INFO] Executing tasks main: [mkdir] Created dir: /data/hive-ptest/working/apache-svn-trunk-source/itests/hcatalog-unit/target/tmp [mkdir] Created dir: /data/hive-ptest/working/apache-svn-trunk-source/itests/hcatalog-unit/target/warehouse [mkdir] Created dir: /data/hive-ptest/working/apache-svn-trunk-source/itests/hcatalog-unit/target/tmp/conf [copy] Copying 5 files to /data/hive-ptest/working/apache-svn-trunk-source/itests/hcatalog-unit/target/tmp/conf [INFO] Executed tasks [INFO] [INFO] --- maven-compiler-plugin:3.1:testCompile (default-testCompile) @ hive-hcatalog-it-unit --- [INFO] Compiling 7 source files to /data/hive-ptest/working/apache-svn-trunk-source/itests/hcatalog-unit/target/test-classes [WARNING] Note: Some input files use or override a deprecated API. [WARNING] Note: Recompile with -Xlint:deprecation for details. [INFO] [INFO] --- maven-surefire-plugin:2.16:test (default-test) @ hive-hcatalog-it-unit --- [INFO] Tests are skipped. [INFO] [INFO] --- maven-jar-plugin:2.2:jar (default-jar) @ hive-hcatalog-it-unit --- [WARNING] JAR will be empty - no content was marked for inclusion! [INFO] Building jar: /data/hive-ptest/working/apache-svn-trunk-source/itests/hcatalog-unit/target/hive-hcatalog-it-unit-0.13.0-SNAPSHOT.jar [INFO] [INFO] --- maven-jar-plugin:2.2:test-jar (default) @ hive-hcatalog-it-unit --- [INFO] Building jar: /data/hive-ptest/working/apache-svn-trunk-source/itests/hcatalog-unit/target/hive-hcatalog-it-unit-0.13.0-SNAPSHOT-tests.jar [INFO] [INFO] --- maven-install-plugin:2.4:install (default-install) @ hive-hcatalog-it-unit --- [INFO] Installing /data/hive-ptest/working/apache-svn-trunk-source/itests/hcatalog-unit/target/hive-hcatalog-it-unit-0.13.0-SNAPSHOT.jar to /data/hive-ptest/working/maven/org/apache/hive/hive-hcatalog-it-unit/0.13.0-SNAPSHOT/hive-hcatalog-it-unit-0.13.0-SNAPSHOT.jar [INFO] Installing /data/hive-ptest/working/apache-svn-trunk-source/itests/hcatalog-unit/pom.xml to /data/hive-ptest/working/maven/org/apache/hive/hive-hcatalog-it-unit/0.13.0-SNAPSHOT/hive-hcatalog-it-unit-0.13.0-SNAPSHOT.pom [INFO] Installing /data/hive-ptest/working/apache-svn-trunk-source/itests/hcatalog-unit/target/hive-hcatalog-it-unit-0.13.0-SNAPSHOT-tests.jar to /data/hive-ptest/working/maven/org/apache/hive/hive-hcatalog-it-unit/0.13.0-SNAPSHOT/hive-hcatalog-it-unit-0.13.0-SNAPSHOT-tests.jar [INFO] [INFO] ------------------------------------------------------------------------ [INFO] Building Hive Integration - Testing Utilities 0.13.0-SNAPSHOT [INFO] ------------------------------------------------------------------------ [INFO] [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ hive-it-util --- [INFO] Deleting /data/hive-ptest/working/apache-svn-trunk-source/itests/util (includes = [datanucleus.log, derby.log], excludes = []) [INFO] [INFO] --- maven-resources-plugin:2.5:resources (default-resources) @ hive-it-util --- [debug] execute contextualize [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] skip non existing resourceDirectory /data/hive-ptest/working/apache-svn-trunk-source/itests/util/src/main/resources [INFO] [INFO] --- maven-antrun-plugin:1.7:run (define-classpath) @ hive-it-util --- [INFO] Executing tasks main: [INFO] Executed tasks [INFO] [INFO] --- maven-compiler-plugin:3.1:compile (default-compile) @ hive-it-util --- [INFO] Compiling 41 source files to /data/hive-ptest/working/apache-svn-trunk-source/itests/util/target/classes [INFO] ------------------------------------------------------------- [WARNING] COMPILATION WARNING : [INFO] ------------------------------------------------------------- [WARNING] Note: Some input files use or override a deprecated API. [WARNING] Note: Recompile with -Xlint:deprecation for details. [INFO] 2 warnings [INFO] ------------------------------------------------------------- [INFO] ------------------------------------------------------------- [ERROR] COMPILATION ERROR : [INFO] ------------------------------------------------------------- [ERROR] /data/hive-ptest/working/apache-svn-trunk-source/itests/util/src/main/java/org/apache/hadoop/hive/ql/security/InjectableDummyAuthenticator.java:[32,8] org.apache.hadoop.hive.ql.security.InjectableDummyAuthenticator is not abstract and does not override abstract method setSessionState(org.apache.hadoop.hive.ql.session.SessionState) in org.apache.hadoop.hive.ql.security.HiveAuthenticationProvider [INFO] 1 error [INFO] ------------------------------------------------------------- [INFO] ------------------------------------------------------------------------ [INFO] Reactor Summary: [INFO] [INFO] Hive Integration - Parent ......................... SUCCESS [3.731s] [INFO] Hive Integration - Custom Serde ................... SUCCESS [8.884s] [INFO] Hive Integration - HCatalog Unit Tests ............ SUCCESS [5.140s] [INFO] Hive Integration - Testing Utilities .............. FAILURE [4.155s] [INFO] Hive Integration - Unit Tests ..................... SKIPPED [INFO] Hive Integration - Test Serde ..................... SKIPPED [INFO] Hive Integration - QFile Tests .................... SKIPPED [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 23.520s [INFO] Finished at: Sat Feb 08 06:34:58 EST 2014 [INFO] Final Memory: 29M/85M [INFO] ------------------------------------------------------------------------ [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project hive-it-util: Compilation failure [ERROR] /data/hive-ptest/working/apache-svn-trunk-source/itests/util/src/main/java/org/apache/hadoop/hive/ql/security/InjectableDummyAuthenticator.java:[32,8] org.apache.hadoop.hive.ql.security.InjectableDummyAuthenticator is not abstract and does not override abstract method setSessionState(org.apache.hadoop.hive.ql.session.SessionState) in org.apache.hadoop.hive.ql.security.HiveAuthenticationProvider [ERROR] -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException [ERROR] [ERROR] After correcting the problems, you can resume the build with the command [ERROR] mvn <goals> -rf :hive-it-util + exit 1 ' This message is automatically generated. ATTACHMENT ID: 12627777
          Hide
          Ashutosh Chauhan added a comment -

          +1 pending tests pass.
          Also, there are few files which are no longer required. I commented on RB. Though, it could be that RB diff was showing them, although they aren't in patch file. Didn't cross-check. Anyhow, just make sure not to commit any unwanted file.

          Show
          Ashutosh Chauhan added a comment - +1 pending tests pass. Also, there are few files which are no longer required. I commented on RB. Though, it could be that RB diff was showing them, although they aren't in patch file. Didn't cross-check. Anyhow, just make sure not to commit any unwanted file.
          Thejas M Nair made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Thejas M Nair made changes -
          Attachment HIVE-5953.6.patch [ 12627832 ]
          Hide
          Thejas M Nair added a comment -

          HIVE-5953.6.patch - rebased to trunk.

          Show
          Thejas M Nair added a comment - HIVE-5953 .6.patch - rebased to trunk.
          Thejas M Nair made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Thejas M Nair added a comment -

          Ashutosh, yes, it is just RB diff that still shows the files deleted in updated patch.

          Show
          Thejas M Nair added a comment - Ashutosh, yes, it is just RB diff that still shows the files deleted in updated patch.
          Hide
          Hive QA added a comment -

          Overall: -1 at least one tests failed

          Here are the results of testing the latest attachment:
          https://issues.apache.org/jira/secure/attachment/12627832/HIVE-5953.6.patch

          ERROR: -1 due to 2 failed/errored test(s), 5050 tests executed
          Failed tests:

          org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_bucketizedhiveinputformat
          org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_external_table_with_space_in_location_path
          

          Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1259/testReport
          Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1259/console

          Messages:

          Executing org.apache.hive.ptest.execution.PrepPhase
          Executing org.apache.hive.ptest.execution.ExecutionPhase
          Executing org.apache.hive.ptest.execution.ReportingPhase
          Tests exited with: TestsFailedException: 2 tests failed
          

          This message is automatically generated.

          ATTACHMENT ID: 12627832

          Show
          Hive QA added a comment - Overall : -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12627832/HIVE-5953.6.patch ERROR: -1 due to 2 failed/errored test(s), 5050 tests executed Failed tests: org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_bucketizedhiveinputformat org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_external_table_with_space_in_location_path Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1259/testReport Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1259/console Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 2 tests failed This message is automatically generated. ATTACHMENT ID: 12627832
          Hide
          Thejas M Nair added a comment -

          Patch committed to trunk.
          Thanks for the review Brock and Ashutosh.

          Note that in response to review comment, I added a method to HiveAuthenticationProvider interface in a new revision, instead of introducing another interface class (to keep things simpler). There not likely to be many users of this interface, it is likely to be only used in installations that are highly customized. But any users would need to implement that method.
          I am marking it as an incompatible change for that reason.

          Show
          Thejas M Nair added a comment - Patch committed to trunk. Thanks for the review Brock and Ashutosh. Note that in response to review comment, I added a method to HiveAuthenticationProvider interface in a new revision, instead of introducing another interface class (to keep things simpler). There not likely to be many users of this interface, it is likely to be only used in installations that are highly customized. But any users would need to implement that method. I am marking it as an incompatible change for that reason.
          Thejas M Nair made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Hadoop Flags Incompatible change [ 10342 ]
          Release Note Granting privileges on a table now requires the grantor to have the same privileges 'with grant option'.

          Also, note that this patch adds a new method setSessionState to the authentication interface. Any users of the interface would need to add that method.
          Fix Version/s 0.13.0 [ 12324986 ]
          Resolution Fixed [ 1 ]
          Thejas M Nair logged work - 10/Feb/14 06:45
          • Time Spent:
            144h
             
            <No comment>
          Thejas M Nair made changes -
          Remaining Estimate 120h [ 432000 ] 0h [ 0 ]
          Time Spent 144h [ 518400 ]
          Worklog Id 15934 [ 15934 ]

            People

            • Assignee:
              Thejas M Nair
              Reporter:
              Thejas M Nair
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 120h Original Estimate - 120h
                120h
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 144h
                144h

                  Development