[HIVE-5643] ZooKeeperHiveLockManager.getQuorumServers incorrectly appends the custom zk port to quorum hosts

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.12.0
• Fix Version/s: 0.13.0
• Component/s: Locking
• Assignee: Venki Korukanti
• Reporter: Venki Korukanti
• Created: 24/Oct/13 21:18
• Updated: 14/Nov/13 01:16
• Resolved: 14/Nov/13 01:16

Description

ZooKeeperHiveLockManager calls the below method to construct the connection string for ZooKeeper connection.

  private static String getQuorumServers(HiveConf conf) {
    String hosts = conf.getVar(HiveConf.ConfVars.HIVE_ZOOKEEPER_QUORUM);
    String port = conf.getVar(HiveConf.ConfVars.HIVE_ZOOKEEPER_CLIENT_PORT);
    return hosts + ":" + port;
  }

For example:
HIVE_ZOOKEEPER_QUORUM=node1, node2, node3
HIVE_ZOOKEEPER_CLIENT_PORT=9999

Connection string given to ZooKeeper object is "node1, node2, node3:9999". ZooKeeper consider the default port as 2181 for hostnames that don't have any port.

This works fine as long as HIVE_ZOOKEEPER_CLIENT_PORT is 2181. If it is different then ZooKeeper client object tries to connect to node1 and node2 on port 2181 which always fails. So it has only one choice the last host which receives all the load from Hive.