Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.13.0
    • Component/s: None
    • Labels:
      None

      Description

      NO PRECOMMIT TESTS

      1. HIVE-5332.1.patch
        136 kB
        Brock Noland
      2. HIVE-5332.2.patch
        138 kB
        Brock Noland
      3. HIVE-5332-wip.patch
        184 kB
        Brock Noland

        Activity

        Brock Noland created issue -
        Brock Noland made changes -
        Field Original Value New Value
        Attachment HIVE-5332-wip.patch [ 12604309 ]
        Hide
        Brock Noland added a comment -

        I have an updated patch I will post soon.

        Show
        Brock Noland added a comment - I have an updated patch I will post soon.
        Brock Noland made changes -
        Attachment HIVE-5332.1.patch [ 12604311 ]
        Brock Noland made changes -
        Attachment HIVE-5332.2.patch [ 12604889 ]
        Brock Noland made changes -
        Description NO PRECOMMIT TESTS
        Hide
        Brock Noland added a comment -

        Edward Capriolo could I ask you to review "HIVE-5332.2.patch"? I think it's ready for commit to maven branch since it successfully compiles and builds the source code under maven and generates a hive-exec with the same deps as the ant build.

        Show
        Brock Noland added a comment - Edward Capriolo could I ask you to review " HIVE-5332 .2.patch"? I think it's ready for commit to maven branch since it successfully compiles and builds the source code under maven and generates a hive-exec with the same deps as the ant build.
        Hide
        Edward Capriolo added a comment -

        +1
        I reviewed. Looks good. Feel free to commit to branch. I am not at a computer with my SVN credentials.

        Show
        Edward Capriolo added a comment - +1 I reviewed. Looks good. Feel free to commit to branch. I am not at a computer with my SVN credentials.
        Hide
        Brock Noland added a comment -

        Thank you very much for the review!!

        Show
        Brock Noland added a comment - Thank you very much for the review!!
        Brock Noland made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Ashutosh Chauhan made changes -
        Fix Version/s 0.13.0 [ 12324986 ]

          People

          • Assignee:
            Brock Noland
            Reporter:
            Brock Noland
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development