Description
Something to the effect of compile 'my code here' using 'groovycompiler'.
Attachments
Attachments
- HIVE-5252.1.patch.txt
- 5 kB
- Edward Capriolo
- HIVE-5252.2.patch.txt
- 7 kB
- Edward Capriolo
Activity
LGTM but I don't understand the new ant dep in ql? What are thoughts on a negative test when the code has a syntax error?
Groovyc (groovy compiler) requires ant. Ant is on our classpath for development but we need to add it as a ql. dep because otherwise it does not get added to hive/lib in the package.
Overall: +1 all checks pass
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12607734/HIVE-5252.2.patch.txt
SUCCESS: +1 4390 tests passed
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/1091/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/1091/console
Messages:
Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase
This message is automatically generated.
Thank you very much for your contribution Edward! I have committed this to trunk.
FAILURE: Integrated in Hive-trunk-h0.21 #2395 (See https://builds.apache.org/job/Hive-trunk-h0.21/2395/)
HIVE-5252 - Add ql syntax for inline java code creation (Edward Capriolo via Brock Noland) (brock: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1531549)
- /hive/trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
- /hive/trunk/ivy/libraries.properties
- /hive/trunk/ql/ivy.xml
- /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/processors/CommandProcessorFactory.java
- /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/processors/CompileProcessor.java
- /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/processors/HiveCommand.java
- /hive/trunk/ql/src/test/queries/clientnegative/compile_processor.q
- /hive/trunk/ql/src/test/queries/clientpositive/compile_processor.q
- /hive/trunk/ql/src/test/results/clientnegative/compile_processor.q.out
- /hive/trunk/ql/src/test/results/clientpositive/compile_processor.q.out
FAILURE: Integrated in Hive-trunk-hadoop2-ptest #137 (See https://builds.apache.org/job/Hive-trunk-hadoop2-ptest/137/)
HIVE-5252 - Add ql syntax for inline java code creation (Edward Capriolo via Brock Noland) (brock: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1531549)
- /hive/trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
- /hive/trunk/ivy/libraries.properties
- /hive/trunk/ql/ivy.xml
- /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/processors/CommandProcessorFactory.java
- /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/processors/CompileProcessor.java
- /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/processors/HiveCommand.java
- /hive/trunk/ql/src/test/queries/clientnegative/compile_processor.q
- /hive/trunk/ql/src/test/queries/clientpositive/compile_processor.q
- /hive/trunk/ql/src/test/results/clientnegative/compile_processor.q.out
- /hive/trunk/ql/src/test/results/clientpositive/compile_processor.q.out
FAILURE: Integrated in Hive-trunk-hadoop1-ptest #202 (See https://builds.apache.org/job/Hive-trunk-hadoop1-ptest/202/)
HIVE-5252 - Add ql syntax for inline java code creation (Edward Capriolo via Brock Noland) (brock: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1531549)
- /hive/trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
- /hive/trunk/ivy/libraries.properties
- /hive/trunk/ql/ivy.xml
- /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/processors/CommandProcessorFactory.java
- /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/processors/CompileProcessor.java
- /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/processors/HiveCommand.java
- /hive/trunk/ql/src/test/queries/clientnegative/compile_processor.q
- /hive/trunk/ql/src/test/queries/clientpositive/compile_processor.q
- /hive/trunk/ql/src/test/results/clientnegative/compile_processor.q.out
- /hive/trunk/ql/src/test/results/clientpositive/compile_processor.q.out
FAILURE: Integrated in Hive-trunk-hadoop2 #498 (See https://builds.apache.org/job/Hive-trunk-hadoop2/498/)
HIVE-5252 - Add ql syntax for inline java code creation (Edward Capriolo via Brock Noland) (brock: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1531549)
- /hive/trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
- /hive/trunk/ivy/libraries.properties
- /hive/trunk/ql/ivy.xml
- /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/processors/CommandProcessorFactory.java
- /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/processors/CompileProcessor.java
- /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/processors/HiveCommand.java
- /hive/trunk/ql/src/test/queries/clientnegative/compile_processor.q
- /hive/trunk/ql/src/test/queries/clientpositive/compile_processor.q
- /hive/trunk/ql/src/test/results/clientnegative/compile_processor.q.out
- /hive/trunk/ql/src/test/results/clientpositive/compile_processor.q.out
I added "compile" to the list of values for hive.security.command.whitelist in the wiki, but it needs to be added to hive-default.xml.template too.
Also, the wiki needs to explain inline Java code creation with a few examples. (I'd need more to go on than compile_processor.q in the patch.) Does it belong in the SELECT wikidoc or a new wikidoc, or with the UDFs? How about a new wikidoc under the CLI doc?
Or should documentation wait until the parent jira HIVE-5250 gets committed?
"compile" is now included in the default list of values for hive.security.command.whitelist in hive-default.xml.template (trunk, but not 0.13.1).
Documentation for inline Java code creation is still needed. See questions in previous comment.
Overall: +1 all checks pass
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12607505/HIVE-5252.1.patch.txt
SUCCESS: +1 4391 tests passed
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/1082/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/1082/console
Messages:
This message is automatically generated.