Hive
  1. Hive
  2. HIVE-5197

TestE2EScenerios.createTaskAttempt should use MapRedUtil

    Details

    • Type: Test Test
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.12.0
    • Component/s: None
    • Labels:
      None

      Description

      Basically we should use HCatMapRedUtil as opposed to new'ing the task attempt context.

      1. HIVE-5197.patch
        1 kB
        Brock Noland

        Issue Links

          Activity

          Hide
          Brock Noland added a comment -

          Trivial patch attached.

          Show
          Brock Noland added a comment - Trivial patch attached.
          Hide
          Hive QA added a comment -

          Overall: +1 all checks pass

          Here are the results of testing the latest attachment:
          https://issues.apache.org/jira/secure/attachment/12601191/HIVE-5197.patch

          SUCCESS: +1 2906 tests passed

          Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/594/testReport
          Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/594/console

          Messages:

          Executing org.apache.hive.ptest.execution.PrepPhase
          Executing org.apache.hive.ptest.execution.ExecutionPhase
          Executing org.apache.hive.ptest.execution.ReportingPhase
          

          This message is automatically generated.

          Show
          Hive QA added a comment - Overall : +1 all checks pass Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12601191/HIVE-5197.patch SUCCESS: +1 2906 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/594/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/594/console Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase This message is automatically generated.
          Hide
          Brock Noland added a comment -

          Thejas M Nair can I ask you to look at this simple patch?

          Show
          Brock Noland added a comment - Thejas M Nair can I ask you to look at this simple patch?
          Hide
          Thejas M Nair added a comment -

          Looks good. +1
          (The 24 hour wait before commit after +1 for patches like this seems unnecessary).

          Show
          Thejas M Nair added a comment - Looks good. +1 (The 24 hour wait before commit after +1 for patches like this seems unnecessary).
          Hide
          Thejas M Nair added a comment -

          Patch committed to trunk. Thanks for the contribution Brock!

          Show
          Thejas M Nair added a comment - Patch committed to trunk. Thanks for the contribution Brock!
          Hide
          Sushanth Sowmyan added a comment -

          Brock Noland : Looks good to me, but while making this change, did you, by any chance, verify if this works correctly on 2.x ? If so, HIVE-5135 can now be closed as a duplicate. If not, then we need to fix the shim loader to make sure that it does.

          Show
          Sushanth Sowmyan added a comment - Brock Noland : Looks good to me, but while making this change, did you, by any chance, verify if this works correctly on 2.x ? If so, HIVE-5135 can now be closed as a duplicate. If not, then we need to fix the shim loader to make sure that it does.
          Hide
          Brock Noland added a comment -

          Thanks Thejas! Sushanth yes it does and HIVE-5135 can be closed as a dup. I didn't see that one.

          Show
          Brock Noland added a comment - Thanks Thejas! Sushanth yes it does and HIVE-5135 can be closed as a dup. I didn't see that one.
          Hide
          Hudson added a comment -

          FAILURE: Integrated in Hive-trunk-hadoop2-ptest #83 (See https://builds.apache.org/job/Hive-trunk-hadoop2-ptest/83/)
          HIVE-5197: TestE2EScenerios.createTaskAttempt should use MapRedUtil (Brock Noland via Thejas Nair) (thejas: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1519916)

          • /hive/trunk/hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hcatalog/pig/TestE2EScenarios.java
          Show
          Hudson added a comment - FAILURE: Integrated in Hive-trunk-hadoop2-ptest #83 (See https://builds.apache.org/job/Hive-trunk-hadoop2-ptest/83/ ) HIVE-5197 : TestE2EScenerios.createTaskAttempt should use MapRedUtil (Brock Noland via Thejas Nair) (thejas: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1519916 ) /hive/trunk/hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hcatalog/pig/TestE2EScenarios.java
          Hide
          Hudson added a comment -

          FAILURE: Integrated in Hive-trunk-hadoop1-ptest #150 (See https://builds.apache.org/job/Hive-trunk-hadoop1-ptest/150/)
          HIVE-5197: TestE2EScenerios.createTaskAttempt should use MapRedUtil (Brock Noland via Thejas Nair) (thejas: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1519916)

          • /hive/trunk/hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hcatalog/pig/TestE2EScenarios.java
          Show
          Hudson added a comment - FAILURE: Integrated in Hive-trunk-hadoop1-ptest #150 (See https://builds.apache.org/job/Hive-trunk-hadoop1-ptest/150/ ) HIVE-5197 : TestE2EScenerios.createTaskAttempt should use MapRedUtil (Brock Noland via Thejas Nair) (thejas: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1519916 ) /hive/trunk/hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hcatalog/pig/TestE2EScenarios.java
          Hide
          Sushanth Sowmyan added a comment -

          Brock Noland Cool, will close that then. Thanks!

          Show
          Sushanth Sowmyan added a comment - Brock Noland Cool, will close that then. Thanks!
          Hide
          Hudson added a comment -

          FAILURE: Integrated in Hive-trunk-hadoop2 #404 (See https://builds.apache.org/job/Hive-trunk-hadoop2/404/)
          HIVE-5197: TestE2EScenerios.createTaskAttempt should use MapRedUtil (Brock Noland via Thejas Nair) (thejas: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1519916)

          • /hive/trunk/hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hcatalog/pig/TestE2EScenarios.java
          Show
          Hudson added a comment - FAILURE: Integrated in Hive-trunk-hadoop2 #404 (See https://builds.apache.org/job/Hive-trunk-hadoop2/404/ ) HIVE-5197 : TestE2EScenerios.createTaskAttempt should use MapRedUtil (Brock Noland via Thejas Nair) (thejas: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1519916 ) /hive/trunk/hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hcatalog/pig/TestE2EScenarios.java
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in Hive-trunk-h0.21 #2310 (See https://builds.apache.org/job/Hive-trunk-h0.21/2310/)
          HIVE-5197: TestE2EScenerios.createTaskAttempt should use MapRedUtil (Brock Noland via Thejas Nair) (thejas: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1519916)

          • /hive/trunk/hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hcatalog/pig/TestE2EScenarios.java
          Show
          Hudson added a comment - SUCCESS: Integrated in Hive-trunk-h0.21 #2310 (See https://builds.apache.org/job/Hive-trunk-h0.21/2310/ ) HIVE-5197 : TestE2EScenerios.createTaskAttempt should use MapRedUtil (Brock Noland via Thejas Nair) (thejas: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1519916 ) /hive/trunk/hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hcatalog/pig/TestE2EScenarios.java
          Hide
          Ashutosh Chauhan added a comment -

          This issue has been fixed and released as part of 0.12 release. If you find further issues, please create a new jira and link it to this one.

          Show
          Ashutosh Chauhan added a comment - This issue has been fixed and released as part of 0.12 release. If you find further issues, please create a new jira and link it to this one.

            People

            • Assignee:
              Brock Noland
              Reporter:
              Brock Noland
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development