Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.12.0
    • Fix Version/s: 0.12.0
    • Component/s: HCatalog
    • Labels:
      None

      Description

      Everything that this class does is delegated to a Shim class.
      To make HIVE-4895 and HIVE-4896 smoother, we need to get rid of HCatMapRedUtil and make the calls directly to the Shim layer. It will make it easier because all org.apache.hcatalog classes will move to org.apache.hive.hcatalog classes thus making way to provide binary backwards compat. This class won't change it's name so it's more difficult to provide backwards compat. The org.apache.hadoop.mapred.TempletonJobTracker is not an issue since it goes away in HIVE-4460.

      1. HIVE-5163.update.2
        0.9 kB
        Thejas M Nair
      2. HIVE-5163.update
        4 kB
        Eugene Koifman
      3. HIVE-5163.patch
        10 kB
        Eugene Koifman
      4. HIVE-5163.move
        6 kB
        Eugene Koifman

        Activity

        Ashutosh Chauhan made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Hide
        Ashutosh Chauhan added a comment -

        This issue has been fixed and released as part of 0.12 release. If you find further issues, please create a new jira and link it to this one.

        Show
        Ashutosh Chauhan added a comment - This issue has been fixed and released as part of 0.12 release. If you find further issues, please create a new jira and link it to this one.
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in Hive-trunk-hadoop1-ptest #149 (See https://builds.apache.org/job/Hive-trunk-hadoop1-ptest/149/)
        HIVE-5163 : refactor org.apache.hadoop.mapred.HCatMapRedUtil - HIVE-5163.update.2 (thejas: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1519538)

        • /hive/trunk/hcatalog/core/src/main/java/org/apache/hcatalog/mapreduce/HCatMapRedUtil.java
        Show
        Hudson added a comment - SUCCESS: Integrated in Hive-trunk-hadoop1-ptest #149 (See https://builds.apache.org/job/Hive-trunk-hadoop1-ptest/149/ ) HIVE-5163 : refactor org.apache.hadoop.mapred.HCatMapRedUtil - HIVE-5163 .update.2 (thejas: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1519538 ) /hive/trunk/hcatalog/core/src/main/java/org/apache/hcatalog/mapreduce/HCatMapRedUtil.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in Hive-trunk-hadoop2-ptest #82 (See https://builds.apache.org/job/Hive-trunk-hadoop2-ptest/82/)
        HIVE-5163 : refactor org.apache.hadoop.mapred.HCatMapRedUtil - HIVE-5163.update.2 (thejas: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1519538)

        • /hive/trunk/hcatalog/core/src/main/java/org/apache/hcatalog/mapreduce/HCatMapRedUtil.java
        Show
        Hudson added a comment - FAILURE: Integrated in Hive-trunk-hadoop2-ptest #82 (See https://builds.apache.org/job/Hive-trunk-hadoop2-ptest/82/ ) HIVE-5163 : refactor org.apache.hadoop.mapred.HCatMapRedUtil - HIVE-5163 .update.2 (thejas: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1519538 ) /hive/trunk/hcatalog/core/src/main/java/org/apache/hcatalog/mapreduce/HCatMapRedUtil.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in Hive-trunk-hadoop2 #398 (See https://builds.apache.org/job/Hive-trunk-hadoop2/398/)
        HIVE-5163 : refactor org.apache.hadoop.mapred.HCatMapRedUtil - HIVE-5163.update.2 (thejas: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1519538)

        • /hive/trunk/hcatalog/core/src/main/java/org/apache/hcatalog/mapreduce/HCatMapRedUtil.java
        Show
        Hudson added a comment - FAILURE: Integrated in Hive-trunk-hadoop2 #398 (See https://builds.apache.org/job/Hive-trunk-hadoop2/398/ ) HIVE-5163 : refactor org.apache.hadoop.mapred.HCatMapRedUtil - HIVE-5163 .update.2 (thejas: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1519538 ) /hive/trunk/hcatalog/core/src/main/java/org/apache/hcatalog/mapreduce/HCatMapRedUtil.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in Hive-trunk-h0.21 #2306 (See https://builds.apache.org/job/Hive-trunk-h0.21/2306/)
        HIVE-5163 : refactor org.apache.hadoop.mapred.HCatMapRedUtil - HIVE-5163.update.2 (thejas: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1519538)

        • /hive/trunk/hcatalog/core/src/main/java/org/apache/hcatalog/mapreduce/HCatMapRedUtil.java
        Show
        Hudson added a comment - FAILURE: Integrated in Hive-trunk-h0.21 #2306 (See https://builds.apache.org/job/Hive-trunk-h0.21/2306/ ) HIVE-5163 : refactor org.apache.hadoop.mapred.HCatMapRedUtil - HIVE-5163 .update.2 (thejas: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1519538 ) /hive/trunk/hcatalog/core/src/main/java/org/apache/hcatalog/mapreduce/HCatMapRedUtil.java
        Thejas M Nair made changes -
        Attachment HIVE-5163.update.2 [ 12601098 ]
        Hide
        Thejas M Nair added a comment -

        HIVE-5163.update was missing a change in the moved file. Attaching HIVE-5163.update.2 which is an additional change that had to be committed.

        Show
        Thejas M Nair added a comment - HIVE-5163 .update was missing a change in the moved file. Attaching HIVE-5163 .update.2 which is an additional change that had to be committed.
        Hide
        Hudson added a comment -

        FAILURE: Integrated in Hive-trunk-hadoop1-ptest #148 (See https://builds.apache.org/job/Hive-trunk-hadoop1-ptest/148/)
        HIVE-5163 : refactor org.apache.hadoop.mapred.HCatMapRedUtil (Eugene Koifman via Thejas Nair) (thejas: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1519530)

        • /hive/trunk/hcatalog/core/src/main/java/org/apache/hadoop/mapred/HCatMapRedUtil.java
        • /hive/trunk/hcatalog/core/src/main/java/org/apache/hcatalog/mapreduce/DefaultOutputCommitterContainer.java
        • /hive/trunk/hcatalog/core/src/main/java/org/apache/hcatalog/mapreduce/FileOutputCommitterContainer.java
        • /hive/trunk/hcatalog/core/src/main/java/org/apache/hcatalog/mapreduce/FileRecordWriterContainer.java
        • /hive/trunk/hcatalog/core/src/main/java/org/apache/hcatalog/mapreduce/HCatMapRedUtil.java
        • /hive/trunk/hcatalog/storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/HBaseInputFormat.java
        • /hive/trunk/hcatalog/storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/ImportSequenceFile.java
        Show
        Hudson added a comment - FAILURE: Integrated in Hive-trunk-hadoop1-ptest #148 (See https://builds.apache.org/job/Hive-trunk-hadoop1-ptest/148/ ) HIVE-5163 : refactor org.apache.hadoop.mapred.HCatMapRedUtil (Eugene Koifman via Thejas Nair) (thejas: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1519530 ) /hive/trunk/hcatalog/core/src/main/java/org/apache/hadoop/mapred/HCatMapRedUtil.java /hive/trunk/hcatalog/core/src/main/java/org/apache/hcatalog/mapreduce/DefaultOutputCommitterContainer.java /hive/trunk/hcatalog/core/src/main/java/org/apache/hcatalog/mapreduce/FileOutputCommitterContainer.java /hive/trunk/hcatalog/core/src/main/java/org/apache/hcatalog/mapreduce/FileRecordWriterContainer.java /hive/trunk/hcatalog/core/src/main/java/org/apache/hcatalog/mapreduce/HCatMapRedUtil.java /hive/trunk/hcatalog/storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/HBaseInputFormat.java /hive/trunk/hcatalog/storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/ImportSequenceFile.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in Hive-trunk-hadoop2-ptest #81 (See https://builds.apache.org/job/Hive-trunk-hadoop2-ptest/81/)
        HIVE-5163 : refactor org.apache.hadoop.mapred.HCatMapRedUtil (Eugene Koifman via Thejas Nair) (thejas: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1519530)

        • /hive/trunk/hcatalog/core/src/main/java/org/apache/hadoop/mapred/HCatMapRedUtil.java
        • /hive/trunk/hcatalog/core/src/main/java/org/apache/hcatalog/mapreduce/DefaultOutputCommitterContainer.java
        • /hive/trunk/hcatalog/core/src/main/java/org/apache/hcatalog/mapreduce/FileOutputCommitterContainer.java
        • /hive/trunk/hcatalog/core/src/main/java/org/apache/hcatalog/mapreduce/FileRecordWriterContainer.java
        • /hive/trunk/hcatalog/core/src/main/java/org/apache/hcatalog/mapreduce/HCatMapRedUtil.java
        • /hive/trunk/hcatalog/storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/HBaseInputFormat.java
        • /hive/trunk/hcatalog/storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/ImportSequenceFile.java
        Show
        Hudson added a comment - FAILURE: Integrated in Hive-trunk-hadoop2-ptest #81 (See https://builds.apache.org/job/Hive-trunk-hadoop2-ptest/81/ ) HIVE-5163 : refactor org.apache.hadoop.mapred.HCatMapRedUtil (Eugene Koifman via Thejas Nair) (thejas: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1519530 ) /hive/trunk/hcatalog/core/src/main/java/org/apache/hadoop/mapred/HCatMapRedUtil.java /hive/trunk/hcatalog/core/src/main/java/org/apache/hcatalog/mapreduce/DefaultOutputCommitterContainer.java /hive/trunk/hcatalog/core/src/main/java/org/apache/hcatalog/mapreduce/FileOutputCommitterContainer.java /hive/trunk/hcatalog/core/src/main/java/org/apache/hcatalog/mapreduce/FileRecordWriterContainer.java /hive/trunk/hcatalog/core/src/main/java/org/apache/hcatalog/mapreduce/HCatMapRedUtil.java /hive/trunk/hcatalog/storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/HBaseInputFormat.java /hive/trunk/hcatalog/storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/ImportSequenceFile.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in Hive-trunk-h0.21 #2305 (See https://builds.apache.org/job/Hive-trunk-h0.21/2305/)
        HIVE-5163 : refactor org.apache.hadoop.mapred.HCatMapRedUtil (Eugene Koifman via Thejas Nair) (thejas: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1519530)

        • /hive/trunk/hcatalog/core/src/main/java/org/apache/hadoop/mapred/HCatMapRedUtil.java
        • /hive/trunk/hcatalog/core/src/main/java/org/apache/hcatalog/mapreduce/DefaultOutputCommitterContainer.java
        • /hive/trunk/hcatalog/core/src/main/java/org/apache/hcatalog/mapreduce/FileOutputCommitterContainer.java
        • /hive/trunk/hcatalog/core/src/main/java/org/apache/hcatalog/mapreduce/FileRecordWriterContainer.java
        • /hive/trunk/hcatalog/core/src/main/java/org/apache/hcatalog/mapreduce/HCatMapRedUtil.java
        • /hive/trunk/hcatalog/storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/HBaseInputFormat.java
        • /hive/trunk/hcatalog/storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/ImportSequenceFile.java
        Show
        Hudson added a comment - FAILURE: Integrated in Hive-trunk-h0.21 #2305 (See https://builds.apache.org/job/Hive-trunk-h0.21/2305/ ) HIVE-5163 : refactor org.apache.hadoop.mapred.HCatMapRedUtil (Eugene Koifman via Thejas Nair) (thejas: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1519530 ) /hive/trunk/hcatalog/core/src/main/java/org/apache/hadoop/mapred/HCatMapRedUtil.java /hive/trunk/hcatalog/core/src/main/java/org/apache/hcatalog/mapreduce/DefaultOutputCommitterContainer.java /hive/trunk/hcatalog/core/src/main/java/org/apache/hcatalog/mapreduce/FileOutputCommitterContainer.java /hive/trunk/hcatalog/core/src/main/java/org/apache/hcatalog/mapreduce/FileRecordWriterContainer.java /hive/trunk/hcatalog/core/src/main/java/org/apache/hcatalog/mapreduce/HCatMapRedUtil.java /hive/trunk/hcatalog/storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/HBaseInputFormat.java /hive/trunk/hcatalog/storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/ImportSequenceFile.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in Hive-trunk-hadoop2 #397 (See https://builds.apache.org/job/Hive-trunk-hadoop2/397/)
        HIVE-5163 : refactor org.apache.hadoop.mapred.HCatMapRedUtil (Eugene Koifman via Thejas Nair) (thejas: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1519530)

        • /hive/trunk/hcatalog/core/src/main/java/org/apache/hadoop/mapred/HCatMapRedUtil.java
        • /hive/trunk/hcatalog/core/src/main/java/org/apache/hcatalog/mapreduce/DefaultOutputCommitterContainer.java
        • /hive/trunk/hcatalog/core/src/main/java/org/apache/hcatalog/mapreduce/FileOutputCommitterContainer.java
        • /hive/trunk/hcatalog/core/src/main/java/org/apache/hcatalog/mapreduce/FileRecordWriterContainer.java
        • /hive/trunk/hcatalog/core/src/main/java/org/apache/hcatalog/mapreduce/HCatMapRedUtil.java
        • /hive/trunk/hcatalog/storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/HBaseInputFormat.java
        • /hive/trunk/hcatalog/storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/ImportSequenceFile.java
        Show
        Hudson added a comment - FAILURE: Integrated in Hive-trunk-hadoop2 #397 (See https://builds.apache.org/job/Hive-trunk-hadoop2/397/ ) HIVE-5163 : refactor org.apache.hadoop.mapred.HCatMapRedUtil (Eugene Koifman via Thejas Nair) (thejas: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1519530 ) /hive/trunk/hcatalog/core/src/main/java/org/apache/hadoop/mapred/HCatMapRedUtil.java /hive/trunk/hcatalog/core/src/main/java/org/apache/hcatalog/mapreduce/DefaultOutputCommitterContainer.java /hive/trunk/hcatalog/core/src/main/java/org/apache/hcatalog/mapreduce/FileOutputCommitterContainer.java /hive/trunk/hcatalog/core/src/main/java/org/apache/hcatalog/mapreduce/FileRecordWriterContainer.java /hive/trunk/hcatalog/core/src/main/java/org/apache/hcatalog/mapreduce/HCatMapRedUtil.java /hive/trunk/hcatalog/storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/HBaseInputFormat.java /hive/trunk/hcatalog/storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/ImportSequenceFile.java
        Thejas M Nair made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Thejas M Nair added a comment -

        Committed to trunk. Thanks Eugene!

        Show
        Thejas M Nair added a comment - Committed to trunk. Thanks Eugene!
        Hide
        Thejas M Nair added a comment -

        Looks good +1.
        This is hcat only change, so I will make sure it doesn't break hive build and run the hcat unit tests before committing.

        Show
        Thejas M Nair added a comment - Looks good +1. This is hcat only change, so I will make sure it doesn't break hive build and run the hcat unit tests before committing.
        Eugene Koifman made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Eugene Koifman added a comment -

        This must be checked in after HIVE-4460

        Show
        Eugene Koifman added a comment - This must be checked in after HIVE-4460
        Eugene Koifman made changes -
        Field Original Value New Value
        Attachment HIVE-5163.move [ 12600429 ]
        Attachment HIVE-5163.patch [ 12600430 ]
        Attachment HIVE-5163.update [ 12600431 ]
        Hide
        Eugene Koifman added a comment -

        Moved HCatMapRedUtil to org.apache.hcatalog.mapreduce to make above mentioned bugs easier.
        HIVE-5163.patch - cummulative (for automated build)
        HIVE-5163.move - just the rename for SVN rename to preserve history
        HIVE-5163.update - changed to apply after SVN move is done

        Show
        Eugene Koifman added a comment - Moved HCatMapRedUtil to org.apache.hcatalog.mapreduce to make above mentioned bugs easier. HIVE-5163 .patch - cummulative (for automated build) HIVE-5163 .move - just the rename for SVN rename to preserve history HIVE-5163 .update - changed to apply after SVN move is done
        Eugene Koifman created issue -

          People

          • Assignee:
            Eugene Koifman
            Reporter:
            Eugene Koifman
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development