[HIVE-5044] StringUtils

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Won't Fix
• Assignee: Benjamin Jakobus
• Reporter: Benjamin Jakobus
• Created: 09/Aug/13 20:29
• Updated: 08/Nov/19 18:54
• Resolved: 08/Nov/19 18:54

Description

When you see code like this:
first = true;
for (int k = 0; k < columnSize; k++) {
String newColName = i + "VALUE" + k; // any name, it does not matter.
+ newColName = i + "VALUE" + k; // any name, it does not matter.
if (!first)
Unknown macro:

{ - valueColNames = valueColNames + ","; - valueColTypes = valueColTypes + ","; + valueColNames.append(","); + valueColTypes.append(","); }

valueColNames = valueColNames + newColName;
valueColTypes = valueColTypes + valueCols.get(k).getTypeString();
+ valueColNames.append(newColName);
+ valueColTypes.append(valueCols.get(k).getTypeString());
first = false;
Can you replace it with StringUtil.join()
I have seen this about 4 places in hive.