Hive
  1. Hive
  2. HIVE-4929

the type of all numeric constants is changed to double in the plan

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.12.0
    • Component/s: None
    • Labels:
      None

      Description

      There's code which, after the numeric type for a constant in where clause has been chosen as the most restricted one or based on suffix, tries to change the type to match the numeric column which the constant is being compared with. However, due to a hack from HIVE-3059 every column type shows up as string in that code, causing it to always change the constant type to double. This should not be done (regardless of the hack).
      Spinoff from HIVE-2702, large number of query outputs change so it will be a big patch

      1. HIVE-4929.patch
        328 kB
        Sergey Shelukhin

        Issue Links

          Activity

          Sergey Shelukhin created issue -
          Sergey Shelukhin made changes -
          Field Original Value New Value
          Link This issue blocks HIVE-2702 [ HIVE-2702 ]
          Hide
          Sergey Shelukhin added a comment -

          Review uploaded to RB (Phabricator errors out, seemingly due to size)

          Show
          Sergey Shelukhin added a comment - Review uploaded to RB (Phabricator errors out, seemingly due to size)
          Sergey Shelukhin made changes -
          Attachment HIVE-4929.patch [ 12594427 ]
          Sergey Shelukhin made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Ashutosh Chauhan added a comment -

          Sergey Shelukhin Can you post the RB link here ?

          Show
          Ashutosh Chauhan added a comment - Sergey Shelukhin Can you post the RB link here ?
          Show
          Sergey Shelukhin added a comment - https://reviews.apache.org/r/12974/
          Hide
          Ashutosh Chauhan added a comment -

          +1

          Show
          Ashutosh Chauhan added a comment - +1
          Hide
          Hive QA added a comment -

          Overall: +1 all checks pass

          Here are the results of testing the latest attachment:
          https://issues.apache.org/jira/secure/attachment/12594427/HIVE-4929.patch

          SUCCESS: +1 2653 tests passed

          Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/198/testReport
          Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/198/console

          Messages:

          Executing org.apache.hive.ptest.execution.CleanupPhase
          Executing org.apache.hive.ptest.execution.PrepPhase
          Executing org.apache.hive.ptest.execution.ExecutionPhase
          Executing org.apache.hive.ptest.execution.ReportingPhase
          

          This message is automatically generated.

          Show
          Hive QA added a comment - Overall : +1 all checks pass Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12594427/HIVE-4929.patch SUCCESS: +1 2653 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/198/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/198/console Messages: Executing org.apache.hive.ptest.execution.CleanupPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase This message is automatically generated.
          Hide
          Ashutosh Chauhan added a comment -

          Committed to trunk. Thanks, Sergey!

          Show
          Ashutosh Chauhan added a comment - Committed to trunk. Thanks, Sergey!
          Ashutosh Chauhan made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Fix Version/s 0.12.0 [ 12324312 ]
          Resolution Fixed [ 1 ]
          Hide
          Ashutosh Chauhan added a comment -

          This issue has been fixed and released as part of 0.12 release. If you find further issues, please create a new jira and link it to this one.

          Show
          Ashutosh Chauhan added a comment - This issue has been fixed and released as part of 0.12 release. If you find further issues, please create a new jira and link it to this one.
          Ashutosh Chauhan made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              Sergey Shelukhin
              Reporter:
              Sergey Shelukhin
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development