Uploaded image for project: 'Hive'
  1. Hive
  2. HIVE-4160 Vectorized Query Execution in Hive
  3. HIVE-4694

Fix ORC TestVectorizedORCReader testcase for Timestamps

Log workAgile BoardRank to TopRank to BottomBulk Copy AttachmentsBulk Move AttachmentsVotersWatch issueWatchersConvert to IssueMoveLinkCloneLabelsUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • vectorization-branch
    • vectorization-branch, 0.13.0
    • Tests
    • None
    • Fix ORC TestVectorizedORCReader for Timestamps containing sub-second timings

    Description

      ORC vectorized tests were not testing for timestamps correctly.

      java.sql.Timestamp is a confusing API, because of the mix of getTime() & getNanos() usage. Though it might look like they return independent values, getTime() includes part of the value already present in getNanos().

      Please view the implementation code for the confusion

      http://grepcode.com/file/repository.grepcode.com/java/root/jdk/openjdk/6-b14/java/sql/Timestamp.java#Timestamp.getTime%28%29

      Fix in HIVE-4681 caused test-failures, which needs the test to be fixed.

      Attachments

        1. HIVE-4694.patch
          1.0 kB
          Gopal Vijayaraghavan

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            gopalv Gopal Vijayaraghavan Assign to me
            gopalv Gopal Vijayaraghavan
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment