Hi, Thejas M Nair, Brock Noland, Carl Steinbach, thanks for your precious comments. I am working on the updated patch to address these comments, and will let you know when the updated patch is uploaded.
Earlier patch also had a method in HiveStatement to get the log. I think that will be convenient for many users, though we need to be careful and specify that is the only non jdbc function that is part of a public API in it. But this can also be done as follow up work in separate jira.
Thejas M Nair, you are right, adding a method in HiveStatement to get the log is convenient for users. I filed a Jira
HIVE-7615 and planed to add the getting log API in jdbc level there.
I didn't see this in the patch. Are you referring to something in the Thrift IDL file or something else?
Carl Steinbach, Brock Noland, the latest patch still does not fulfill the comments about backward compatibility. I will update the patch soon and let you know.
The Thrift level interface TCLIService is OK.
For client and service layer interface ICLIService, although it is not RPC and is not a public API of Hive, I think making it follow the single request/response struct mode is also good. Will make the new fetchResults method follow the single request/response struct model. Then remove those old fetchResults methods.