Hive
  1. Hive
  2. HIVE-4160 Vectorized Query Execution in Hive
  3. HIVE-4597

Remove test code from ql\src\java tree, place it itn ql\src\test tree

    Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Not a Problem
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Query Processor
    • Labels:
      None

      Description

      The TestCodeGen and the generated files (probably the templates too) belong in the ql\src\test tree, not in the ql\src\java tree

      1. HIVE-4597.patch
        374 kB
        Tony Murphy

        Activity

        Remus Rusanu created issue -
        Hide
        Tony Murphy added a comment -

        this is tricky since the test cases and vector expressions need to be generated in parallel, otherwise I don't have access to sufficient information to generate the tests. It would take major refactoring of CodeGen to make TestCodeGen independent.

        we could pull all the code generation(test and dev) up to hive_root\ql\src\gen

        Show
        Tony Murphy added a comment - this is tricky since the test cases and vector expressions need to be generated in parallel, otherwise I don't have access to sufficient information to generate the tests. It would take major refactoring of CodeGen to make TestCodeGen independent. we could pull all the code generation(test and dev) up to hive_root\ql\src\gen
        Hide
        Tony Murphy added a comment -

        also, the generated test suites are generated under ql\src\test\org\...vector\expressions\gen, the only things in the src tree should be the generation logic and the templates.

        Show
        Tony Murphy added a comment - also, the generated test suites are generated under ql\src\test\org\...vector\expressions\gen, the only things in the src tree should be the generation logic and the templates.
        Tony Murphy made changes -
        Field Original Value New Value
        Attachment HIVE-4597.patch [ 12584558 ]
        Tony Murphy made changes -
        Attachment HIVE-4597.patch [ 12584558 ]
        Tony Murphy made changes -
        Attachment HIVE-4597.patch [ 12584559 ]
        Hide
        Tony Murphy added a comment -
        Show
        Tony Murphy added a comment - review board review: https://reviews.apache.org/r/11349
        Hide
        Tony Murphy added a comment -

        There is not test code under ql/src/java, the test generation code does live with the vector expression generation code, but that is unavoidable. Remus has a task to move the generation code and integrate it with the build.

        Show
        Tony Murphy added a comment - There is not test code under ql/src/java, the test generation code does live with the vector expression generation code, but that is unavoidable. Remus has a task to move the generation code and integrate it with the build.
        Tony Murphy made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Not A Problem [ 8 ]

          People

          • Assignee:
            Tony Murphy
            Reporter:
            Remus Rusanu
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development