[HIVE-4576] templeton.hive.properties does not allow values with commas

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.5.0
• Fix Version/s: 0.13.1, 0.14.0
• Component/s: WebHCat
• Assignee: Eugene Koifman
• Reporter: Vitaliy Fuks
• Created: 19/May/13 17:21
• Updated: 05/Aug/15 23:45
• Resolved: 21/Apr/14 21:53

Description

templeton.hive.properties accepts a comma-separated list of key=value property pairs that will be passed to Hive.

However, this makes it impossible to use any "value" that itself has a comma in it.

For example:

<property>
  <name>templeton.hive.properties</name>
  <value>hive.metastore.sasl.enabled=false,hive.metastore.uris=thrift://foo1.example.com:9083,foo2.example.com:9083</value>
</property>

templeton: starting [/usr/bin/hive, --service, cli, --hiveconf, hive.metastore.sasl.enabled=false, --hiveconf, hive.metastore.uris=thrift://foo1.example.com:9083, --hiveconf, foo2.example.com:9083 etc..

because the value is parsed using standard org.apache.hadoop.conf.Configuration.getStrings() call which simply splits on commas from here:

for (String prop : appConf.getStrings(AppConfig.HIVE_PROPS_NAME))

This is problematic for any hive property that itself has multiple values, such as hive.metastore.uris above or hive.aux.jars.path.

There should be some way to "escape" commas or a different delimiter should be used.