Hive
  1. Hive
  2. HIVE-4523

round() function with specified decimal places not consistent with mysql

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.7.1
    • Fix Version/s: 0.13.0
    • Component/s: UDF
    • Labels:
      None

      Description

      // hive
      hive> select round(150.000, 2) from temp limit 1;
      150.0

      hive> select round(150, 2) from temp limit 1;
      150.0

      // mysql
      mysql> select round(150.000, 2) from DUAL limit 1;
      round(150.000, 2)
      150.00

      mysql> select round(150, 2) from DUAL limit 1;
      round(150, 2)
      150

      http://dev.mysql.com/doc/refman/5.1/en/mathematical-functions.html#function_round

      1. HIVE-4523.8.patch
        45 kB
        Xuefu Zhang
      2. HIVE-4523.7.patch
        45 kB
        Xuefu Zhang
      3. HIVE-4523.6.patch
        45 kB
        Xuefu Zhang
      4. HIVE-4523.5.patch
        42 kB
        Xuefu Zhang
      5. HIVE-4523.4.patch
        42 kB
        Xuefu Zhang
      6. HIVE-4523.3.patch
        39 kB
        Xuefu Zhang
      7. HIVE-4523.2.patch
        29 kB
        Xuefu Zhang
      8. HIVE-4523.1.patch
        28 kB
        Xuefu Zhang
      9. HIVE-4523.patch
        21 kB
        Xuefu Zhang

        Issue Links

          Activity

          Hide
          Xuefu Zhang added a comment -

          The problem (most of it) stated here will be addressed in decimal precision/scale initiative.

          Show
          Xuefu Zhang added a comment - The problem (most of it) stated here will be addressed in decimal precision/scale initiative.
          Hide
          Xuefu Zhang added a comment -

          Patch #1 fixes test failures. Please note that the patches here requires patch from HIVE-3976.

          Show
          Xuefu Zhang added a comment - Patch #1 fixes test failures. Please note that the patches here requires patch from HIVE-3976 .
          Hide
          Xuefu Zhang added a comment -

          Patch #2 rebased with latest trunk. Still need additional test cases.

          Show
          Xuefu Zhang added a comment - Patch #2 rebased with latest trunk. Still need additional test cases.
          Hide
          Xuefu Zhang added a comment -

          Patch #3 added test cases.

          Show
          Xuefu Zhang added a comment - Patch #3 added test cases.
          Hide
          Xuefu Zhang added a comment -
          Show
          Xuefu Zhang added a comment - RB: https://reviews.apache.org/r/15103/
          Hide
          Eric Hanson added a comment -

          Thanks for making sure the new vectorization code path is updated correctly for this.

          Show
          Eric Hanson added a comment - Thanks for making sure the new vectorization code path is updated correctly for this.
          Hide
          Hive QA added a comment -

          Overall: -1 no tests executed

          Here are the results of testing the latest attachment:
          https://issues.apache.org/jira/secure/attachment/12611158/HIVE-4523.3.patch

          Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/81/testReport
          Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/81/console

          Messages:

          Executing org.apache.hive.ptest.execution.PrepPhase
          Tests failed with: NonZeroExitCodeException: Command 'bash /data/hive-ptest/working/scratch/source-prep.sh' failed with exit status 1 and output '+ [[ -n '' ]]
          + export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m -Dhttp.proxyHost=localhost -Dhttp.proxyPort=3128'
          + ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m -Dhttp.proxyHost=localhost -Dhttp.proxyPort=3128'
          + export 'M2_OPTS=-Xmx1g -XX:MaxPermSize=256m '
          + M2_OPTS='-Xmx1g -XX:MaxPermSize=256m '
          + cd /data/hive-ptest/working/
          + tee /data/hive-ptest/logs/PreCommit-HIVE-Build-81/source-prep.txt
          + [[ true == \t\r\u\e ]]
          + rm -rf ivy maven
          + mkdir -p maven ivy
          + [[ svn = \s\v\n ]]
          + [[ -n '' ]]
          + [[ -d apache-svn-trunk-source ]]
          + [[ ! -d apache-svn-trunk-source/.svn ]]
          + [[ ! -d apache-svn-trunk-source ]]
          + cd apache-svn-trunk-source
          + svn revert -R .
          Reverted 'ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g'
          Reverted 'ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g'
          Reverted 'ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g'
          Reverted 'ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java'
          ++ egrep -v '^X|^Performing status on external'
          ++ awk '{print $2}'
          ++ svn status --no-ignore
          + rm -rf build hcatalog/build hcatalog/core/build hcatalog/storage-handlers/hbase/build hcatalog/server-extensions/build hcatalog/webhcat/svr/build hcatalog/webhcat/java-client/build hcatalog/hcatalog-pig-adapter/build common/src/gen ql/src/test/results/clientpositive/type_aliases.q.out ql/src/test/queries/clientpositive/type_aliases.q
          + svn update
          U    build.properties
          U    ql/src/test/queries/clientpositive/type_widening.q
          U    ql/src/test/queries/clientpositive/udf_PI.q
          U    ql/src/test/queries/clientpositive/udf_array_contains.q
          U    ql/src/test/queries/clientpositive/decimal_1.q
          U    ql/src/test/queries/clientpositive/udf_bitmap_empty.q
          U    ql/src/test/queries/clientpositive/partcols1.q
          U    ql/src/test/queries/clientpositive/udf_coalesce.q
          U    ql/src/test/queries/clientpositive/binary_constant.q
          U    ql/src/test/queries/clientpositive/udf_weekofyear.q
          U    ql/src/test/queries/clientpositive/udf_testlength.q
          U    ql/src/test/queries/clientpositive/udf_xpath.q
          U    ql/src/test/queries/clientpositive/udf_round_3.q
          U    ql/src/test/queries/clientpositive/udf_length.q
          U    ql/src/test/queries/clientpositive/udf_union.q
          U    ql/src/test/queries/clientpositive/udf_radians.q
          U    ql/src/test/queries/clientpositive/udf_if.q
          U    ql/src/test/queries/clientpositive/udf_reflect2.q
          U    ql/src/test/queries/clientpositive/udf_rpad.q
          U    ql/src/test/queries/clientpositive/udf_get_json_object.q
          U    ql/src/test/queries/clientpositive/udf_map.q
          U    ql/src/test/queries/clientpositive/udf_div.q
          U    ql/src/test/queries/clientpositive/timestamp_2.q
          U    ql/src/test/queries/clientpositive/udf_named_struct.q
          U    ql/src/test/queries/clientpositive/partition_date2.q
          U    ql/src/test/queries/clientpositive/udf_split.q
          U    ql/src/test/queries/clientpositive/udf_xpath_float.q
          U    ql/src/test/queries/clientpositive/udf_sort_array.q
          U    ql/src/test/queries/clientpositive/udf_map_keys.q
          U    ql/src/test/queries/clientpositive/type_cast_1.q
          U    ql/src/test/queries/clientpositive/udf_locate.q
          U    ql/src/test/queries/clientpositive/cast_to_int.q
          U    ql/src/test/queries/clientpositive/udf_space.q
          U    ql/src/test/queries/clientpositive/udf_xpath_double.q
          U    ql/src/test/queries/clientpositive/udf_like.q
          U    ql/src/test/queries/clientpositive/type_conversions_1.q
          U    ql/src/test/queries/clientpositive/udf_logic_java_boolean.q
          U    ql/src/test/queries/clientpositive/decimal_udf.q
          U    ql/src/test/queries/clientpositive/udf_xpath_int.q
          U    ql/src/test/queries/clientpositive/udf_printf.q
          U    ql/src/test/queries/clientpositive/udf_xpath_boolean.q
          U    ql/src/test/queries/clientpositive/literal_string.q
          U    ql/src/test/queries/clientpositive/union34.q
          U    ql/src/test/queries/clientpositive/partition_varchar1.q
          U    ql/src/test/queries/clientpositive/udf_hex.q
          U    ql/src/test/queries/clientpositive/udf_concat.q
          U    ql/src/test/queries/clientpositive/udf_array.q
          U    ql/src/test/queries/clientpositive/udf_round.q
          U    ql/src/test/queries/clientpositive/udf_ascii.q
          U    ql/src/test/queries/clientpositive/udf_to_string.q
          U    ql/src/test/queries/clientpositive/ppd_union_view.q
          U    ql/src/test/queries/clientpositive/constant_prop.q
          U    ql/src/test/queries/clientpositive/transform1.q
          U    ql/src/test/queries/clientpositive/udf_lessthan.q
          U    ql/src/test/queries/clientpositive/udf_atan.q
          U    ql/src/test/queries/clientpositive/udf_sign.q
          U    ql/src/test/queries/clientpositive/udf_in.q
          U    ql/src/test/queries/clientpositive/partition_decode_name.q
          U    ql/src/test/queries/clientpositive/udf_hash.q
          U    ql/src/test/queries/clientpositive/date_4.q
          U    ql/src/test/queries/clientpositive/udf_case.q
          U    ql/src/test/queries/clientpositive/udf_negative.q
          U    ql/src/test/queries/clientpositive/varchar_cast.q
          U    ql/src/test/queries/clientpositive/ppr_pushdown2.q
          U    ql/src/test/queries/clientpositive/udtf_parse_url_tuple.q
          U    ql/src/test/queries/clientpositive/udf_testlength2.q
          U    ql/src/test/queries/clientpositive/macro.q
          U    ql/src/test/queries/clientpositive/udf_pmod.q
          U    ql/src/test/queries/clientpositive/ctas.q
          U    ql/src/test/queries/clientpositive/udf_instr.q
          U    ql/src/test/queries/clientpositive/udtf_explode.q
          U    ql/src/test/queries/clientpositive/lateral_view_noalias.q
          U    ql/src/test/queries/clientpositive/orc_empty_strings.q
          U    ql/src/test/queries/clientpositive/varchar_comparison.q
          U    ql/src/test/queries/clientpositive/truncate_column_merge.q
          U    ql/src/test/queries/clientpositive/timestamp_udf.q
          U    ql/src/test/queries/clientpositive/udf_find_in_set.q
          U    ql/src/test/queries/clientpositive/udf_tan.q
          U    ql/src/test/queries/clientpositive/null_cast.q
          U    ql/src/test/queries/clientpositive/udf_regexp.q
          U    ql/src/test/queries/clientpositive/timestamp_comparison.q
          U    ql/src/test/queries/clientpositive/udf_when.q
          U    ql/src/test/queries/clientpositive/udf_abs.q
          U    ql/src/test/queries/clientpositive/udf_case_thrift.q
          U    ql/src/test/queries/clientpositive/udf_to_short.q
          U    ql/src/test/queries/clientpositive/udf_isnull_isnotnull.q
          U    ql/src/test/queries/clientpositive/decimal_2.q
          U    ql/src/test/queries/clientpositive/udf_struct.q
          U    ql/src/test/queries/clientpositive/udf_greaterthan.q
          U    ql/src/test/queries/clientpositive/udf_round_2.q
          U    ql/src/test/queries/clientpositive/udf_compare_java_string.q
          U    ql/src/test/queries/clientpositive/ops_comparison.q
          U    ql/src/test/queries/clientpositive/udf_nvl.q
          U    ql/src/test/queries/clientpositive/udf_conv.q
          U    ql/src/test/queries/clientpositive/udf_field.q
          U    ql/src/test/queries/clientpositive/literal_ints.q
          U    ql/src/test/queries/clientpositive/udf_second.q
          U    ql/src/test/queries/clientpositive/udf_translate.q
          U    ql/src/test/queries/clientpositive/date_comparison.q
          U    ql/src/test/queries/clientpositive/udf_degrees.q
          U    ql/src/test/queries/clientpositive/udf_acos.q
          U    ql/src/test/queries/clientpositive/timestamp_1.q
          U    ql/src/test/queries/clientpositive/udf_greaterthanorequal.q
          U    ql/src/test/queries/clientpositive/partition_special_char.q
          U    ql/src/test/queries/clientpositive/udf_lpad.q
          U    ql/src/test/queries/clientpositive/udf_to_long.q
          U    ql/src/test/queries/clientpositive/udf_to_unix_timestamp.q
          U    ql/src/test/queries/clientpositive/udf_hour.q
          U    ql/src/test/queries/clientpositive/timestamp_3.q
          U    ql/src/test/queries/clientpositive/udf_asin.q
          U    ql/src/test/queries/clientpositive/alter_varchar2.q
          U    ql/src/test/queries/clientpositive/literal_decimal.q
          U    ql/src/test/queries/clientpositive/udf_xpath_string.q
          U    ql/src/test/queries/clientpositive/udf_inline.q
          U    ql/src/test/queries/clientpositive/udf_notequal.q
          U    ql/src/test/queries/clientpositive/udf_java_method.q
          U    ql/src/test/queries/clientpositive/udf_bitmap_and.q
          U    ql/src/test/queries/clientpositive/udf_to_byte.q
          U    ql/src/test/queries/clientpositive/udf_reflect.q
          U    ql/src/test/queries/clientpositive/udf_format_number.q
          U    ql/src/test/queries/clientpositive/num_op_type_conv.q
          U    ql/src/test/queries/clientpositive/udf_bin.q
          U    ql/src/test/queries/clientpositive/udf_repeat.q
          U    ql/src/test/queries/clientpositive/udf_cos.q
          U    ql/src/test/queries/clientpositive/literal_double.q
          U    ql/src/test/queries/clientpositive/auto_join_reordering_values.q
          U    ql/src/test/queries/clientpositive/udf_map_values.q
          U    ql/src/test/queries/clientpositive/udf_notop.q
          U    ql/src/test/queries/clientpositive/test_boolean_whereclause.q
          U    ql/src/test/queries/clientpositive/udf_elt.q
          U    ql/src/test/queries/clientpositive/date_1.q
          U    ql/src/test/queries/clientpositive/truncate_column.q
          U    ql/src/test/queries/clientpositive/udf_between.q
          U    ql/src/test/queries/clientpositive/udf_to_float.q
          U    ql/src/test/queries/clientpositive/str_to_map.q
          U    ql/src/test/queries/clientpositive/udf_concat_ws.q
          U    ql/src/test/queries/clientpositive/udf_sin.q
          U    ql/src/test/queries/clientpositive/udf_explode.q
          U    ql/src/test/queries/clientpositive/udf_to_double.q
          U    ql/src/test/queries/clientpositive/udf_to_boolean.q
          U    ql/src/test/queries/clientpositive/date_3.q
          U    ql/src/test/queries/clientpositive/udf_equal.q
          U    ql/src/test/queries/clientpositive/udf_lessthanorequal.q
          U    ql/src/test/queries/clientpositive/udf_E.q
          U    ql/src/test/queries/clientpositive/udf_unhex.q
          U    ql/src/test/queries/clientpositive/udf_xpath_short.q
          U    ql/src/test/queries/clientpositive/disallow_incompatible_type_change_off.q
          U    ql/src/test/queries/clientpositive/compile_processor.q
          U    ql/src/test/queries/clientpositive/timestamp_lazy.q
          U    ql/src/test/queries/clientpositive/ppr_pushdown.q
          U    ql/src/test/queries/clientpositive/udtf_json_tuple.q
          U    ql/src/test/queries/clientpositive/partition_date.q
          U    ql/src/test/queries/clientpositive/udf_bitmap_or.q
          U    ql/src/test/queries/clientpositive/quote2.q
          U    ql/src/test/queries/clientpositive/udf_xpath_long.q
          U    ql/src/test/queries/clientpositive/udf_size.q
          U    ql/src/test/queries/clientpositive/udf_divide.q
          U    ql/src/test/queries/clientpositive/udf_unix_timestamp.q
          U    ql/src/test/queries/clientpositive/filter_join_breaktask2.q
          U    ql/src/test/queries/clientpositive/udf_substr.q
          U    ql/src/test/queries/clientpositive/orc_diff_part_cols.q
          U    ql/src/test/results/clientpositive/udf_xpath_short.q.out
          U    ql/src/test/results/clientpositive/udf_xpath_string.q.out
          U    ql/src/test/results/clientpositive/udf_to_double.q.out
          U    ql/src/test/results/clientpositive/udf_union.q.out
          U    ql/src/test/results/clientpositive/udf_isnull_isnotnull.q.out
          U    ql/src/test/results/clientpositive/decimal_2.q.out
          U    ql/src/test/results/clientpositive/timestamp_3.q.out
          U    ql/src/test/results/clientpositive/decimal_udf.q.out
          U    ql/src/test/results/clientpositive/udf_sign.q.out
          U    ql/src/test/results/clientpositive/macro.q.out
          U    ql/src/test/results/clientpositive/udf_pmod.q.out
          U    ql/src/test/results/clientpositive/partcols1.q.out
          U    ql/src/test/results/clientpositive/udf_to_boolean.q.out
          U    ql/src/test/results/clientpositive/date_3.q.out
          U    ql/src/test/results/clientpositive/udf_lessthan.q.out
          U    ql/src/test/results/clientpositive/udf_radians.q.out
          U    ql/src/test/results/clientpositive/truncate_column_merge.q.out
          U    ql/src/test/results/clientpositive/timestamp_udf.q.out
          U    ql/src/test/results/clientpositive/filter_join_breaktask2.q.out
          U    ql/src/test/results/clientpositive/udf_bitmap_or.q.out
          U    ql/src/test/results/clientpositive/timestamp_comparison.q.out
          U    ql/src/test/results/clientpositive/udf_notop.q.out
          U    ql/src/test/results/clientpositive/udf_like.q.out
          U    ql/src/test/results/clientpositive/udf_round.q.out
          U    ql/src/test/results/clientpositive/udf_case_thrift.q.out
          U    ql/src/test/results/clientpositive/udf_hour.q.out
          U    ql/src/test/results/clientpositive/udf_if.q.out
          U    ql/src/test/results/clientpositive/udf_format_number.q.out
          U    ql/src/test/results/clientpositive/udf_rpad.q.out
          U    ql/src/test/results/clientpositive/udf_bin.q.out
          U    ql/src/test/results/clientpositive/udf_div.q.out
          U    ql/src/test/results/clientpositive/udf_field.q.out
          U    ql/src/test/results/clientpositive/auto_join_reordering_values.q.out
          U    ql/src/test/results/clientpositive/udf_negative.q.out
          U    ql/src/test/results/clientpositive/quote2.q.out
          U    ql/src/test/results/clientpositive/udf_ascii.q.out
          U    ql/src/test/results/clientpositive/udf_atan.q.out
          U    ql/src/test/results/clientpositive/ppr_pushdown.q.out
          U    ql/src/test/results/clientpositive/udtf_json_tuple.q.out
          U    ql/src/test/results/clientpositive/udf_hash.q.out
          U    ql/src/test/results/clientpositive/union34.q.out
          U    ql/src/test/results/clientpositive/udf_to_string.q.out
          U    ql/src/test/results/clientpositive/udf_concat_ws.q.out
          U    ql/src/test/results/clientpositive/udf_when.q.out
          U    ql/src/test/results/clientpositive/udf_split.q.out
          U    ql/src/test/results/clientpositive/udf_to_short.q.out
          U    ql/src/test/results/clientpositive/udf_size.q.out
          U    ql/src/test/results/clientpositive/udf_substr.q.out
          U    ql/src/test/results/clientpositive/udf_between.q.out
          U    ql/src/test/results/clientpositive/udf_weekofyear.q.out
          U    ql/src/test/results/clientpositive/udf_testlength.q.out
          U    ql/src/test/results/clientpositive/null_cast.q.out
          U    ql/src/test/results/clientpositive/udf_named_struct.q.out
          U    ql/src/test/results/clientpositive/udf_sin.q.out
          U    ql/src/test/results/clientpositive/udf_bitmap_empty.q.out
          U    ql/src/test/results/clientpositive/udf_regexp.q.out
          U    ql/src/test/results/clientpositive/udf_space.q.out
          U    ql/src/test/results/clientpositive/partition_special_char.q.out
          U    ql/src/test/results/clientpositive/udf_lpad.q.out
          U    ql/src/test/results/clientpositive/udf_length.q.out
          U    ql/src/test/results/clientpositive/udf_xpath_long.q.out
          U    ql/src/test/results/clientpositive/timestamp_lazy.q.out
          U    ql/src/test/results/clientpositive/udf_map_keys.q.out
          U    ql/src/test/results/clientpositive/literal_decimal.q.out
          U    ql/src/test/results/clientpositive/orc_diff_part_cols.q.out
          U    ql/src/test/results/clientpositive/transform1.q.out
          U    ql/src/test/results/clientpositive/udf_lessthanorequal.q.out
          U    ql/src/test/results/clientpositive/udf_degrees.q.out
          U    ql/src/test/results/clientpositive/udf_divide.q.out
          U    ql/src/test/results/clientpositive/udf_nvl.q.out
          U    ql/src/test/results/clientpositive/decimal_1.q.out
          U    ql/src/test/results/clientpositive/udf_hex.q.out
          U    ql/src/test/results/clientpositive/timestamp_2.q.out
          U    ql/src/test/results/clientpositive/literal_double.q.out
          U    ql/src/test/results/clientpositive/udf_second.q.out
          U    ql/src/test/results/clientpositive/constant_prop.q.out
          U    ql/src/test/results/clientpositive/udf_find_in_set.q.out
          U    ql/src/test/results/clientpositive/udf_testlength2.q.out
          U    ql/src/test/results/clientpositive/udf_xpath_int.q.out
          U    ql/src/test/results/clientpositive/udf_printf.q.out
          U    ql/src/test/results/clientpositive/udf_E.q.out
          U    ql/src/test/results/clientpositive/partition_varchar1.q.out
          U    ql/src/test/results/clientpositive/udf_conv.q.out
          U    ql/src/test/results/clientpositive/str_to_map.q.out
          U    ql/src/test/results/clientpositive/udf_tan.q.out
          U    ql/src/test/results/clientpositive/udf_round_3.q.out
          U    ql/src/test/results/clientpositive/ppr_pushdown2.q.out
          U    ql/src/test/results/clientpositive/udf_array.q.out
          U    ql/src/test/results/clientpositive/udf_coalesce.q.out
          U    ql/src/test/results/clientpositive/udf_acos.q.out
          U    ql/src/test/results/clientpositive/udf_greaterthanorequal.q.out
          U    ql/src/test/results/clientpositive/partition_date.q.out
          U    ql/src/test/results/clientpositive/cast_to_int.q.out
          U    ql/src/test/results/clientpositive/udtf_parse_url_tuple.q.out
          U    ql/src/test/results/clientpositive/udf_to_long.q.out
          U    ql/src/test/results/clientpositive/udf_xpath_float.q.out
          U    ql/src/test/results/clientpositive/orc_empty_strings.q.out
          U    ql/src/test/results/clientpositive/udf_sort_array.q.out
          U    ql/src/test/results/clientpositive/partition_decode_name.q.out
          U    ql/src/test/results/clientpositive/literal_string.q.out
          U    ql/src/test/results/clientpositive/date_4.q.out
          U    ql/src/test/results/clientpositive/disallow_incompatible_type_change_off.q.out
          U    ql/src/test/results/clientpositive/udf_PI.q.out
          U    ql/src/test/results/clientpositive/partition_date2.q.out
          U    ql/src/test/results/clientpositive/udf_map_values.q.out
          U    ql/src/test/results/clientpositive/udf_java_method.q.out
          U    ql/src/test/results/clientpositive/udf_equal.q.out
          U    ql/src/test/results/clientpositive/udf_greaterthan.q.out
          U    ql/src/test/results/clientpositive/num_op_type_conv.q.out
          U    ql/src/test/results/clientpositive/udf_unhex.q.out
          U    ql/src/test/results/clientpositive/udf_case.q.out
          U    ql/src/test/results/clientpositive/udf_xpath.q.out
          U    ql/src/test/results/clientpositive/udf_explode.q.out
          U    ql/src/test/results/clientpositive/udf_abs.q.out
          U    ql/src/test/results/clientpositive/udf_xpath_double.q.out
          U    ql/src/test/results/clientpositive/udf_bitmap_and.q.out
          U    ql/src/test/results/clientpositive/udf_locate.q.out
          U    ql/src/test/results/clientpositive/udf_instr.q.out
          U    ql/src/test/results/clientpositive/udf_translate.q.out
          U    ql/src/test/results/clientpositive/timestamp_1.q.out
          U    ql/src/test/results/clientpositive/udf_xpath_boolean.q.out
          U    ql/src/test/results/clientpositive/type_widening.q.out
          U    ql/src/test/results/clientpositive/udf_map.q.out
          U    ql/src/test/results/clientpositive/udf_notequal.q.out
          U    ql/src/test/results/clientpositive/test_boolean_whereclause.q.out
          U    ql/src/test/results/clientpositive/udf_concat.q.out
          U    ql/src/test/results/clientpositive/compile_processor.q.out
          U    ql/src/test/results/clientpositive/date_1.q.out
          U    ql/src/test/results/clientpositive/udf_reflect.q.out
          U    ql/src/test/results/clientpositive/alter_varchar2.q.out
          U    ql/src/test/results/clientpositive/udf_in.q.out
          U    ql/src/test/results/clientpositive/type_cast_1.q.out
          U    ql/src/test/results/clientpositive/udf_get_json_object.q.out
          U    ql/src/test/results/clientpositive/binary_constant.q.out
          U    ql/src/test/results/clientpositive/udf_to_float.q.out
          U    ql/src/test/results/clientpositive/udf_array_contains.q.out
          U    ql/src/test/results/clientpositive/udf_repeat.q.out
          U    ql/src/test/results/clientpositive/udf_cos.q.out
          U    ql/src/test/results/clientpositive/literal_ints.q.out
          U    ql/src/test/results/clientpositive/udf_elt.q.out
          U    ql/src/test/results/clientpositive/ppd_union_view.q.out
          U    ql/src/test/results/clientpositive/truncate_column.q.out
          U    ql/src/test/results/clientpositive/udf_to_byte.q.out
          U    ql/src/test/results/clientpositive/udf_struct.q.out
          U    ql/src/test/results/clientpositive/udf_asin.q.out
          U    ql/src/test/results/clientpositive/udf_round_2.q.out
          U    ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
          
          Fetching external item into 'hcatalog/src/test/e2e/harness'
          Updated external to revision 1537558.
          
          Updated to revision 1537558.
          + patchCommandPath=/data/hive-ptest/working/scratch/smart-apply-patch.sh
          + patchFilePath=/data/hive-ptest/working/scratch/build.patch
          + [[ -f /data/hive-ptest/working/scratch/build.patch ]]
          + chmod +x /data/hive-ptest/working/scratch/smart-apply-patch.sh
          + /data/hive-ptest/working/scratch/smart-apply-patch.sh /data/hive-ptest/working/scratch/build.patch
          The patch does not appear to apply with p0, p1, or p2
          + exit 1
          '
          

          This message is automatically generated.

          Show
          Hive QA added a comment - Overall : -1 no tests executed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12611158/HIVE-4523.3.patch Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/81/testReport Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/81/console Messages: Executing org.apache.hive.ptest.execution.PrepPhase Tests failed with: NonZeroExitCodeException: Command 'bash /data/hive-ptest/working/scratch/source-prep.sh' failed with exit status 1 and output '+ [[ -n '' ]] + export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m -Dhttp.proxyHost=localhost -Dhttp.proxyPort=3128' + ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m -Dhttp.proxyHost=localhost -Dhttp.proxyPort=3128' + export 'M2_OPTS=-Xmx1g -XX:MaxPermSize=256m ' + M2_OPTS='-Xmx1g -XX:MaxPermSize=256m ' + cd /data/hive-ptest/working/ + tee /data/hive-ptest/logs/PreCommit-HIVE-Build-81/source-prep.txt + [[ true == \t\r\u\e ]] + rm -rf ivy maven + mkdir -p maven ivy + [[ svn = \s\v\n ]] + [[ -n '' ]] + [[ -d apache-svn-trunk-source ]] + [[ ! -d apache-svn-trunk-source/.svn ]] + [[ ! -d apache-svn-trunk-source ]] + cd apache-svn-trunk-source + svn revert -R . Reverted 'ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g' Reverted 'ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g' Reverted 'ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g' Reverted 'ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java' ++ egrep -v '^X|^Performing status on external' ++ awk '{print $2}' ++ svn status --no-ignore + rm -rf build hcatalog/build hcatalog/core/build hcatalog/storage-handlers/hbase/build hcatalog/server-extensions/build hcatalog/webhcat/svr/build hcatalog/webhcat/java-client/build hcatalog/hcatalog-pig-adapter/build common/src/gen ql/src/test/results/clientpositive/type_aliases.q.out ql/src/test/queries/clientpositive/type_aliases.q + svn update U build.properties U ql/src/test/queries/clientpositive/type_widening.q U ql/src/test/queries/clientpositive/udf_PI.q U ql/src/test/queries/clientpositive/udf_array_contains.q U ql/src/test/queries/clientpositive/decimal_1.q U ql/src/test/queries/clientpositive/udf_bitmap_empty.q U ql/src/test/queries/clientpositive/partcols1.q U ql/src/test/queries/clientpositive/udf_coalesce.q U ql/src/test/queries/clientpositive/binary_constant.q U ql/src/test/queries/clientpositive/udf_weekofyear.q U ql/src/test/queries/clientpositive/udf_testlength.q U ql/src/test/queries/clientpositive/udf_xpath.q U ql/src/test/queries/clientpositive/udf_round_3.q U ql/src/test/queries/clientpositive/udf_length.q U ql/src/test/queries/clientpositive/udf_union.q U ql/src/test/queries/clientpositive/udf_radians.q U ql/src/test/queries/clientpositive/udf_if.q U ql/src/test/queries/clientpositive/udf_reflect2.q U ql/src/test/queries/clientpositive/udf_rpad.q U ql/src/test/queries/clientpositive/udf_get_json_object.q U ql/src/test/queries/clientpositive/udf_map.q U ql/src/test/queries/clientpositive/udf_div.q U ql/src/test/queries/clientpositive/timestamp_2.q U ql/src/test/queries/clientpositive/udf_named_struct.q U ql/src/test/queries/clientpositive/partition_date2.q U ql/src/test/queries/clientpositive/udf_split.q U ql/src/test/queries/clientpositive/udf_xpath_float.q U ql/src/test/queries/clientpositive/udf_sort_array.q U ql/src/test/queries/clientpositive/udf_map_keys.q U ql/src/test/queries/clientpositive/type_cast_1.q U ql/src/test/queries/clientpositive/udf_locate.q U ql/src/test/queries/clientpositive/cast_to_int.q U ql/src/test/queries/clientpositive/udf_space.q U ql/src/test/queries/clientpositive/udf_xpath_double.q U ql/src/test/queries/clientpositive/udf_like.q U ql/src/test/queries/clientpositive/type_conversions_1.q U ql/src/test/queries/clientpositive/udf_logic_java_boolean.q U ql/src/test/queries/clientpositive/decimal_udf.q U ql/src/test/queries/clientpositive/udf_xpath_int.q U ql/src/test/queries/clientpositive/udf_printf.q U ql/src/test/queries/clientpositive/udf_xpath_boolean.q U ql/src/test/queries/clientpositive/literal_string.q U ql/src/test/queries/clientpositive/union34.q U ql/src/test/queries/clientpositive/partition_varchar1.q U ql/src/test/queries/clientpositive/udf_hex.q U ql/src/test/queries/clientpositive/udf_concat.q U ql/src/test/queries/clientpositive/udf_array.q U ql/src/test/queries/clientpositive/udf_round.q U ql/src/test/queries/clientpositive/udf_ascii.q U ql/src/test/queries/clientpositive/udf_to_string.q U ql/src/test/queries/clientpositive/ppd_union_view.q U ql/src/test/queries/clientpositive/constant_prop.q U ql/src/test/queries/clientpositive/transform1.q U ql/src/test/queries/clientpositive/udf_lessthan.q U ql/src/test/queries/clientpositive/udf_atan.q U ql/src/test/queries/clientpositive/udf_sign.q U ql/src/test/queries/clientpositive/udf_in.q U ql/src/test/queries/clientpositive/partition_decode_name.q U ql/src/test/queries/clientpositive/udf_hash.q U ql/src/test/queries/clientpositive/date_4.q U ql/src/test/queries/clientpositive/udf_case.q U ql/src/test/queries/clientpositive/udf_negative.q U ql/src/test/queries/clientpositive/varchar_cast.q U ql/src/test/queries/clientpositive/ppr_pushdown2.q U ql/src/test/queries/clientpositive/udtf_parse_url_tuple.q U ql/src/test/queries/clientpositive/udf_testlength2.q U ql/src/test/queries/clientpositive/macro.q U ql/src/test/queries/clientpositive/udf_pmod.q U ql/src/test/queries/clientpositive/ctas.q U ql/src/test/queries/clientpositive/udf_instr.q U ql/src/test/queries/clientpositive/udtf_explode.q U ql/src/test/queries/clientpositive/lateral_view_noalias.q U ql/src/test/queries/clientpositive/orc_empty_strings.q U ql/src/test/queries/clientpositive/varchar_comparison.q U ql/src/test/queries/clientpositive/truncate_column_merge.q U ql/src/test/queries/clientpositive/timestamp_udf.q U ql/src/test/queries/clientpositive/udf_find_in_set.q U ql/src/test/queries/clientpositive/udf_tan.q U ql/src/test/queries/clientpositive/null_cast.q U ql/src/test/queries/clientpositive/udf_regexp.q U ql/src/test/queries/clientpositive/timestamp_comparison.q U ql/src/test/queries/clientpositive/udf_when.q U ql/src/test/queries/clientpositive/udf_abs.q U ql/src/test/queries/clientpositive/udf_case_thrift.q U ql/src/test/queries/clientpositive/udf_to_short.q U ql/src/test/queries/clientpositive/udf_isnull_isnotnull.q U ql/src/test/queries/clientpositive/decimal_2.q U ql/src/test/queries/clientpositive/udf_struct.q U ql/src/test/queries/clientpositive/udf_greaterthan.q U ql/src/test/queries/clientpositive/udf_round_2.q U ql/src/test/queries/clientpositive/udf_compare_java_string.q U ql/src/test/queries/clientpositive/ops_comparison.q U ql/src/test/queries/clientpositive/udf_nvl.q U ql/src/test/queries/clientpositive/udf_conv.q U ql/src/test/queries/clientpositive/udf_field.q U ql/src/test/queries/clientpositive/literal_ints.q U ql/src/test/queries/clientpositive/udf_second.q U ql/src/test/queries/clientpositive/udf_translate.q U ql/src/test/queries/clientpositive/date_comparison.q U ql/src/test/queries/clientpositive/udf_degrees.q U ql/src/test/queries/clientpositive/udf_acos.q U ql/src/test/queries/clientpositive/timestamp_1.q U ql/src/test/queries/clientpositive/udf_greaterthanorequal.q U ql/src/test/queries/clientpositive/partition_special_char.q U ql/src/test/queries/clientpositive/udf_lpad.q U ql/src/test/queries/clientpositive/udf_to_long.q U ql/src/test/queries/clientpositive/udf_to_unix_timestamp.q U ql/src/test/queries/clientpositive/udf_hour.q U ql/src/test/queries/clientpositive/timestamp_3.q U ql/src/test/queries/clientpositive/udf_asin.q U ql/src/test/queries/clientpositive/alter_varchar2.q U ql/src/test/queries/clientpositive/literal_decimal.q U ql/src/test/queries/clientpositive/udf_xpath_string.q U ql/src/test/queries/clientpositive/udf_inline.q U ql/src/test/queries/clientpositive/udf_notequal.q U ql/src/test/queries/clientpositive/udf_java_method.q U ql/src/test/queries/clientpositive/udf_bitmap_and.q U ql/src/test/queries/clientpositive/udf_to_byte.q U ql/src/test/queries/clientpositive/udf_reflect.q U ql/src/test/queries/clientpositive/udf_format_number.q U ql/src/test/queries/clientpositive/num_op_type_conv.q U ql/src/test/queries/clientpositive/udf_bin.q U ql/src/test/queries/clientpositive/udf_repeat.q U ql/src/test/queries/clientpositive/udf_cos.q U ql/src/test/queries/clientpositive/literal_double.q U ql/src/test/queries/clientpositive/auto_join_reordering_values.q U ql/src/test/queries/clientpositive/udf_map_values.q U ql/src/test/queries/clientpositive/udf_notop.q U ql/src/test/queries/clientpositive/test_boolean_whereclause.q U ql/src/test/queries/clientpositive/udf_elt.q U ql/src/test/queries/clientpositive/date_1.q U ql/src/test/queries/clientpositive/truncate_column.q U ql/src/test/queries/clientpositive/udf_between.q U ql/src/test/queries/clientpositive/udf_to_float.q U ql/src/test/queries/clientpositive/str_to_map.q U ql/src/test/queries/clientpositive/udf_concat_ws.q U ql/src/test/queries/clientpositive/udf_sin.q U ql/src/test/queries/clientpositive/udf_explode.q U ql/src/test/queries/clientpositive/udf_to_double.q U ql/src/test/queries/clientpositive/udf_to_boolean.q U ql/src/test/queries/clientpositive/date_3.q U ql/src/test/queries/clientpositive/udf_equal.q U ql/src/test/queries/clientpositive/udf_lessthanorequal.q U ql/src/test/queries/clientpositive/udf_E.q U ql/src/test/queries/clientpositive/udf_unhex.q U ql/src/test/queries/clientpositive/udf_xpath_short.q U ql/src/test/queries/clientpositive/disallow_incompatible_type_change_off.q U ql/src/test/queries/clientpositive/compile_processor.q U ql/src/test/queries/clientpositive/timestamp_lazy.q U ql/src/test/queries/clientpositive/ppr_pushdown.q U ql/src/test/queries/clientpositive/udtf_json_tuple.q U ql/src/test/queries/clientpositive/partition_date.q U ql/src/test/queries/clientpositive/udf_bitmap_or.q U ql/src/test/queries/clientpositive/quote2.q U ql/src/test/queries/clientpositive/udf_xpath_long.q U ql/src/test/queries/clientpositive/udf_size.q U ql/src/test/queries/clientpositive/udf_divide.q U ql/src/test/queries/clientpositive/udf_unix_timestamp.q U ql/src/test/queries/clientpositive/filter_join_breaktask2.q U ql/src/test/queries/clientpositive/udf_substr.q U ql/src/test/queries/clientpositive/orc_diff_part_cols.q U ql/src/test/results/clientpositive/udf_xpath_short.q.out U ql/src/test/results/clientpositive/udf_xpath_string.q.out U ql/src/test/results/clientpositive/udf_to_double.q.out U ql/src/test/results/clientpositive/udf_union.q.out U ql/src/test/results/clientpositive/udf_isnull_isnotnull.q.out U ql/src/test/results/clientpositive/decimal_2.q.out U ql/src/test/results/clientpositive/timestamp_3.q.out U ql/src/test/results/clientpositive/decimal_udf.q.out U ql/src/test/results/clientpositive/udf_sign.q.out U ql/src/test/results/clientpositive/macro.q.out U ql/src/test/results/clientpositive/udf_pmod.q.out U ql/src/test/results/clientpositive/partcols1.q.out U ql/src/test/results/clientpositive/udf_to_boolean.q.out U ql/src/test/results/clientpositive/date_3.q.out U ql/src/test/results/clientpositive/udf_lessthan.q.out U ql/src/test/results/clientpositive/udf_radians.q.out U ql/src/test/results/clientpositive/truncate_column_merge.q.out U ql/src/test/results/clientpositive/timestamp_udf.q.out U ql/src/test/results/clientpositive/filter_join_breaktask2.q.out U ql/src/test/results/clientpositive/udf_bitmap_or.q.out U ql/src/test/results/clientpositive/timestamp_comparison.q.out U ql/src/test/results/clientpositive/udf_notop.q.out U ql/src/test/results/clientpositive/udf_like.q.out U ql/src/test/results/clientpositive/udf_round.q.out U ql/src/test/results/clientpositive/udf_case_thrift.q.out U ql/src/test/results/clientpositive/udf_hour.q.out U ql/src/test/results/clientpositive/udf_if.q.out U ql/src/test/results/clientpositive/udf_format_number.q.out U ql/src/test/results/clientpositive/udf_rpad.q.out U ql/src/test/results/clientpositive/udf_bin.q.out U ql/src/test/results/clientpositive/udf_div.q.out U ql/src/test/results/clientpositive/udf_field.q.out U ql/src/test/results/clientpositive/auto_join_reordering_values.q.out U ql/src/test/results/clientpositive/udf_negative.q.out U ql/src/test/results/clientpositive/quote2.q.out U ql/src/test/results/clientpositive/udf_ascii.q.out U ql/src/test/results/clientpositive/udf_atan.q.out U ql/src/test/results/clientpositive/ppr_pushdown.q.out U ql/src/test/results/clientpositive/udtf_json_tuple.q.out U ql/src/test/results/clientpositive/udf_hash.q.out U ql/src/test/results/clientpositive/union34.q.out U ql/src/test/results/clientpositive/udf_to_string.q.out U ql/src/test/results/clientpositive/udf_concat_ws.q.out U ql/src/test/results/clientpositive/udf_when.q.out U ql/src/test/results/clientpositive/udf_split.q.out U ql/src/test/results/clientpositive/udf_to_short.q.out U ql/src/test/results/clientpositive/udf_size.q.out U ql/src/test/results/clientpositive/udf_substr.q.out U ql/src/test/results/clientpositive/udf_between.q.out U ql/src/test/results/clientpositive/udf_weekofyear.q.out U ql/src/test/results/clientpositive/udf_testlength.q.out U ql/src/test/results/clientpositive/null_cast.q.out U ql/src/test/results/clientpositive/udf_named_struct.q.out U ql/src/test/results/clientpositive/udf_sin.q.out U ql/src/test/results/clientpositive/udf_bitmap_empty.q.out U ql/src/test/results/clientpositive/udf_regexp.q.out U ql/src/test/results/clientpositive/udf_space.q.out U ql/src/test/results/clientpositive/partition_special_char.q.out U ql/src/test/results/clientpositive/udf_lpad.q.out U ql/src/test/results/clientpositive/udf_length.q.out U ql/src/test/results/clientpositive/udf_xpath_long.q.out U ql/src/test/results/clientpositive/timestamp_lazy.q.out U ql/src/test/results/clientpositive/udf_map_keys.q.out U ql/src/test/results/clientpositive/literal_decimal.q.out U ql/src/test/results/clientpositive/orc_diff_part_cols.q.out U ql/src/test/results/clientpositive/transform1.q.out U ql/src/test/results/clientpositive/udf_lessthanorequal.q.out U ql/src/test/results/clientpositive/udf_degrees.q.out U ql/src/test/results/clientpositive/udf_divide.q.out U ql/src/test/results/clientpositive/udf_nvl.q.out U ql/src/test/results/clientpositive/decimal_1.q.out U ql/src/test/results/clientpositive/udf_hex.q.out U ql/src/test/results/clientpositive/timestamp_2.q.out U ql/src/test/results/clientpositive/literal_double.q.out U ql/src/test/results/clientpositive/udf_second.q.out U ql/src/test/results/clientpositive/constant_prop.q.out U ql/src/test/results/clientpositive/udf_find_in_set.q.out U ql/src/test/results/clientpositive/udf_testlength2.q.out U ql/src/test/results/clientpositive/udf_xpath_int.q.out U ql/src/test/results/clientpositive/udf_printf.q.out U ql/src/test/results/clientpositive/udf_E.q.out U ql/src/test/results/clientpositive/partition_varchar1.q.out U ql/src/test/results/clientpositive/udf_conv.q.out U ql/src/test/results/clientpositive/str_to_map.q.out U ql/src/test/results/clientpositive/udf_tan.q.out U ql/src/test/results/clientpositive/udf_round_3.q.out U ql/src/test/results/clientpositive/ppr_pushdown2.q.out U ql/src/test/results/clientpositive/udf_array.q.out U ql/src/test/results/clientpositive/udf_coalesce.q.out U ql/src/test/results/clientpositive/udf_acos.q.out U ql/src/test/results/clientpositive/udf_greaterthanorequal.q.out U ql/src/test/results/clientpositive/partition_date.q.out U ql/src/test/results/clientpositive/cast_to_int.q.out U ql/src/test/results/clientpositive/udtf_parse_url_tuple.q.out U ql/src/test/results/clientpositive/udf_to_long.q.out U ql/src/test/results/clientpositive/udf_xpath_float.q.out U ql/src/test/results/clientpositive/orc_empty_strings.q.out U ql/src/test/results/clientpositive/udf_sort_array.q.out U ql/src/test/results/clientpositive/partition_decode_name.q.out U ql/src/test/results/clientpositive/literal_string.q.out U ql/src/test/results/clientpositive/date_4.q.out U ql/src/test/results/clientpositive/disallow_incompatible_type_change_off.q.out U ql/src/test/results/clientpositive/udf_PI.q.out U ql/src/test/results/clientpositive/partition_date2.q.out U ql/src/test/results/clientpositive/udf_map_values.q.out U ql/src/test/results/clientpositive/udf_java_method.q.out U ql/src/test/results/clientpositive/udf_equal.q.out U ql/src/test/results/clientpositive/udf_greaterthan.q.out U ql/src/test/results/clientpositive/num_op_type_conv.q.out U ql/src/test/results/clientpositive/udf_unhex.q.out U ql/src/test/results/clientpositive/udf_case.q.out U ql/src/test/results/clientpositive/udf_xpath.q.out U ql/src/test/results/clientpositive/udf_explode.q.out U ql/src/test/results/clientpositive/udf_abs.q.out U ql/src/test/results/clientpositive/udf_xpath_double.q.out U ql/src/test/results/clientpositive/udf_bitmap_and.q.out U ql/src/test/results/clientpositive/udf_locate.q.out U ql/src/test/results/clientpositive/udf_instr.q.out U ql/src/test/results/clientpositive/udf_translate.q.out U ql/src/test/results/clientpositive/timestamp_1.q.out U ql/src/test/results/clientpositive/udf_xpath_boolean.q.out U ql/src/test/results/clientpositive/type_widening.q.out U ql/src/test/results/clientpositive/udf_map.q.out U ql/src/test/results/clientpositive/udf_notequal.q.out U ql/src/test/results/clientpositive/test_boolean_whereclause.q.out U ql/src/test/results/clientpositive/udf_concat.q.out U ql/src/test/results/clientpositive/compile_processor.q.out U ql/src/test/results/clientpositive/date_1.q.out U ql/src/test/results/clientpositive/udf_reflect.q.out U ql/src/test/results/clientpositive/alter_varchar2.q.out U ql/src/test/results/clientpositive/udf_in.q.out U ql/src/test/results/clientpositive/type_cast_1.q.out U ql/src/test/results/clientpositive/udf_get_json_object.q.out U ql/src/test/results/clientpositive/binary_constant.q.out U ql/src/test/results/clientpositive/udf_to_float.q.out U ql/src/test/results/clientpositive/udf_array_contains.q.out U ql/src/test/results/clientpositive/udf_repeat.q.out U ql/src/test/results/clientpositive/udf_cos.q.out U ql/src/test/results/clientpositive/literal_ints.q.out U ql/src/test/results/clientpositive/udf_elt.q.out U ql/src/test/results/clientpositive/ppd_union_view.q.out U ql/src/test/results/clientpositive/truncate_column.q.out U ql/src/test/results/clientpositive/udf_to_byte.q.out U ql/src/test/results/clientpositive/udf_struct.q.out U ql/src/test/results/clientpositive/udf_asin.q.out U ql/src/test/results/clientpositive/udf_round_2.q.out U ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java Fetching external item into 'hcatalog/src/test/e2e/harness' Updated external to revision 1537558. Updated to revision 1537558. + patchCommandPath=/data/hive-ptest/working/scratch/smart-apply-patch.sh + patchFilePath=/data/hive-ptest/working/scratch/build.patch + [[ -f /data/hive-ptest/working/scratch/build.patch ]] + chmod +x /data/hive-ptest/working/scratch/smart-apply-patch.sh + /data/hive-ptest/working/scratch/smart-apply-patch.sh /data/hive-ptest/working/scratch/build.patch The patch does not appear to apply with p0, p1, or p2 + exit 1 ' This message is automatically generated.
          Hide
          Xuefu Zhang added a comment -

          Patch #4 rebased with trunk right before mvn branch merging in. It's expected to be good for the latest as well.

          Metadata determination for round() output is improved, and corresponding test cases are added.

          Show
          Xuefu Zhang added a comment - Patch #4 rebased with trunk right before mvn branch merging in. It's expected to be good for the latest as well. Metadata determination for round() output is improved, and corresponding test cases are added.
          Hide
          Xuefu Zhang added a comment -

          Patch #5 added a line of comments in the code. So, essentially the same as patch #4.

          Show
          Xuefu Zhang added a comment - Patch #5 added a line of comments in the code. So, essentially the same as patch #4.
          Hide
          Hive QA added a comment -

          Overall: -1 at least one tests failed

          Here are the results of testing the latest attachment:
          https://issues.apache.org/jira/secure/attachment/12611459/HIVE-4523.5.patch

          ERROR: -1 due to 1 failed/errored test(s), 4550 tests executed
          Failed tests:

          org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_udf_round
          

          Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/96/testReport
          Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/96/console

          Messages:

          Executing org.apache.hive.ptest.execution.PrepPhase
          Executing org.apache.hive.ptest.execution.ExecutionPhase
          Executing org.apache.hive.ptest.execution.ReportingPhase
          Tests failed with: TestsFailedException: 1 tests failed
          

          This message is automatically generated.

          Show
          Hive QA added a comment - Overall : -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12611459/HIVE-4523.5.patch ERROR: -1 due to 1 failed/errored test(s), 4550 tests executed Failed tests: org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_udf_round Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/96/testReport Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/96/console Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests failed with: TestsFailedException: 1 tests failed This message is automatically generated.
          Hide
          Hive QA added a comment -

          Overall: -1 at least one tests failed

          Here are the results of testing the latest attachment:
          https://issues.apache.org/jira/secure/attachment/12611459/HIVE-4523.5.patch

          ERROR: -1 due to 1 failed/errored test(s), 4550 tests executed
          Failed tests:

          org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_udf_round
          

          Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/97/testReport
          Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/97/console

          Messages:

          Executing org.apache.hive.ptest.execution.PrepPhase
          Executing org.apache.hive.ptest.execution.ExecutionPhase
          Executing org.apache.hive.ptest.execution.ReportingPhase
          Tests failed with: TestsFailedException: 1 tests failed
          

          This message is automatically generated.

          Show
          Hive QA added a comment - Overall : -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12611459/HIVE-4523.5.patch ERROR: -1 due to 1 failed/errored test(s), 4550 tests executed Failed tests: org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_udf_round Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/97/testReport Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/97/console Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests failed with: TestsFailedException: 1 tests failed This message is automatically generated.
          Hide
          Xuefu Zhang added a comment -

          Patch #6 fixed the reported test failure.

          Show
          Xuefu Zhang added a comment - Patch #6 fixed the reported test failure.
          Hide
          Hive QA added a comment -

          Overall: +1 all checks pass

          Here are the results of testing the latest attachment:
          https://issues.apache.org/jira/secure/attachment/12611562/HIVE-4523.6.patch

          SUCCESS: +1 4550 tests passed

          Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/108/testReport
          Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/108/console

          Messages:

          Executing org.apache.hive.ptest.execution.PrepPhase
          Executing org.apache.hive.ptest.execution.ExecutionPhase
          Executing org.apache.hive.ptest.execution.ReportingPhase
          

          This message is automatically generated.

          Show
          Hive QA added a comment - Overall : +1 all checks pass Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12611562/HIVE-4523.6.patch SUCCESS: +1 4550 tests passed Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/108/testReport Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/108/console Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase This message is automatically generated.
          Hide
          Xuefu Zhang added a comment -

          Patch #7 changed back to original double rounding mechanism.

          Show
          Xuefu Zhang added a comment - Patch #7 changed back to original double rounding mechanism.
          Hide
          Hive QA added a comment -

          Overall: -1 at least one tests failed

          Here are the results of testing the latest attachment:
          https://issues.apache.org/jira/secure/attachment/12611603/HIVE-4523.7.patch

          ERROR: -1 due to 1 failed/errored test(s), 4550 tests executed
          Failed tests:

          org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_vectorized_math_funcs
          

          Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/113/testReport
          Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/113/console

          Messages:

          Executing org.apache.hive.ptest.execution.PrepPhase
          Executing org.apache.hive.ptest.execution.ExecutionPhase
          Executing org.apache.hive.ptest.execution.ReportingPhase
          Tests failed with: TestsFailedException: 1 tests failed
          

          This message is automatically generated.

          Show
          Hive QA added a comment - Overall : -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12611603/HIVE-4523.7.patch ERROR: -1 due to 1 failed/errored test(s), 4550 tests executed Failed tests: org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_vectorized_math_funcs Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/113/testReport Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/113/console Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests failed with: TestsFailedException: 1 tests failed This message is automatically generated.
          Hide
          Xuefu Zhang added a comment -

          Patch #8 fixed the failed test case. Hoping it's all good by now.

          Show
          Xuefu Zhang added a comment - Patch #8 fixed the failed test case. Hoping it's all good by now.
          Hide
          Hive QA added a comment -

          Overall: +1 all checks pass

          Here are the results of testing the latest attachment:
          https://issues.apache.org/jira/secure/attachment/12611626/HIVE-4523.8.patch

          SUCCESS: +1 4548 tests passed

          Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/115/testReport
          Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/115/console

          Messages:

          Executing org.apache.hive.ptest.execution.PrepPhase
          Executing org.apache.hive.ptest.execution.ExecutionPhase
          Executing org.apache.hive.ptest.execution.ReportingPhase
          

          This message is automatically generated.

          ATTACHMENT ID: 12611626

          Show
          Hive QA added a comment - Overall : +1 all checks pass Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12611626/HIVE-4523.8.patch SUCCESS: +1 4548 tests passed Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/115/testReport Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/115/console Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase This message is automatically generated. ATTACHMENT ID: 12611626
          Hide
          Brock Noland added a comment -

          +1

          Show
          Brock Noland added a comment - +1
          Hide
          Brock Noland added a comment -

          Thank you for your contribution Xuefu! I have committed this to trunk.

          Show
          Brock Noland added a comment - Thank you for your contribution Xuefu! I have committed this to trunk.
          Hide
          Ashutosh Chauhan added a comment - - edited

          FWIW, this patch has broken following query which used to work before this patch:

          hive>create table t1 (val double, digit int);
          hive> select round(val, digit) from t1;
          FAILED: SemanticException [Error 10014]: Line 1:7 Wrong arguments 'digit': ROUND second argument only takes constant
          

          cc: Xuefu Zhang , Brock Noland

          Show
          Ashutosh Chauhan added a comment - - edited FWIW, this patch has broken following query which used to work before this patch: hive>create table t1 (val double , digit int ); hive> select round(val, digit) from t1; FAILED: SemanticException [Error 10014]: Line 1:7 Wrong arguments 'digit': ROUND second argument only takes constant cc: Xuefu Zhang , Brock Noland
          Hide
          Xuefu Zhang added a comment -

          Yes, the new round UDF restricted to a constant scale parameter so as to have deterministic result metadata. This is especially important for decimal rounding. If desirable, this is can be fixed to support variable scale. However, special care is needed w.r.t decimal rounding.

          Show
          Xuefu Zhang added a comment - Yes, the new round UDF restricted to a constant scale parameter so as to have deterministic result metadata. This is especially important for decimal rounding. If desirable, this is can be fixed to support variable scale. However, special care is needed w.r.t decimal rounding.
          Hide
          Ashutosh Chauhan added a comment -

          I am not sure how many people use this functionality, but they will be right if they complain it as being a regression.

          Show
          Ashutosh Chauhan added a comment - I am not sure how many people use this functionality, but they will be right if they complain it as being a regression.
          Hide
          Ashutosh Chauhan added a comment -

          Not sure, if there is any standard around this in spec or not, but atleast mysql supports variable scale for doubles rounding.

          Show
          Ashutosh Chauhan added a comment - Not sure, if there is any standard around this in spec or not, but atleast mysql supports variable scale for doubles rounding.
          Hide
          Xuefu Zhang added a comment -

          I didn't find any spec on round() either. It's hard to image a use case that has variable rounding. Nevertheless, we can fix it if there is a complaint. For any exact type (int, long, decimal, etc) + variable rounding, we can return double as the type (or follow what mysql does).

          Show
          Xuefu Zhang added a comment - I didn't find any spec on round() either. It's hard to image a use case that has variable rounding. Nevertheless, we can fix it if there is a complaint. For any exact type (int, long, decimal, etc) + variable rounding, we can return double as the type (or follow what mysql does).

            People

            • Assignee:
              Xuefu Zhang
              Reporter:
              Fred Desing
            • Votes:
              1 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development