Hive
  1. Hive
  2. HIVE-4510

HS2 doesn't nest exceptions properly (fun debug times)

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.12.0
    • Component/s: HiveServer2, JDBC
    • Labels:
      None

      Description

      In SQLOperation.java lines 97 + 113 for instance, we catch errors and throw a new HiveSQLException, but we don't wrap the original exception.

      1. HIVE-4510.2.patch
        12 kB
        Thejas M Nair
      2. HIVE-4510.1.patch
        11 kB
        Thejas M Nair

        Activity

        Gunther Hagleitner created issue -
        Hide
        Thejas M Nair added a comment -

        HIVE-4510.1.patch - Chains exception in SQLOperation and HS2 jdbc code. Also adds exception details as part of Driver response object error string.

        Show
        Thejas M Nair added a comment - HIVE-4510 .1.patch - Chains exception in SQLOperation and HS2 jdbc code. Also adds exception details as part of Driver response object error string.
        Thejas M Nair made changes -
        Field Original Value New Value
        Attachment HIVE-4510.1.patch [ 12582018 ]
        Hide
        Carl Steinbach added a comment -

        The same problem occurs in HiveCommandOperation.java, line 113.

        Show
        Carl Steinbach added a comment - The same problem occurs in HiveCommandOperation.java, line 113.
        Hide
        Thejas M Nair added a comment -

        HIVE-4510.2.patch- Making change for HiveCommandOperation as well.

        Show
        Thejas M Nair added a comment - HIVE-4510 .2.patch- Making change for HiveCommandOperation as well.
        Thejas M Nair made changes -
        Attachment HIVE-4510.2.patch [ 12582115 ]
        Hide
        Thejas M Nair added a comment -

        Review board link - https://reviews.apache.org/r/10977/
        Carl Steinbach This includes the changes to HiveCommandOperation

        Show
        Thejas M Nair added a comment - Review board link - https://reviews.apache.org/r/10977/ Carl Steinbach This includes the changes to HiveCommandOperation
        Thejas M Nair made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Thejas M Nair made changes -
        Component/s HiveServer2 [ 12320408 ]
        Component/s JDBC [ 12314178 ]
        Hide
        Carl Steinbach added a comment -

        +1

        Show
        Carl Steinbach added a comment - +1
        Hide
        Carl Steinbach added a comment -

        I will commit this if someone else runs the tests and gives me a green light. Thanks.

        Show
        Carl Steinbach added a comment - I will commit this if someone else runs the tests and gives me a green light. Thanks.
        Hide
        Thejas M Nair added a comment -

        I am running the full hive unit test suite on this patch. I will update when it is done.

        Show
        Thejas M Nair added a comment - I am running the full hive unit test suite on this patch. I will update when it is done.
        Hide
        Thejas M Nair added a comment -

        I ran the full unit test suite, and it passed. Carl Steinbach can you please commit ?

        Show
        Thejas M Nair added a comment - I ran the full unit test suite, and it passed. Carl Steinbach can you please commit ?
        Hide
        Thejas M Nair added a comment -

        Should we commit this to 0.11 branch as well? It really helps debug problems, and it is a unlikely to cause stability issues.

        Show
        Thejas M Nair added a comment - Should we commit this to 0.11 branch as well? It really helps debug problems, and it is a unlikely to cause stability issues.
        Hide
        Ashutosh Chauhan added a comment -

        Committed to trunk. Thanks, Thejas!

        Show
        Ashutosh Chauhan added a comment - Committed to trunk. Thanks, Thejas!
        Ashutosh Chauhan made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Fix Version/s 0.12.0 [ 12324312 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in Hive-trunk-hadoop2 #223 (See https://builds.apache.org/job/Hive-trunk-hadoop2/223/)
        HIVE-4510 : HS2 doesn't nest exceptions properly (fun debug times) (Thejas Nair via Ashutosh Chauhan) (Revision 1488740)

        Result = ABORTED
        hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1488740
        Files :

        • /hive/trunk/jdbc/src/java/org/apache/hive/jdbc/HiveBaseResultSet.java
        • /hive/trunk/jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java
        • /hive/trunk/jdbc/src/java/org/apache/hive/jdbc/HiveDatabaseMetaData.java
        • /hive/trunk/jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java
        • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java
        • /hive/trunk/service/src/java/org/apache/hive/service/cli/operation/HiveCommandOperation.java
        • /hive/trunk/service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java
        Show
        Hudson added a comment - Integrated in Hive-trunk-hadoop2 #223 (See https://builds.apache.org/job/Hive-trunk-hadoop2/223/ ) HIVE-4510 : HS2 doesn't nest exceptions properly (fun debug times) (Thejas Nair via Ashutosh Chauhan) (Revision 1488740) Result = ABORTED hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1488740 Files : /hive/trunk/jdbc/src/java/org/apache/hive/jdbc/HiveBaseResultSet.java /hive/trunk/jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java /hive/trunk/jdbc/src/java/org/apache/hive/jdbc/HiveDatabaseMetaData.java /hive/trunk/jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java /hive/trunk/service/src/java/org/apache/hive/service/cli/operation/HiveCommandOperation.java /hive/trunk/service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java
        Hide
        Hudson added a comment -

        Integrated in Hive-trunk-h0.21 #2126 (See https://builds.apache.org/job/Hive-trunk-h0.21/2126/)
        HIVE-4510 : HS2 doesn't nest exceptions properly (fun debug times) (Thejas Nair via Ashutosh Chauhan) (Revision 1488740)

        Result = FAILURE
        hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1488740
        Files :

        • /hive/trunk/jdbc/src/java/org/apache/hive/jdbc/HiveBaseResultSet.java
        • /hive/trunk/jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java
        • /hive/trunk/jdbc/src/java/org/apache/hive/jdbc/HiveDatabaseMetaData.java
        • /hive/trunk/jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java
        • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java
        • /hive/trunk/service/src/java/org/apache/hive/service/cli/operation/HiveCommandOperation.java
        • /hive/trunk/service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java
        Show
        Hudson added a comment - Integrated in Hive-trunk-h0.21 #2126 (See https://builds.apache.org/job/Hive-trunk-h0.21/2126/ ) HIVE-4510 : HS2 doesn't nest exceptions properly (fun debug times) (Thejas Nair via Ashutosh Chauhan) (Revision 1488740) Result = FAILURE hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1488740 Files : /hive/trunk/jdbc/src/java/org/apache/hive/jdbc/HiveBaseResultSet.java /hive/trunk/jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java /hive/trunk/jdbc/src/java/org/apache/hive/jdbc/HiveDatabaseMetaData.java /hive/trunk/jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java /hive/trunk/service/src/java/org/apache/hive/service/cli/operation/HiveCommandOperation.java /hive/trunk/service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java
        Hide
        Ashutosh Chauhan added a comment -

        This issue has been fixed and released as part of 0.12 release. If you find further issues, please create a new jira and link it to this one.

        Show
        Ashutosh Chauhan added a comment - This issue has been fixed and released as part of 0.12 release. If you find further issues, please create a new jira and link it to this one.
        Ashutosh Chauhan made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Thejas M Nair
            Reporter:
            Gunther Hagleitner
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development