Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: vectorization-branch, 0.13.0
    • Component/s: None
    • Labels:
      None
    1. Hive-4483.0.patch
      48 kB
      Sarvesh Sakalanaga

      Activity

      Hide
      Ashutosh Chauhan added a comment -

      Thanks for explaination.
      Committed to branch. Thanks, Sarvesh!

      Show
      Ashutosh Chauhan added a comment - Thanks for explaination. Committed to branch. Thanks, Sarvesh!
      Hide
      Sarvesh Sakalanaga added a comment -

      The changes to these files are required. VectorizedColumnarSerde inherits from ColumnarSerde and as such I need access to ColumnarSerde's serdeParams member from subclass to serialize the string in bytes vector correctly. I also need to change LazyUtils as LazyUtils::writeEscaped visibility was set to private and VectorizedColumnarSerde needs to access this method to correctly serialize the string(VectorizedColumnarSerde::serializeVector).

      Show
      Sarvesh Sakalanaga added a comment - The changes to these files are required. VectorizedColumnarSerde inherits from ColumnarSerde and as such I need access to ColumnarSerde's serdeParams member from subclass to serialize the string in bytes vector correctly. I also need to change LazyUtils as LazyUtils::writeEscaped visibility was set to private and VectorizedColumnarSerde needs to access this method to correctly serialize the string(VectorizedColumnarSerde::serializeVector).
      Hide
      Ashutosh Chauhan added a comment -

      Seems like changes in ColumnarSerde & LazyUtils are unnecessary. If they are not required for this patch, can you plz revert them?

      Show
      Ashutosh Chauhan added a comment - Seems like changes in ColumnarSerde & LazyUtils are unnecessary. If they are not required for this patch, can you plz revert them?
      Hide
      Sarvesh Sakalanaga added a comment -
      Show
      Sarvesh Sakalanaga added a comment - Review available at: https://reviews.apache.org/r/11059/
      Hide
      Sarvesh Sakalanaga added a comment -

      The patch also contains implementation for VectorizedColumnarSerDe that can be used with CommonRCInputFormat to read vectorized data from RC file.

      Show
      Sarvesh Sakalanaga added a comment - The patch also contains implementation for VectorizedColumnarSerDe that can be used with CommonRCInputFormat to read vectorized data from RC file.
      Hide
      Sarvesh Sakalanaga added a comment -

      Patch available.

      Show
      Sarvesh Sakalanaga added a comment - Patch available.

        People

        • Assignee:
          Sarvesh Sakalanaga
          Reporter:
          Sarvesh Sakalanaga
        • Votes:
          0 Vote for this issue
          Watchers:
          2 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development