Uploaded image for project: 'Hive'
  1. Hive
  2. HIVE-4420

HCatalog unit tests stop after a failure

Details

    Description

      HCatalog splits it's different components (core, hcatalog-pig-adaptor, webhcat, etc.) into separate build.xml files, all controlled by the top build.xml. A side effect of this is that when the user does "ant test" and the top build file is iterating through the tests, if one of the component's test targets fail then unit tests are not run for subsequent components. This means a failure in one component can mask issues in others.

      test should run on all the components even when there is a failure in one of the components.

      Attachments

        1. HIVE-4420.patch
          2 kB
          Alan Gates

        Activity

          gates Alan Gates added a comment -

          Attaching a patch that puts the tests in a parallel structure so that each one is run. Tests are still run serially by setting parallelism to 1, but a side effect of parallel is that each of its components is run even if one of them fails.

          gates Alan Gates added a comment - Attaching a patch that puts the tests in a parallel structure so that each one is run. Tests are still run serially by setting parallelism to 1, but a side effect of parallel is that each of its components is run even if one of them fails.

          Looks good to me, I've faked a test failure and am running tests. If tests continue to run, I will go ahead and commit.

          One important note to people visiting this bug later - the patch provided is for hcatalog/build.xml, not the root build.xml.

          sushanth Sushanth Sowmyan added a comment - Looks good to me, I've faked a test failure and am running tests. If tests continue to run, I will go ahead and commit. One important note to people visiting this bug later - the patch provided is for hcatalog/build.xml, not the root build.xml.

          Tested, works, and in fact, will also bypass and continue if there is a compile error in one group of tests. Potent! I'm waiting for the test run to finish to see if the overall test task results in a "BUILD SUCCESSFUL"(not expected) or a "BUILD FAILURE"(expected).

          sushanth Sushanth Sowmyan added a comment - Tested, works, and in fact, will also bypass and continue if there is a compile error in one group of tests. Potent! I'm waiting for the test run to finish to see if the overall test task results in a "BUILD SUCCESSFUL"(not expected) or a "BUILD FAILURE"(expected).

          +1, tests ran fully and ended with a BUILD FAILURE. Will commit to 0.11 and trunk.

          sushanth Sushanth Sowmyan added a comment - +1, tests ran fully and ended with a BUILD FAILURE. Will commit to 0.11 and trunk.

          Committed. Thanks, Alan!

          sushanth Sushanth Sowmyan added a comment - Committed. Thanks, Alan!
          gates Alan Gates added a comment -

          Thanks Sushanth.

          gates Alan Gates added a comment - Thanks Sushanth.
          hudson Hudson added a comment -

          Integrated in Hive-trunk-h0.21 #2080 (See https://builds.apache.org/job/Hive-trunk-h0.21/2080/)
          HIVE-4420 : HCatalog unit tests stop after a failure (Alan Gates via Sushanth Sowmyan) (Revision 1476444)

          Result = FAILURE
          khorgath : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1476444
          Files :

          • /hive/trunk/hcatalog/build.xml
          hudson Hudson added a comment - Integrated in Hive-trunk-h0.21 #2080 (See https://builds.apache.org/job/Hive-trunk-h0.21/2080/ ) HIVE-4420 : HCatalog unit tests stop after a failure (Alan Gates via Sushanth Sowmyan) (Revision 1476444) Result = FAILURE khorgath : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1476444 Files : /hive/trunk/hcatalog/build.xml
          hudson Hudson added a comment -

          Integrated in Hive-trunk-hadoop2 #177 (See https://builds.apache.org/job/Hive-trunk-hadoop2/177/)
          HIVE-4420 : HCatalog unit tests stop after a failure (Alan Gates via Sushanth Sowmyan) (Revision 1476444)

          Result = FAILURE
          khorgath : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1476444
          Files :

          • /hive/trunk/hcatalog/build.xml
          hudson Hudson added a comment - Integrated in Hive-trunk-hadoop2 #177 (See https://builds.apache.org/job/Hive-trunk-hadoop2/177/ ) HIVE-4420 : HCatalog unit tests stop after a failure (Alan Gates via Sushanth Sowmyan) (Revision 1476444) Result = FAILURE khorgath : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1476444 Files : /hive/trunk/hcatalog/build.xml

          People

            gates Alan Gates
            gates Alan Gates
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: