Hive
  1. Hive
  2. HIVE-4356

remove duplicate impersonation parameters for hiveserver2

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.11.0
    • Component/s: HiveServer2
    • Labels:
      None

      Description

      There are two parameters controlling impersonation in hiveserver2.
      hive.server2.enable.doAs that controls this in kerberos secure mode, while hive.server2.enable.doAs controls this for unsecure mode.
      We should have just one for both modes.

      1. HIVE-4356.1.patch
        13 kB
        Thejas M Nair

        Issue Links

          Activity

          Thejas M Nair created issue -
          Thejas M Nair made changes -
          Field Original Value New Value
          Attachment HIVE-4356.1.patch [ 12579024 ]
          Hide
          Thejas M Nair added a comment -

          HIVE-4356.1.patch - hive.server2.enabled.doAs now controls doAs functionality in both secure and unsecure modes. It is set to true by default, as in most cases, it makes sense to run hive with the permissions of the user submitting the query. This is also more secure.

          Review board link - https://reviews.apache.org/r/10554/

          Show
          Thejas M Nair added a comment - HIVE-4356 .1.patch - hive.server2.enabled.doAs now controls doAs functionality in both secure and unsecure modes. It is set to true by default, as in most cases, it makes sense to run hive with the permissions of the user submitting the query. This is also more secure. Review board link - https://reviews.apache.org/r/10554/
          Thejas M Nair made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Thejas M Nair added a comment -

          In HIVE-4356.1.patch, also refactors ThriftCLIService.OpenSession code to make it easier to test.

          Show
          Thejas M Nair added a comment - In HIVE-4356 .1.patch, also refactors ThriftCLIService.OpenSession code to make it easier to test.
          Hide
          Ashutosh Chauhan added a comment -

          +1

          Show
          Ashutosh Chauhan added a comment - +1
          Hide
          Ashutosh Chauhan added a comment -

          Committed to trunk. Thanks, Thejas!

          Show
          Ashutosh Chauhan added a comment - Committed to trunk. Thanks, Thejas!
          Ashutosh Chauhan made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Fix Version/s 0.12.0 [ 12324312 ]
          Fix Version/s 0.11.0 [ 12323587 ]
          Resolution Fixed [ 1 ]
          Hide
          Hudson added a comment -

          Integrated in Hive-trunk-hadoop2 #167 (See https://builds.apache.org/job/Hive-trunk-hadoop2/167/)
          HIVE-4356 : remove duplicate impersonation parameters for hiveserver2 (Gunther Hagleitner via Ashutosh Chauhan) (Revision 1470102)

          Result = FAILURE
          hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1470102
          Files :

          • /hive/trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
          • /hive/trunk/conf/hive-default.xml.template
          • /hive/trunk/service/src/java/org/apache/hive/service/auth/PlainSaslHelper.java
          • /hive/trunk/service/src/java/org/apache/hive/service/cli/CLIService.java
          • /hive/trunk/service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java
          • /hive/trunk/service/src/test/org/apache/hive/service/auth
          • /hive/trunk/service/src/test/org/apache/hive/service/auth/TestPlainSaslHelper.java
          • /hive/trunk/service/src/test/org/apache/hive/service/cli/thrift
          • /hive/trunk/service/src/test/org/apache/hive/service/cli/thrift/TestThriftCLIService.java
          Show
          Hudson added a comment - Integrated in Hive-trunk-hadoop2 #167 (See https://builds.apache.org/job/Hive-trunk-hadoop2/167/ ) HIVE-4356 : remove duplicate impersonation parameters for hiveserver2 (Gunther Hagleitner via Ashutosh Chauhan) (Revision 1470102) Result = FAILURE hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1470102 Files : /hive/trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java /hive/trunk/conf/hive-default.xml.template /hive/trunk/service/src/java/org/apache/hive/service/auth/PlainSaslHelper.java /hive/trunk/service/src/java/org/apache/hive/service/cli/CLIService.java /hive/trunk/service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java /hive/trunk/service/src/test/org/apache/hive/service/auth /hive/trunk/service/src/test/org/apache/hive/service/auth/TestPlainSaslHelper.java /hive/trunk/service/src/test/org/apache/hive/service/cli/thrift /hive/trunk/service/src/test/org/apache/hive/service/cli/thrift/TestThriftCLIService.java
          Hide
          Hudson added a comment -

          Integrated in Hive-trunk-h0.21 #2072 (See https://builds.apache.org/job/Hive-trunk-h0.21/2072/)
          HIVE-4356 : remove duplicate impersonation parameters for hiveserver2 (Gunther Hagleitner via Ashutosh Chauhan) (Revision 1470102)

          Result = ABORTED
          hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1470102
          Files :

          • /hive/trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
          • /hive/trunk/conf/hive-default.xml.template
          • /hive/trunk/service/src/java/org/apache/hive/service/auth/PlainSaslHelper.java
          • /hive/trunk/service/src/java/org/apache/hive/service/cli/CLIService.java
          • /hive/trunk/service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java
          • /hive/trunk/service/src/test/org/apache/hive/service/auth
          • /hive/trunk/service/src/test/org/apache/hive/service/auth/TestPlainSaslHelper.java
          • /hive/trunk/service/src/test/org/apache/hive/service/cli/thrift
          • /hive/trunk/service/src/test/org/apache/hive/service/cli/thrift/TestThriftCLIService.java
          Show
          Hudson added a comment - Integrated in Hive-trunk-h0.21 #2072 (See https://builds.apache.org/job/Hive-trunk-h0.21/2072/ ) HIVE-4356 : remove duplicate impersonation parameters for hiveserver2 (Gunther Hagleitner via Ashutosh Chauhan) (Revision 1470102) Result = ABORTED hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1470102 Files : /hive/trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java /hive/trunk/conf/hive-default.xml.template /hive/trunk/service/src/java/org/apache/hive/service/auth/PlainSaslHelper.java /hive/trunk/service/src/java/org/apache/hive/service/cli/CLIService.java /hive/trunk/service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java /hive/trunk/service/src/test/org/apache/hive/service/auth /hive/trunk/service/src/test/org/apache/hive/service/auth/TestPlainSaslHelper.java /hive/trunk/service/src/test/org/apache/hive/service/cli/thrift /hive/trunk/service/src/test/org/apache/hive/service/cli/thrift/TestThriftCLIService.java
          Ashutosh Chauhan made changes -
          Fix Version/s 0.11.0 [ 12323587 ]
          Fix Version/s 0.12.0 [ 12324312 ]
          Carl Steinbach made changes -
          Link This issue breaks HIVE-4498 [ HIVE-4498 ]
          Owen O'Malley made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Lefty Leverenz made changes -
          Link This issue relates to HIVE-2935 [ HIVE-2935 ]

            People

            • Assignee:
              Thejas M Nair
              Reporter:
              Thejas M Nair
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development