Uploaded image for project: 'Hive'
  1. Hive
  2. HIVE-4300

ant thriftif generated code that is checkedin is not up-to-date

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.10.0
    • Fix Version/s: 0.12.0
    • Component/s: Thrift API
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      running 'ant thriftif -Dthrift.home=/usr/local' on a freshly checkedout trunk should be a no-op as per instructions

      However this is not the case. Some of files seem to be have been relocated or the classes in them are now in a different file.

      Below is the git status showing the state after the command is run:

      1. On branch trunk
      2. Changes not staged for commit:
      3. (use "git add/rm <file>..." to update what will be committed)
      4. (use "git checkout – <file>..." to discard changes in working directory)
        #
      5. modified: build.properties
      6. modified: metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Database.java
      7. modified: metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/EnvironmentContext.java
      8. modified: metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Index.java
      9. modified: metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Partition.java
      10. modified: metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/PrincipalPrivilegeSet.java
      11. modified: metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Schema.java
      12. modified: metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/SerDeInfo.java
      13. modified: metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/SkewedInfo.java
      14. modified: metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/StorageDescriptor.java
      15. modified: metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Table.java
      16. modified: metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java
      17. deleted: metastore/src/gen/thrift/gen-php/ThriftHiveMetastore.php
      18. deleted: metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php
      19. deleted: metastore/src/gen/thrift/gen-php/hive_metastore/hive_metastore_constants.php
      20. deleted: metastore/src/gen/thrift/gen-php/hive_metastore/hive_metastore_types.php
      21. deleted: metastore/src/gen/thrift/gen-php/hive_metastore_constants.php
      22. deleted: metastore/src/gen/thrift/gen-php/hive_metastore_types.php
      23. modified: metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote
      24. deleted: ql/src/gen/thrift/gen-php/queryplan/queryplan_types.php
      25. modified: serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/test/InnerStruct.java
      26. modified: serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/test/ThriftTestObj.java
      27. modified: serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde2/thrift/test/Complex.java
      28. modified: serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde2/thrift/test/IntString.java
      29. modified: serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde2/thrift/test/MegaStruct.java
      30. modified: serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde2/thrift/test/MiniStruct.java
      31. deleted: serde/src/gen/thrift/gen-php/serde/serde_constants.php
      32. deleted: serde/src/gen/thrift/gen-php/serde/serde_types.php
      33. deleted: service/src/gen/thrift/gen-php/hive_service/ThriftHive.php
      34. deleted: service/src/gen/thrift/gen-php/hive_service/hive_service_types.php
      35. modified: service/src/gen/thrift/gen-py/TCLIService/TCLIService-remote
      36. modified: service/src/gen/thrift/gen-py/hive_service/ThriftHive-remote
        #
      37. Untracked files:
      38. (use "git add <file>..." to include in what will be committed)
        #
      39. serde/src/gen/thrift/gen-cpp/complex_constants.cpp
      40. serde/src/gen/thrift/gen-cpp/complex_constants.h
      41. serde/src/gen/thrift/gen-cpp/complex_types.cpp
      42. serde/src/gen/thrift/gen-cpp/complex_types.h
      43. serde/src/gen/thrift/gen-cpp/megastruct_constants.cpp
      44. serde/src/gen/thrift/gen-cpp/megastruct_constants.h
      45. serde/src/gen/thrift/gen-cpp/megastruct_types.cpp
      46. serde/src/gen/thrift/gen-cpp/megastruct_types.h
      47. serde/src/gen/thrift/gen-cpp/testthrift_constants.cpp
      48. serde/src/gen/thrift/gen-cpp/testthrift_constants.h
      49. serde/src/gen/thrift/gen-cpp/testthrift_types.cpp
      50. serde/src/gen/thrift/gen-cpp/testthrift_types.h
      51. serde/src/gen/thrift/gen-php/Types.php
      52. serde/src/gen/thrift/gen-py/complex/
      53. serde/src/gen/thrift/gen-py/megastruct/
      54. serde/src/gen/thrift/gen-py/testthrift/
      55. serde/src/gen/thrift/gen-rb/complex_constants.rb
      56. serde/src/gen/thrift/gen-rb/complex_types.rb
      57. serde/src/gen/thrift/gen-rb/megastruct_constants.rb
      58. serde/src/gen/thrift/gen-rb/megastruct_types.rb
      59. serde/src/gen/thrift/gen-rb/testthrift_constants.rb
      60. serde/src/gen/thrift/gen-rb/testthrift_types.rb

        Attachments

        1. HIVE-4300.2.patch
          1.03 MB
          Roshan Naik
        2. HIVE-4300.patch
          1.04 MB
          Roshan Naik

          Issue Links

            Activity

              People

              • Assignee:
                roshan_naik Roshan Naik
                Reporter:
                roshan_naik Roshan Naik
              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: